[GitHub] spark issue #11867: [SPARK-14049] [CORE] Add functionality in spark history ...

2017-01-24 Thread paragpc
Github user paragpc commented on the issue: https://github.com/apache/spark/pull/11867 thanks @squito :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #16620: [SPARK-19263] DAGScheduler should avoid sending c...

2017-01-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16620#discussion_r97586026 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1193,7 +1193,14 @@ class DAGScheduler( }

[GitHub] spark pull request #16620: [SPARK-19263] DAGScheduler should avoid sending c...

2017-01-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16620#discussion_r97417513 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala --- @@ -648,4 +648,69 @@ class BasicSchedulerIntegrationSuite

[GitHub] spark pull request #16620: [SPARK-19263] DAGScheduler should avoid sending c...

2017-01-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16620#discussion_r97417399 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala --- @@ -648,4 +648,69 @@ class BasicSchedulerIntegrationSuite

[GitHub] spark pull request #16620: [SPARK-19263] DAGScheduler should avoid sending c...

2017-01-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16620#discussion_r97406162 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1218,7 +1225,9 @@ class DAGScheduler(

[GitHub] spark issue #16677: [WIP][SQL] Use map output statistices to improve global ...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16661: [SPARK-19313][ML][MLLIB] GaussianMixture should limit th...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16661 **[Test build #71937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71937/testReport)** for PR 16661 at commit

[GitHub] spark issue #16605: [SPARK-18884][SQL] Support Array[_] in ScalaUDF

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16605 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71935/ Test FAILed. ---

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16690 **[Test build #71938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71938/testReport)** for PR 16690 at commit

[GitHub] spark issue #16605: [SPARK-18884][SQL] Support Array[_] in ScalaUDF

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16605 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16605: [SPARK-18884][SQL] Support Array[_] in ScalaUDF

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16605 **[Test build #71939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71939/testReport)** for PR 16605 at commit

[GitHub] spark issue #16661: [SPARK-19313][ML][MLLIB] GaussianMixture should limit th...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16661 **[Test build #71937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71937/testReport)** for PR 16661 at commit

[GitHub] spark issue #16661: [SPARK-19313][ML][MLLIB] GaussianMixture should limit th...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16661 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16677: [WIP][SQL] Use map output statistices to improve global ...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71936/ Test PASSed. ---

[GitHub] spark pull request #16329: [SPARK-16046][DOCS] Aggregations in the Spark SQL...

2017-01-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16329#discussion_r97580048 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/JavaUserDefinedTypedAggregation.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark issue #16661: [SPARK-19313][ML][MLLIB] GaussianMixture should limit th...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71937/ Test PASSed. ---

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16689 yes. but please see my other comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on the issue: https://github.com/apache/spark/pull/16660 @viirya Which comment are you referring to? I thought i had included all of them ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn't fail...

2017-01-24 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16387 No the question is whether you tested without @viirya commit `b1ef9ec` (the last one that forces spills of in-memory maps), or just the very last version of the patch. --- If your project is set

[GitHub] spark issue #16605: [SPARK-18884][SQL] Support Array[_] in ScalaUDF

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16605 **[Test build #71940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71940/testReport)** for PR 16605 at commit

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14702 **[Test build #71941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71941/testReport)** for PR 14702 at commit

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16693 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16693 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71933/ Test PASSed. ---

[GitHub] spark pull request #16329: [SPARK-16046][DOCS] Aggregations in the Spark SQL...

2017-01-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16329#discussion_r97590536 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/JavaUserDefinedTypedAggregation.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark issue #16688: [TESTS][SQL] Setup testdata at the beginning for tests t...

2017-01-24 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/16688 cc @cloud-fan @gatorsmile Could you please trigger a test for this. Not sure why the last run didn't succeed. Thanks a lot. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16677: [WIP][SQL] Use map output statistices to improve global ...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16677 **[Test build #71936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71936/testReport)** for PR 16677 at commit

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16693 **[Test build #71933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71933/testReport)** for PR 16693 at commit

[GitHub] spark issue #16605: [SPARK-18884][SQL] Support Array[_] in ScalaUDF

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16605 **[Test build #71935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71935/testReport)** for PR 16605 at commit

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-24 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16690 Jenkins, ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #16329: [SPARK-16046][DOCS] Aggregations in the Spark SQL...

2017-01-24 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/16329#discussion_r97589440 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/JavaUserDefinedTypedAggregation.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-24 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16690 cc @vanzin @zsxwing (I was going to make a longer comment about removing `askWithRetry` and whether we need another method, but then saw the comments on the referenced PR -- I'll defer to

[GitHub] spark pull request #16582: [SPARK-19220][UI] Make redirection to HTTPS apply...

2017-01-24 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16582#discussion_r97610826 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -274,25 +277,28 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request #16582: [SPARK-19220][UI] Make redirection to HTTPS apply...

2017-01-24 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16582#discussion_r97610759 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -337,17 +350,20 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark issue #16582: [SPARK-19220][UI] Make redirection to HTTPS apply to all...

2017-01-24 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16582 > Why not simply remove old redirect handler like collection.removeHandler ? I find it cleaner to just not do something that to do it then have to undo things when they fail. --- If your

[GitHub] spark pull request #16138: [SPARK-16609] Add to_date/to_timestamp with forma...

2017-01-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16138#discussion_r97493826 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1177,6 +1177,9 @@ test_that("column functions", { c17 <- cov(c, c1) + cov("c", "c1") +

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15945 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71918/ Test FAILed. ---

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16138: [SPARK-16609] Add to_date/to_timestamp with format funct...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16138 The failed test is `udf5.q` in `HiveComparisonTest`, but I can't find `SELECT to_date('2001-10-30 10:30:00', '')` in it, can you point out where we write such a test? --- If your project is set

[GitHub] spark pull request #16668: [SPARK-18788][SPARKR] Add API for getNumPartition...

2017-01-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16668#discussion_r97492412 --- Diff: R/pkg/R/DataFrame.R --- @@ -3406,3 +3406,28 @@ setMethod("randomSplit", } sapply(sdfs, dataFrame)

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15880 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16606 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16552 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16687: [SPARK-19343][DStreams] Do once optimistic checkpoint be...

2017-01-24 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16687 cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #16661: [SPARK-19313][ML][MLLIB] GaussianMixture should l...

2017-01-24 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16661#discussion_r97499446 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala --- @@ -272,6 +277,10 @@ class GaussianMixture private ( }

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16689 (I might be wrong but was suspecting that it returns `NA` first as `logical` when we collect via `SerDe.scala` and then it ends up `numeric` due to the type coercion when `NA` is located first

[GitHub] spark issue #16138: [SPARK-16609] Add to_date/to_timestamp with format funct...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16138 @anabranch right, since there is little work done on the R side and this is mostly a pass through, just checking if the functions are callable without error like the test you have added should

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16552 **[Test build #71923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71923/testReport)** for PR 16552 at commit

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #71924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71924/testReport)** for PR 15880 at commit

[GitHub] spark pull request #16138: [SPARK-16609] Add to_date/to_timestamp with forma...

2017-01-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16138#discussion_r97492683 --- Diff: R/pkg/R/functions.R --- @@ -1746,7 +1750,7 @@ setMethod("toRadians", #' to_date(df$c) #' to_date(df$c, '-MM-dd') #' }

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16606 **[Test build #71922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71922/testReport)** for PR 16606 at commit

[GitHub] spark issue #16476: [SPARK-19084][SQL] Implement expression field

2017-01-24 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/16476 ping @rxin @gatorsmile @tejasapatil @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #12896: [SPARK-14489][ML][PYSPARK] ALS unknown user/item predict...

2017-01-24 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/12896 Reviving after a hiatus. Updated since tags. I've actually recently come across a number of users hitting this issue in production and are unable to use ALS with cross-validation as a result.

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15945 **[Test build #71926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71926/testReport)** for PR 15945 at commit

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16689 Oh @felixcheung , I was writing a comment but I just saw you. I was looking into this for my curiosity. Isn't this due to R type coercion rule with POSIXlt? ```r >

[GitHub] spark issue #16676: delete useless var ā€œjā€

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16676 **[Test build #71927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71927/testReport)** for PR 16676 at commit

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97500817 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark issue #12135: [SPARK-14352][SQL] approxQuantile should support multi c...

2017-01-24 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/12135 LGTM. @zhengruifeng did you manage to add a JIRA for exposing multi-col support in SparkR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable sup...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16552#discussion_r97492569 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -65,6 +65,11 @@ case class CreateTempViewUsing( }

[GitHub] spark pull request #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable sup...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16552#discussion_r97492625 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -65,6 +65,11 @@ case class CreateTempViewUsing( }

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16552 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #16663: [SPARK-18823][SPARKR] add support for assigning t...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16663: [SPARK-18823][SPARKR] add support for assigning to colum...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16663 merged to master and 2.1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn't fail...

2017-01-24 Thread samkum
Github user samkum commented on the issue: https://github.com/apache/spark/pull/16387 Hi, No, I havent test this with out the ExternalAppendOnlyMap fix if this is what you are asking. I tested it with changes to both the classes: TaskMemoryManager and

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/15945 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97498043 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -20,13 +20,15 @@ package org.apache.spark.sql import

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97498083 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16689 Thanks! I can verify this case and the fix. Could you please add some tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97498057 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71916/ Test FAILed. ---

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71920/ Test FAILed. ---

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16594: [SPARK-17078] [SQL] Show stats when explain

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16594 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71921/ Test FAILed. ---

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16688: [TESTS][SQL] Setup testdata at the beginning for tests t...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16688 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16594: [SPARK-17078] [SQL] Show stats when explain

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16594 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16606 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15945 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71917/ Test FAILed. ---

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16606 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71912/ Test FAILed. ---

[GitHub] spark issue #16688: [TESTS][SQL] Setup testdata at the beginning for tests t...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71919/ Test FAILed. ---

[GitHub] spark issue #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSet -> Se...

2017-01-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14907 We exposed `JdbcUtils.resultSetToRows`, but forgot to add a test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16552 **[Test build #71925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71925/testReport)** for PR 16552 at commit

[GitHub] spark issue #16676: delete useless var ā€œjā€

2017-01-24 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16676 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97503434 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97503551 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark pull request #15880: [SPARK-17913][SQL] compare atomic and string type...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15880 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-24 Thread tcondie
Github user tcondie commented on a diff in the pull request: https://github.com/apache/spark/pull/16686#discussion_r97620911 --- Diff: external/kafka-0-10-sql/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister --- @@ -1 +1 @@

[GitHub] spark issue #16685: [SPARK-19335] Introduce insert, update, and upsert comma...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16685 **[Test build #71943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71943/testReport)** for PR 16685 at commit

[GitHub] spark issue #16605: [SPARK-18884][SQL] Support Array[_] in ScalaUDF

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16605 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-24 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16377 LGTM Thanks! Merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees ha...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16377 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-24 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16377 Thanks @jkbradley! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #16685: [SPARK-19335] Introduce insert, update, and upser...

2017-01-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16685#discussion_r97619926 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -722,14 +724,246 @@ object JdbcUtils extends

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14702 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71941/ Test FAILed. ---

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-01-24 Thread jsoltren
Github user jsoltren commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r97622188 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -43,7 +43,7 @@ class BlacklistTrackerSuite extends

[GitHub] spark issue #16685: [SPARK-19335] Introduce insert, update, and upsert comma...

2017-01-24 Thread ilganeli
Github user ilganeli commented on the issue: https://github.com/apache/spark/pull/16685 @gatorsmile What is a "key" update and in what context would that sort of operation be needed? I don't think a secondary index on the table prevent this method from working, the primary

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-24 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/16694 cc @hhbyyh Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16694 **[Test build #71945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71945/testReport)** for PR 16694 at commit

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16694 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16694 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71945/ Test FAILed. ---

  1   2   3   4   5   >