[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113967945 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113969133 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113970275 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113976778 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113976699 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113976861 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17804 merging to master and branch-2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17237: [SPARK-19852][PYSPARK][ML] Update Python API setH...

2017-04-28 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17237#discussion_r113983452 --- Diff: python/pyspark/ml/feature.py --- @@ -1936,6 +1935,14 @@ class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid,

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-28 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113991432 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1478,6 +1481,13 @@ test_that("column functions", { lapply( list(list(x = 1,

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17783 Interesting, I think we got 0.2 from his github https://github.com/jimhester/lintr --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-28 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113992412 --- Diff: R/pkg/R/column.R --- @@ -67,8 +67,7 @@ operators <- list( "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = "mod",

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17802 You also need to add the new API to MimaExludes.scala https://github.com/apache/spark/blob/master/project/MimaExcludes.scala#L37-L39 --- If your project is set up for it, you can

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread anabranch
Github user anabranch commented on the issue: https://github.com/apache/spark/pull/17804 yeah it's broken in both, only visible in 1. Not sure if that needs to be in 2 PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965033 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966339 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966362 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17803 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17803 **[Test build #76269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76269/testReport)** for PR 17803 at commit

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17803 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76269/ Test FAILed. ---

[GitHub] spark issue #17790: [SPARK-20514][CORE] Upgrade Jetty to 9.3.11.v20160721

2017-04-28 Thread markgrover
Github user markgrover commented on the issue: https://github.com/apache/spark/pull/17790 Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17711: [SPARK-19951][SQL] Add string concatenate operato...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17711#discussion_r113972077 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -547,6 +547,10 @@ valueExpression |

[GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...

2017-04-28 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/17640#discussion_r113974703 --- Diff: R/pkg/R/serialize.R --- @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) { Date = writeDate(con,

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113976264 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17802 **[Test build #76277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76277/testReport)** for PR 17802 at commit

[GitHub] spark issue #17780: [SPARK-20487][SQL] `HiveTableScan` node is quite verbose...

2017-04-28 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17780 Can we at least include the serde? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17804 @anabranch can you open this against branch-2.1 instead of master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966304 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76275/testReport)** for PR 17804 at commit

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17804 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17785 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76270/ Test PASSed. ---

[GitHub] spark pull request #17805: [SparkR][DOC][SPARK-20477]: Document R bisecting ...

2017-04-28 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/17805 [SparkR][DOC][SPARK-20477]: Document R bisecting k-means in R programming guide ## What changes were proposed in this pull request? Add hyper link in the SparkR programming guide.

[GitHub] spark issue #17805: [SPARK-20477][SparkR][DOC]: Document R bisecting k-means...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17805 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76276/ Test PASSed. ---

[GitHub] spark issue #17805: [SPARK-20477][SparkR][DOC]: Document R bisecting k-means...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17805 **[Test build #76276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76276/testReport)** for PR 17805 at commit

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113979701 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113979717 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #76278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76278/testReport)** for PR 15009 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76279/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76280/testReport)** for PR 17783 at commit

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #76274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76274/testReport)** for PR 15009 at commit

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966069 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966089 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import

[GitHub] spark pull request #17800: [SPARK-20459][SQL] JdbcUtils throws IllegalStateE...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17800#discussion_r113971640 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -653,7 +653,13 @@ object JdbcUtils extends

[GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...

2017-04-28 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/17640#discussion_r113972686 --- Diff: R/pkg/R/serialize.R --- @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) { Date = writeDate(con,

[GitHub] spark issue #17805: [SPARK-20477][SparkR][DOC]: Document R bisecting k-means...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17805 **[Test build #76276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76276/testReport)** for PR 17805 at commit

[GitHub] spark issue #17805: [SPARK-20477][SparkR][DOC]: Document R bisecting k-means...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17805 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17790: [SPARK-20514][CORE] Upgrade Jetty to 9.3.11.v20160721

2017-04-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17790 If there are no more concerns I'll push this in the PM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17790: [SPARK-20514][CORE] Upgrade Jetty to 9.3.11.v20160721

2017-04-28 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17790 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76274/ Test PASSed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17783 OK, let's remove example output for now and leave `lintr` issues for another day. I wonder if we could actually remove `\dontrun`, push `sparkR.session` into `\dontshow` and still keep

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17804 @hvanhovell We need this fix in master as well. It somehow works magically in master, but is broken for sure in 2.1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17785 **[Test build #76270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76270/testReport)** for PR 17785 at commit

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76275/ Test PASSed. ---

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76275/testReport)** for PR 17804 at commit

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965269 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965053 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965237 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965109 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113971968 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17804 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17802 Thanks for the feedback. Updated PR according your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17802 **[Test build #76277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76277/testReport)** for PR 17802 at commit

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17802 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76277/ Test FAILed. ---

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17802 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76279/ Test FAILed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76279/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113995508 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76290/ Test FAILed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76290/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76291/ Test PASSed. ---

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76291/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17783 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043563 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1009,10 +1009,24 @@ private[spark] object RandomForest extends

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043568 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -138,9 +169,10 @@ class RandomForestSuite extends SparkFunSuite

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043558 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1037,7 +1051,10 @@ private[spark] object RandomForest extends

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #76288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76288/testReport)** for PR 15009 at commit

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76288/ Test PASSed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL][WIP] Set barrier to prevent re-enteri...

2017-04-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17770 @hvanhovell @rxin I've updated this accordingly. Do you have more comments on this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17346: [SPARK-19965][SS] DataFrame batch reader may fail to inf...

2017-04-28 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17346 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17793 **[Test build #76292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76292/testReport)** for PR 17793 at commit

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 @ajbozarth , I checked the UI related to attemptId, seems fine without issue. Can you please point out in which code potentially has the regression? Thanks! --- If your project is set up for

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 I assume only event log download will be effected with #17582 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-04-28 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r114043519 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1231,6 +1295,109 @@ class

[GitHub] spark issue #17736: [SPARK-20399][SQL] Can't use same regex pattern between ...

2017-04-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17736 @cloud-fan although @hvanhovell haven't comment yet, I will go to fix the inconsistency first and see if we have defined tests against it. --- If your project is set up for it, you can reply to

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-28 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/17556 For a (train) sample of continuous series, say {x0, x1, x2, x3, ..., x100}. Now spark select quantile as split point. Suppose 10-quantiles is used, and x2 is 1st quantile, and x10 is 2nd

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76290/testReport)** for PR 17783 at commit

[GitHub] spark issue #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17783 **[Test build #76291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76291/testReport)** for PR 17783 at commit

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r114043439 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -112,9 +138,11 @@ class RandomForestSuite extends SparkFunSuite

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17793 **[Test build #76292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76292/testReport)** for PR 17793 at commit

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17793 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76292/ Test PASSed. ---

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-28 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/17556 By the way, it's safe to use mean value as it is match the other libraries. If requested, I'd like to modify the PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17793 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-04-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17723 @mridulm if you're talking about `ServiceCredentialProvider.obtainCredentials`, which is a public interface that exposes UGI (`Credentials` in this case), then sure, it's probably worth to tweak it

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114044512 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17807: [SPARK-20532][SPARKR] Implement grouping and grou...

2017-04-28 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17807 [SPARK-20532][SPARKR] Implement grouping and grouping_id ## What changes were proposed in this pull request? Adds R wrappers for: - `o.a.s.sql.functions.grouping` as

  1   2   3   4   >