GitHub user jinxing64 opened a pull request:
https://github.com/apache/spark/pull/19330
Orderable MapType
## What changes were proposed in this pull request?
We can make MapType orderable, and thus usable in aggregates and joins.
## How was this patch tested?
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19321
**[Test build #82108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82108/testReport)**
for PR 19321 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19318
The `aggregateByKeyLocally` haven't been implemented. Please wait until
#19317 finished or merge that PR contents into this, otherwise this PR cannot
use. We should not open a PR which cannot
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r140630215
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,36 +462,55 @@ final class OnlineLDAOptimizer extends
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
@jkbradley, thanks for the comments. Who is supposed to create the followup
jira?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19332
Will check other assumes too soon and be back.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19310
Merged to master, branch-2.2 and branch-2.1.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19310
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19331
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19331
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82112/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19330
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82107/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19330
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19330
**[Test build #82107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82107/testReport)**
for PR 19330 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19329
**[Test build #82109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82109/testReport)**
for PR 19329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82109/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19322
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82113/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19322
**[Test build #82113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82113/testReport)**
for PR 19322 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19322
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82111/testReport)**
for PR 18924 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82111/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19310
@jsnowacki, I am merging this assuming you will fix up
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19331
[SPARK-22109][SQL] Resolves type conflicts between strings and timestamps
in partition column
## What changes were proposed in this pull request?
This PR proposes to resolve the type
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19322
**[Test build #82115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82115/testReport)**
for PR 19322 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82116/testReport)**
for PR 19222 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19331
cc @ueshin, could you take a look when you have some time please?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19322
**[Test build #82115 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82115/testReport)**
for PR 19322 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19322
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82115/
Test PASSed.
---
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19321
@felixcheung For percentiles, I think the type of results should be the
same as input data type. In these tests, the type of data is int, so actually
`30` is more accurate than `30.0`. The previous
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82111/testReport)**
for PR 18924 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19321
**[Test build #82108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82108/testReport)**
for PR 19321 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19321
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82108/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19321
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19331
**[Test build #82112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82112/testReport)**
for PR 19331 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19322
**[Test build #82113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82113/testReport)**
for PR 19322 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82110/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19310
**[Test build #82110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82110/testReport)**
for PR 19310 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19310
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19332
@vanzin, Could you take a look when you are available please?
---
-
To unsubscribe, e-mail:
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19332
[SPARK-22093][TESTS] Fixes `assume` in the tests for `Utils.resolveURIs`
and `Utils.resolveURI`
## What changes were proposed in this pull request?
This PR proposes to remove `assume`
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19332
**[Test build #82114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82114/testReport)**
for PR 19332 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/18924
@akopich follow-up JIRA created here
https://issues.apache.org/jira/browse/SPARK-22111
Can you create follow up PR after this PR being merged ?
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19332
**[Test build #82117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82117/testReport)**
for PR 19332 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19332
I checked other instances of `org.scalatest.Assertions.assume`. I am quite
sure of the ones here I added. I didn't add ones I am less sure of.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19331
**[Test build #82112 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82112/testReport)**
for PR 19331 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82103/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19330
**[Test build #82106 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82106/testReport)**
for PR 19330 at commit
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19330#discussion_r140627825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -663,6 +663,18 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13599
**[Test build #82104 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82104/testReport)**
for PR 13599 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19330
@jinxing64 thanks for taking over. I have glanced over the PR, and I miss
the explicit sorting of maps. We can't assume that maps are sorted out of the
box, for example the following example
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19310
**[Test build #82110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82110/testReport)**
for PR 19310 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19310
@holdenk @ueshin @HyukjinKwon as it says python pip package, but I'm pretty
this is cross language
---
-
To unsubscribe,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19321#discussion_r140627874
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -85,7 +85,8 @@ case class
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19330
It seems https://github.com/apache/spark/pull/15970 is not being worked.
I resolved conflicts and add some tests in this pr.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19330
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19330
**[Test build #82106 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82106/testReport)**
for PR 19330 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82105/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19330
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82106/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19329
**[Test build #82105 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82105/testReport)**
for PR 19329 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19320
**[Test build #82103 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82103/testReport)**
for PR 19320 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18936
Interesting, I wouldn't have expected much difference at all. Once it's in
native code these are all just SSE instructions on the silicon... I don't know
how it could be much different. But
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19310
I'm a little puzzled how this wouldn't broken on windows without this fix
with release build... need to run some tests to see.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82104/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19329
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19330
**[Test build #82107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82107/testReport)**
for PR 19330 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19329
**[Test build #82109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82109/testReport)**
for PR 19329 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19310
jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19329
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82114/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19277
**[Test build #3933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3933/testReport)**
for PR 19277 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17743
**[Test build #3934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3934/testReport)**
for PR 17743 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19331
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19331
Definitely.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19333
LGTM, pending Jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17743
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82120/testReport)**
for PR 19290 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82117/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19332
**[Test build #82117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82117/testReport)**
for PR 19332 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19332
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638128
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -749,6 +749,34 @@ class JDBCSuite extends SparkFunSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19333
@HyukjinKwon Could you close this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17743
**[Test build #3934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3934/testReport)**
for PR 17743 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19266
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19266
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19320
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19331
@HyukjinKwon Could you send a pr to backport this to branch-2.2 please?
---
-
To unsubscribe, e-mail:
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
@WeichenXu123, thanks for creating Jira. Yes, sure I will work on it.
---
-
To unsubscribe, e-mail:
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19330
@hvanhovell : based on [your comment over the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19333
**[Test build #82119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82119/testReport)**
for PR 19333 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19333
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82119/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19277
**[Test build #3933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3933/testReport)**
for PR 19277 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19333
Thanks! merging to branch-2.2.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19323
@ala can you close this one? The merge script does not do that for
backports.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19320
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19331
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
1 - 100 of 171 matches
Mail list logo
