Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19106
**[Test build #82551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82551/testReport)**
for PR 19106 at commit
Github user bdrillard commented on the issue:
https://github.com/apache/spark/pull/16648
I'm blocking out time to prepare the part 2 PR for this issue starting
today over this week, regarding compaction of excess primitive state.
cc: @kiszk
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19106
**[Test build #82551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82551/testReport)**
for PR 19106 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19106
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19106
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82551/
Test PASSed.
---
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143484031
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -804,45 +814,52 @@
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143344688
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -374,6 +375,15 @@
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143361887
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143487275
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82549/testReport)**
for PR 19363 at commit
Github user sohum2002 commented on the issue:
https://github.com/apache/spark/pull/19454
@HyukjinKwon - Thank you for your comments and analysis of this PR. I will
also try to improve the `flatMap(identity)` as mentioned by @srowen. Also, will
add a python implementation.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
ping for review @hvanhovell @tejasapatil
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143481416
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143492975
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82549/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19454
BTW, for the answer to
https://github.com/apache/spark/pull/19454#issuecomment-335138642, I think you
should take a look at, for example, `flatMap` as a reference in `rdd.py` and
related
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17968#discussion_r143465176
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -1131,14 +1131,21 @@ def __getitem__(self, indices):
return self.values[i + j
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19457
**[Test build #3946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3946/testReport)**
for PR 19457 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/17968
@gglanzani And you the `ml.linalg.DenseMatrix` looks have the same bug. Can
you also update it ?
---
-
To unsubscribe,
Github user zivanfi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143462649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -266,6 +267,10 @@ final class DataFrameWriter[T] private[sql](ds:
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/17968
ping @gglanzani This bug need fixed ASAP. Can you update code when you're
free ? Thanks.
---
-
To unsubscribe, e-mail:
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143481784
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -157,21 +157,21 @@ class DataFrameStatSuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82552/testReport)**
for PR 19439 at commit
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143480931
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r143514294
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516496
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516384
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516595
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82552/testReport)**
for PR 19439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82552/
Test PASSed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18460
Gentle ping~, @gatorsmile . :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143529286
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -189,6 +305,136 @@ class Word2VecSuite extends SparkFunSuite
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143507748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -519,3 +519,18 @@ case class CoGroup(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19447#discussion_r143527821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -279,11 +279,11 @@ class CodegenContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82553/testReport)**
for PR 18732 at commit
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143506845
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,69 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r143524057
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed to
GitHub user superbobry opened a pull request:
https://github.com/apache/spark/pull/19458
[SPARK-7][CORE] DiskBlockManager.getAllBlocks now tolerates temp files
## What changes were proposed in this pull request?
Prior to this commit getAllBlocks implicitly assumed that
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143528173
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") (
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143529694
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -245,5 +508,28 @@ class Word2VecSuite extends SparkFunSuite
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r143530841
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java
---
@@ -0,0 +1,297 @@
+/*
+ *
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19394#discussion_r143517522
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -274,19 +274,26 @@ abstract class SparkPlan extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82555/testReport)**
for PR 19394 at commit
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19394#discussion_r143517490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -274,19 +274,26 @@ abstract class SparkPlan extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19266
@srowen Thanks!
@liufengdb Could you submit a separate PR to fix the issues and also please
include the test cases?
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18664
@HyukjinKwon and @ueshin so with Arrow, the Pandas DataFrame from
`toPandas()` timestamp columns will not have a timezone - are we going to do
the same thing for `pandas_udf` Series? I was
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19458#discussion_r143527010
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -100,7 +102,9 @@ private[spark] class DiskBlockManager(conf: SparkConf,
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143528339
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") (
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82556 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82556/testReport)**
for PR 19394 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19061
Hi, @vanzin and @jerryshao .
Could you review this `ConsoleProgressBar` issue when you have some time?
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19394
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19433
Thanks! I'll remove the WIP. To clear things up for the future, I'd thought
[WIP] was the appropriate tag for a PR that's ready for review but not ready to
be merged (based on
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19437
@susanxhuynh @skonto The secret-containing protos will be valid in Mesos
1.3 onwards, thus why the scheduler has that requirement. DC/OS with file-based
secrets has Mesos 1.4 thus why we test it
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19447#discussion_r143540779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -279,11 +279,11 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82557/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19433
**[Test build #82557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82557/testReport)**
for PR 19433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19433
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18853
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82554/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19459
**[Test build #82560 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82560/testReport)**
for PR 19459 at commit
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/19459
[SPARK-20791][PYSPARK] Use Arrow to create Spark DataFrame from Pandas
## What changes were proposed in this pull request?
This change uses Arrow to optimize the creation of a Spark
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19250
I pushed a bunch of changes to address feedback here and also my own
feedback that I didn't bother to write down. Main changes:
- cache the TimeZone instances in generated code
- rename
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82553/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19269
Several things to discuss:
1. Since Spark can't disable speculation during runtime, currently there is
not much benefit to provide an interface for data source to disable
speculation,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19061
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19250
**[Test build #82561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82561/testReport)**
for PR 19250 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19433
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82553 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82553/testReport)**
for PR 18732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18853
**[Test build #82554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82554/testReport)**
for PR 18853 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18853
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19459
**[Test build #82559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82559/testReport)**
for PR 19459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19394
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82555/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82558/testReport)**
for PR 19394 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19433
**[Test build #82557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82557/testReport)**
for PR 19433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19394
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82556/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82556 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82556/testReport)**
for PR 19394 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19394
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82555 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82555/testReport)**
for PR 19394 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19459
**[Test build #82559 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82559/testReport)**
for PR 19459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19459
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82559/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19459
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19061
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19309#discussion_r143562613
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/ExecutionListenerManagerSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user VDuda commented on the issue:
https://github.com/apache/spark/pull/19442
Following the issue, does this mean that this PR resolves
https://issues.apache.org/jira/browse/SPARK-8515 ?
---
-
To
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19450
Merging to master / 2.2.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/19450
thanks @vanzin, sorry I had made the test changes but hadn't pushed them.
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19450
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user liufengdb opened a pull request:
https://github.com/apache/spark/pull/19460
[SPARK-2][core] Fix the ARRAY_MAX in BufferHolder and add a test
## What changes were proposed in this pull request?
We should not break the assumption that the length of the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143564830
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,6 +40,15 @@ public static int
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19460
**[Test build #82562 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82562/testReport)**
for PR 19460 at commit
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143566804
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19061
Thank you for review and merging, @vanzin !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143567807
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143567788
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143567888
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19433
The failing tests (in `DecisionTreeSuite`) fail because we've historically
handled
a) splits that have 0 gain
differently from
b) splits that fail to achieve
1 - 100 of 345 matches
Mail list logo
