[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19501 **[Test build #82768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82768/testReport)** for PR 19501 at commit

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19501 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19501 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82768/ Test FAILed. ---

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19501 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19494: [SPARK-22249][SQL] isin with empty list throws ex...

2017-10-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19494#discussion_r144713232 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -104,7 +104,8 @@ case class

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19501 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82769/ Test PASSed. ---

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19501 **[Test build #82769 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82769/testReport)** for PR 19501 at commit

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19501 **[Test build #82769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82769/testReport)** for PR 19501 at commit

[GitHub] spark pull request #19494: [SPARK-22249][SQL] isin with empty list throws ex...

2017-10-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19494#discussion_r144711572 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -104,7 +104,8 @@ case class

[GitHub] spark issue #19485: [SPARK-20055] [Docs] Added documentation for loading csv...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19485 Yup, I think that's what I initially intended in the JIRA. Not sure for the iframe idea, for now. I'd just make it simple like with links. ---

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-15 Thread sathiyapk
Github user sathiyapk commented on the issue: https://github.com/apache/spark/pull/19451 @gatorsmile one quick question, could you please say which rule is transforming the filter conditions like `'b === 2` to `'b.isNotNull && 'b === 2` ? thanks! ---

[GitHub] spark issue #19497: [SPARK-21549][CORE] Respect OutputFormats with no/invali...

2017-10-15 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/19497 Thx for taking a deeper look @HyukjinKwon, much appreciated ! I will wait for @jiangxb1987 to also opine before committing - I want to make sure we are not adding incorrect behavior; given that

[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...

2017-10-15 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19494 @srowen I also updated the UT to check all the possible cases. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19501 **[Test build #82768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82768/testReport)** for PR 19501 at commit

[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19501 [SPARK-3][SQL] ObjectHashAggregate should not introduce unnecessary shuffle ## What changes were proposed in this pull request? `ObjectHashAggregateExec` should override

[GitHub] spark issue #18277: [SPARK-20947][PYTHON] Fix encoding/decoding error in pip...

2017-10-15 Thread sasameti
Github user sasameti commented on the issue: https://github.com/apache/spark/pull/18277 how do I apply the patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...

2017-10-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17402 ping @jsoltren --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19496: [SPARK-22271][SQL]mean overflows and returns null...

2017-10-15 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19496#discussion_r144723280 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2103,4 +2103,13 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #19485: [SPARK-20055] [Docs] Added documentation for loading csv...

2017-10-15 Thread jomach
Github user jomach commented on the issue: https://github.com/apache/spark/pull/19485 So I removed the duplicated stuff and added the links. I do it on purpose not to add more example as the document is getting huge and hard to find stuff. What do you think ? ---

[GitHub] spark issue #17422: [SPARK-20087] Attach accumulators / metrics to 'TaskKill...

2017-10-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17422 @noodle-fb could you rebase this so we can review it? Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #18784: [SPARK-21559][Mesos] remove mesos fine-grained mode

2017-10-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18784 @skonto @ArtRand @susanxhuynh Do we still want this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #18692: [SPARK-21417][SQL] Infer join conditions using pr...

2017-10-15 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/18692#discussion_r144722742 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +152,71 @@ object EliminateOuterJoin extends

[GitHub] spark issue #19500: [SPARK-22280][SQL][TEST] Improve StatisticsSuite to test...

2017-10-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19500 Hi, @gatorsmile . Could you review this PR about improving TESTCASE? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19496: [SPARK-22271][SQL]mean overflows and returns null...

2017-10-15 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/19496#discussion_r144732734 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2103,4 +2103,13 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #19495: [SPARK-22278][SS] Expose current event time water...

2017-10-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19495#discussion_r144736325 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/GroupStateImpl.scala --- @@ -119,32 +115,39 @@ private[sql] class

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742495 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742542 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742600 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742634 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19502 Thank you, @HyukjinKwon ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19502 **[Test build #82775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82775/testReport)** for PR 19502 at commit

[GitHub] spark issue #19317: [SPARK-22098][CORE] Add new method aggregateByKeyLocally...

2017-10-15 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19317 Hi @WeichenXu123, any comments on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18784: [SPARK-21559][Mesos] remove mesos fine-grained mode

2017-10-15 Thread ArtRand
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18784 @jiangxb1987 yes. I'll work to review this ASAP. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Remove OrcRelation.ORC_COMPRES...

2017-10-15 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/19502 [SPARK-22282][SQL] Remove OrcRelation.ORC_COMPRESSION ## What changes were proposed in this pull request? This PR aims to replace `OrcRelation.ORC_COMPRESSION` with

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742476 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileF...

2017-10-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144745832 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -42,7 +44,7 @@ private[orc] class OrcOptions( val

[GitHub] spark issue #19496: [SPARK-22271][SQL]mean overflows and returns null for so...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19496 **[Test build #82770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82770/testReport)** for PR 19496 at commit

[GitHub] spark issue #19492: [SPARK-22228][SQL] Add support for array...

2017-10-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19492 @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19497: [SPARK-21549][CORE] Respect OutputFormats with no/invali...

2017-10-15 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/19497 Thanks for the reviews everyone ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19501#discussion_r144742648 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -636,4 +637,33 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Remove OrcRelation.ORC_COMPRES...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144742687 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala --- @@ -256,9 +257,6 @@ private[orc] class OrcOutputWriter( }

[GitHub] spark issue #16964: [SPARK-19534][TESTS] Convert Java tests to use lambdas, ...

2017-10-15 Thread dahaian
Github user dahaian commented on the issue: https://github.com/apache/spark/pull/16964 @zzcclp@srowen I have the same error. In JavaConsumerStrategySuite.java,error is as follows: The method mapValues(Function1) is ambiguous for the type Map

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-15 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/19451 Hi @sathiyapk , it is from `InferFiltersFromConstraints`. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #18692: [SPARK-21417][SQL] Infer join conditions using pr...

2017-10-15 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/18692#discussion_r144734911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +152,71 @@ object EliminateOuterJoin extends

[GitHub] spark issue #19496: [SPARK-22271][SQL]mean overflows and returns null for so...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19496 **[Test build #82770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82770/testReport)** for PR 19496 at commit

[GitHub] spark issue #19502: [SPARK-22282][SQL] Remove OrcRelation.ORC_COMPRESSION

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19502 **[Test build #82771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82771/testReport)** for PR 19502 at commit

[GitHub] spark issue #19497: [SPARK-21549][CORE] Respect OutputFormats with no/invali...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19497 @mridulm, BTW, WDYT about disallowing: ``` .saveAsNewAPIHadoopFile[...]("") .saveAsNewAPIHadoopFile[...]("::invalid:::") ``` within the APIs? If i tested this

[GitHub] spark issue #19502: [SPARK-22282][SQL] Remove OrcRelation.ORC_COMPRESSION

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19502 LGTM btw. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19502 **[Test build #82771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82771/testReport)** for PR 19502 at commit

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19502 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82771/ Test PASSed. ---

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19502 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19496: [SPARK-22271][SQL]mean overflows and returns null for so...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19496 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82770/ Test PASSed. ---

[GitHub] spark issue #19496: [SPARK-22271][SQL]mean overflows and returns null for so...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19496 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19439 **[Test build #82773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82773/testReport)** for PR 19439 at commit

[GitHub] spark pull request #19497: [SPARK-21549][CORE] Respect OutputFormats with no...

2017-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19497 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19501: [SPARK-22223][SQL] ObjectHashAggregate should not...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19501#discussion_r144739274 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -636,4 +637,33 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Remove OrcRelation.ORC_COMPRES...

2017-10-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144743034 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala --- @@ -256,9 +257,6 @@ private[orc] class OrcOutputWriter(

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19501 **[Test build #82774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82774/testReport)** for PR 19501 at commit

[GitHub] spark pull request #19464: [SPARK-22233] [core] Allow user to filter out emp...

2017-10-15 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19464#discussion_r144745022 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -270,6 +270,12 @@ package object config { .longConf

[GitHub] spark pull request #19464: [SPARK-22233] [core] Allow user to filter out emp...

2017-10-15 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19464#discussion_r144745063 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -270,6 +270,12 @@ package object config { .longConf

[GitHub] spark issue #19363: [SPARK-22224][SQL]Override toString of KeyValue/Relation...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19363 **[Test build #82776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82776/testReport)** for PR 19363 at commit

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileF...

2017-10-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144745102 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -42,7 +44,7 @@ private[orc] class OrcOptions( val

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileF...

2017-10-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144746184 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -42,7 +44,7 @@ private[orc] class OrcOptions( val

[GitHub] spark issue #19427: [SparkStreaming] Reset spark.driver.bindAddress when sta...

2017-10-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19427 yes, if you can open an issue in JIRA and update this PR title it should link automatically. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19218 **[Test build #82772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82772/testReport)** for PR 19218 at commit

[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...

2017-10-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17402 Pretty sure we can close this out. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742393 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-15 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144742423 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19500: [SPARK-22280][SQL][TEST] Improve StatisticsSuite ...

2017-10-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19500#discussion_r144745990 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -937,26 +937,22 @@ class StatisticsSuite extends

[GitHub] spark issue #19272: [Spark-21842][Mesos] Support Kerberos ticket renewal and...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19272 **[Test build #82777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82777/testReport)** for PR 19272 at commit

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19439 **[Test build #82773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82773/testReport)** for PR 19439 at commit

[GitHub] spark pull request #19503: Create myspark

2017-10-15 Thread dahaian
GitHub user dahaian opened a pull request: https://github.com/apache/spark/pull/19503 Create myspark ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this

[GitHub] spark pull request #19503: Create myspark

2017-10-15 Thread dahaian
Github user dahaian closed the pull request at: https://github.com/apache/spark/pull/19503 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark DataFra...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19459 LGTM too but let me leave it to @ueshin just in case. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19218 **[Test build #82772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82772/testReport)** for PR 19218 at commit

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19218 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19218 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82772/ Test FAILed. ---

[GitHub] spark pull request #19363: [SPARK-22224][SQL]Override toString of KeyValue/R...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19363#discussion_r144753122 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -465,6 +466,19 @@ class RelationalGroupedDataset

[GitHub] spark pull request #19363: [SPARK-22224][SQL]Override toString of KeyValue/R...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19363#discussion_r144753173 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -465,6 +466,19 @@ class RelationalGroupedDataset

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82774/ Test PASSed. ---

[GitHub] spark pull request #19492: [SPARK-22228][SQL] Add support for array

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19492#discussion_r144754775 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -89,6 +95,24 @@ class JacksonParser( /**

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19502 **[Test build #82781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82781/testReport)** for PR 19502 at commit

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileF...

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144756726 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala --- @@ -255,10 +256,7 @@ private[orc] class OrcOutputWriter( }

[GitHub] spark pull request #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileF...

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19502#discussion_r144756868 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala --- @@ -19,6 +19,7 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark pull request #19492: [SPARK-22228][SQL] Add support for array

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19492#discussion_r144757908 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -170,6 +160,31 @@ class JsonFunctionsSuite extends QueryTest with

[GitHub] spark pull request #19317: [SPARK-22098][CORE] Add new method aggregateByKey...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19317#discussion_r144757881 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -180,6 +180,56 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19501 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19501 Thanks @HyukjinKwon @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19439 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19501: [SPARK-22223][SQL] ObjectHashAggregate should not introd...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19501 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19500: [SPARK-22280][SQL][TEST] Improve StatisticsSuite ...

2017-10-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19500#discussion_r144749492 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -937,26 +937,22 @@ class StatisticsSuite extends

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19502 **[Test build #82778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82778/testReport)** for PR 19502 at commit

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r144750565 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala --- @@ -29,4 +32,19 @@ private[sql] object PythonSQLUtils {

[GitHub] spark issue #19502: [SPARK-22282][SQL] Rename OrcRelation to OrcFileFormat a...

2017-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19502 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19363: [SPARK-22224][SQL]Override toString of KeyValue/R...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19363#discussion_r144753076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -18,13 +18,13 @@ package org.apache.spark.sql

[GitHub] spark pull request #19363: [SPARK-22224][SQL]Override toString of KeyValue/R...

2017-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19363#discussion_r144753090 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -21,6 +21,7 @@ import java.util.Locale import

[GitHub] spark pull request #19492: [SPARK-22228][SQL] Add support for array

2017-10-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19492#discussion_r144754134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -35,19 +35,25 @@ import org.apache.spark.util.Utils

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-10-15 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18732 I'm +0 for now. I'm just wondering whether we can support struct types in vectorized UDF when needed in the future. As for adding pandas UDAF, I think we need another decorator or

[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...

2017-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19494 **[Test build #82780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82780/testReport)** for PR 19494 at commit

  1   2   >