[GitHub] spark issue #20670: [SPARK-23405] Generate additional constraints for Join's...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20670 LGTM except we should add a test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20676: [SPARK-23516][CORE] It is unnecessary to transfer unroll...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20676 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20449 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87701/ Test FAILed. ---

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20449 **[Test build #87701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87701/testReport)** for PR 20449 at commit

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20684 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20684 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20647 **[Test build #87702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87702/testReport)** for PR 20647 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20684 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20684 **[Test build #87708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87708/testReport)** for PR 20684 at commit

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r170840898 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -27,16 +27,15 @@ trait

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20684 **[Test build #87707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87707/testReport)** for PR 20684 at commit

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170842725 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-02-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r170842910 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -195,15 +205,15 @@ private static int numBytesForFirstByte(final

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20684 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1094/

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20684 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170843830 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20647 **[Test build #87710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87710/testReport)** for PR 20647 at commit

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170844624 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId {

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170844541 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId {

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170844718 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId {

[GitHub] spark issue #20666: [SPARK-23448][SQL] Clarify JSON and CSV parser behavior ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20666 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1095/

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20666: [SPARK-23448][SQL] Clarify JSON and CSV parser behavior ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20666 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1096/

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20684 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87707/ Test FAILed. ---

[GitHub] spark issue #20676: [SPARK-23516][CORE] It is unnecessary to transfer unroll...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20676 **[Test build #87705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87705/testReport)** for PR 20676 at commit

[GitHub] spark issue #20676: [SPARK-23516][CORE] It is unnecessary to transfer unroll...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20676 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87705/ Test FAILed. ---

[GitHub] spark issue #20676: [SPARK-23516][CORE] It is unnecessary to transfer unroll...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20676 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87704/ Test FAILed. ---

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87702/ Test FAILed. ---

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20449 **[Test build #87703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87703/testReport)** for PR 20449 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87698/ Test FAILed. ---

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20449 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20449 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87703/ Test FAILed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87698/testReport)** for PR 19222 at commit

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20684 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87700/ Test FAILed. ---

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20449 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20676: [SPARK-23516][CORE] It is unnecessary to transfer unroll...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20676 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20676: [SPARK-23516][CORE] It is unnecessary to transfer unroll...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20676 **[Test build #87704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87704/testReport)** for PR 20676 at commit

[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

2018-02-27 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20681#discussion_r170840835 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -885,24 +894,24 @@ test_that("collect() and take() on a DataFrame return the same number of rows an

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20684 **[Test build #87700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87700/testReport)** for PR 20684 at commit

[GitHub] spark issue #20668: [SPARK-23510][SQL] Support Hive 2.2 and Hive 2.3 metasto...

2018-02-27 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/20668 Yes, If we do not add `alterPartitionsMethod`, [HiveExternalSessionCatalogSuite.alter

[GitHub] spark issue #20684: [SPARK-23523] [SQL] Fix the incorrect result caused by t...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20684 **[Test build #87709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87709/testReport)** for PR 20684 at commit

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170842569 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170843555 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170843441 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20647 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170844986 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170844519 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170844540 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170844554 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20666: [SPARK-23448][SQL] Clarify JSON and CSV parser be...

2018-02-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20666#discussion_r170845040 --- Diff: python/pyspark/sql/readwriter.py --- @@ -393,13 +395,16 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170844335 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r170845905 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -320,6 +321,58 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark issue #20666: [SPARK-23448][SQL] Clarify JSON and CSV parser behavior ...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20666 **[Test build #87711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87711/testReport)** for PR 20666 at commit

[GitHub] spark pull request #20676: [SPARK-23516][CORE] It is unnecessary to transfer...

2018-02-27 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20676#discussion_r170961404 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -246,18 +246,18 @@ private[spark] class MemoryStore(

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-27 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20553 @cloud-fan @jiangxb1987 I assume you're referring to

[GitHub] spark issue #20679: [SPARK-23514] Use SessionState.newHadoopConf() to propag...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20679 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20676: [SPARK-23516][CORE] It is unnecessary to transfer...

2018-02-27 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20676#discussion_r170956019 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -246,18 +246,18 @@ private[spark] class MemoryStore(

[GitHub] spark pull request #20676: [SPARK-23516][CORE] It is unnecessary to transfer...

2018-02-27 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20676#discussion_r170954231 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -246,18 +246,18 @@ private[spark] class MemoryStore(

[GitHub] spark issue #20663: [SPARK-23501][UI] Refactor AllStagesPage in order to avo...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20663 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20663: [SPARK-23501][UI] Refactor AllStagesPage in order to avo...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20663 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution//

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20675: [SPARK-23033][SS][Follow Up] Task level retry for...

2018-02-27 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20675#discussion_r171011587 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala --- @@ -219,18 +219,59 @@ class ContinuousSuite

[GitHub] spark issue #20663: [SPARK-23501][UI] Refactor AllStagesPage in order to avo...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20663 **[Test build #87728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87728/testReport)** for PR 20663 at commit

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-27 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20553 Oops - knew we tried that before. Just paged in the discussion from https://github.com/apache/spark/pull/20460. Looks like that approach might need revisiting. ---

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20669 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1105/ ---

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20669 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1112/

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20669 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1113/

[GitHub] spark pull request #20647: [SPARK-23303][SQL] improve the explain result for...

2018-02-27 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/20647#discussion_r170989246 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StringFormat.scala --- @@ -0,0 +1,94 @@ +/* + *

[GitHub] spark pull request #20647: [SPARK-23303][SQL] improve the explain result for...

2018-02-27 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/20647#discussion_r170989638 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -36,10 +37,22 @@ import

[GitHub] spark issue #20679: [SPARK-23514] Use SessionState.newHadoopConf() to propag...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20679 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1114/

[GitHub] spark issue #20679: [SPARK-23514] Use SessionState.newHadoopConf() to propag...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20679 **[Test build #87730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87730/testReport)** for PR 20679 at commit

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87724/ Test FAILed. ---

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20647 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-27 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20669 @ifilonenko you can't just remove the init container without replacing its functionality. In my patch that was done by using spark-submit to run the driver. But here you have nothing. That's why the

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1115/

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20681 **[Test build #87731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87731/testReport)** for PR 20681 at commit

[GitHub] spark issue #20618: [SPARK-23329][SQL] Fix documentation of trigonometric fu...

2018-02-27 Thread misutoth
Github user misutoth commented on the issue: https://github.com/apache/spark/pull/20618 @felixcheung, I have started a mail thread on d...@spark.apache.org with title _Help needed in R documentation generation_ because I did not feel it is directly related to this PR. Thanks for your

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-27 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20553 @foxish I think the confusion mostly comes from the property name. I don't think we need to change the semantics of `spark.executor.cores` nor the way dynamic resource allocation works in K8S

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20604 **[Test build #87722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87722/testReport)** for PR 20604 at commit

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/20647 One more thing on matching the behavior of other nodes for the schema: since you agree that the scan nodes should report types, can you open an issue for it? I'm also fine adding it here instead of

[GitHub] spark pull request #20678: [SPARK-23380][PYTHON] Adds a conf for Arrow fallb...

2018-02-27 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20678#discussion_r170993760 --- Diff: python/pyspark/sql/tests.py --- @@ -3493,19 +3514,30 @@ def create_pandas_data_frame(self): data_dict["4_float_t"] =

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-27 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/20669 @vanzin you are definitely right and that is what needs to happen. However, one of the functions of the init container was resolving the file location which atm isn’t supported unless the

[GitHub] spark issue #20675: [SPARK-23033][SS][Follow Up] Task level retry for contin...

2018-02-27 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20675 It's not semantically wrong that the attempt number is never reset; it just means that for very long-running streams task restarts will eventually run out. You make a good point that in

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20604 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87722/ Test PASSed. ---

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20669 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1105/ ---

[GitHub] spark pull request #20684: [SPARK-23523] [SQL] Fix the incorrect result caus...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20684 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/20647 @cloud-fan, I found a couple new problems but otherwise this looks good. I see you rolled back the equality changes for the scan node and streaming relation. What is the JIRA issue to update v2

[GitHub] spark issue #20678: [SPARK-23380][PYTHON] Adds a conf for Arrow fallback in ...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20678 **[Test build #87719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87719/testReport)** for PR 20678 at commit

[GitHub] spark pull request #20663: [SPARK-23501][UI] Refactor AllStagesPage in order...

2018-02-27 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20663#discussion_r170978622 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -67,152 +41,120 @@ private[ui] class AllStagesPage(parent: StagesTab)

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-02-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20647 **[Test build #87724 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87724/testReport)** for PR 20647 at commit

[GitHub] spark issue #20575: [SPARK-23386][DEPLOY] enable direct application links in...

2018-02-27 Thread gerashegalov
Github user gerashegalov commented on the issue: https://github.com/apache/spark/pull/20575 Thanks for suggestions, I will look into them. I agree that a solution into the right direction will definitely involve changing the write call path. I did not go down this path because I have

[GitHub] spark issue #20663: [SPARK-23501][UI] Refactor AllStagesPage in order to avo...

2018-02-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20663 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20678: [SPARK-23380][PYTHON] Adds a conf for Arrow fallback in ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20678 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20678: [SPARK-23380][PYTHON] Adds a conf for Arrow fallback in ...

2018-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87719/ Test PASSed. ---

  1   2   3   4   5   >