[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationD...

2018-03-22 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r176365454 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -116,9 +120,12 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88521/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88524/ Test FAILed. ---

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88524 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88524/testReport)** for PR 20787 at commit

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20786 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20877 I am neutral. Does that fix actual usecases? I can help review anyway. Would you like to make a followup separately? --- -

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88523/testReport)** for PR 20787 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1712/

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #88516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88516/testReport)** for PR 19222 at commit

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88520/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88522/testReport)** for PR 20787 at commit

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20786 **[Test build #88508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88508/testReport)** for PR 20786 at commit

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88508/ Test PASSed. ---

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88514/ Test PASSed. ---

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20327 **[Test build #88514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88514/testReport)** for PR 20327 at commit

[GitHub] spark issue #20851: [SPARK-23727][SQL] Support for pushing down filters for ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88512/ Test PASSed. ---

[GitHub] spark issue #20851: [SPARK-23727][SQL] Support for pushing down filters for ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20851 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20826: [Spark-2489][SQL] Unsupported parquet datatype optional ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20826 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20826: [Spark-2489][SQL] Unsupported parquet datatype optional ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20826 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88513/ Test PASSed. ---

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88515/testReport)** for PR 20877 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88518/testReport)** for PR 20877 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88515/ Test FAILed. ---

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/20877 What about to make the option more flexible like in the PR: https://github.com/MaxGekk/spark-1/pull/1 ? It would be nice to handle JSON Streaming for example:

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20633 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88510/ Test PASSed. ---

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20633 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20877 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20541: [SPARK-23356][SQL]Pushes Project to both sides of Union ...

2018-03-22 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/20541 in my opinion, this is considered that PushProjectionThroughUnion optimizes rules when there are multiple columns of union in data sources, while projection requires only a few columns, and the

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20879 cc @felixcheung and @shaneknapp --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/20879 [MINOR][R] Fix R lint failure ## What changes were proposed in this pull request? The lint failure bugged me: ```R R/SQLContext.R:715:97: style: Trailing whitespace is

[GitHub] spark pull request #20880: Remove comments that unnecessarily disable Scalas...

2018-03-22 Thread arucard21
GitHub user arucard21 opened a pull request: https://github.com/apache/spark/pull/20880 Remove comments that unnecessarily disable Scalastyle check ## What changes were proposed in this pull request? I re-enabled the Scalastyle checker on a line of code. It was previously

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88522/ Test FAILed. ---

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88522/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20826: [Spark-2489][SQL] Unsupported parquet datatype optional ...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20826 **[Test build #88513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88513/testReport)** for PR 20826 at commit

[GitHub] spark issue #20851: [SPARK-23727][SQL] Support for pushing down filters for ...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20851 **[Test build #88512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88512/testReport)** for PR 20851 at commit

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88511/ Test PASSed. ---

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20879 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20864: [SPARK-23745][SQL]Remove the directories of the “hive....

2018-03-22 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20864 `add jar 'hdfs:///xxx.jar'` or create UDF will download jars to the resource dir: `CREATE FUNCTION xxx AS 'xxx' USING JAR 'hdfs:///xxx.jar' SELECT xxx()` ---

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20879 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1713/

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20879 **[Test build #88519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88519/testReport)** for PR 20879 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88516/ Test PASSed. ---

[GitHub] spark issue #20880: Remove comments that unnecessarily disable Scalastyle ch...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20880 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88523/ Test FAILed. ---

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88523/testReport)** for PR 20787 at commit

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20633 **[Test build #88510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88510/testReport)** for PR 20633 at commit

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20879 **[Test build #88519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88519/testReport)** for PR 20879 at commit

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20879 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20879 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88519/ Test PASSed. ---

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 Minor change does't need a JIRA though. Mind checking if there are similar instances while we are here? --- - To

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the catalog fo...

2018-03-22 Thread kevinyu98
Github user kevinyu98 commented on the issue: https://github.com/apache/spark/pull/20795 @viirya yes, my latest submitted code only caching the external functions, skip the built-in functions. @WeichenXu123 I will change this comment only

[GitHub] spark issue #20881: Add a note about jobs running in FIFO order in the defau...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20881 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 @HyukjinKwon I had actually already created a separate branch for the other fix and was already creating a separate PR for it. So the other fix is in #20882. I also think that the typo

[GitHub] spark issue #20882: [MINOR][CORE] Renamed long URL with shortened version

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20882 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 Also, I believe more correct way is `./dev/lint-scala` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20881: Add a note about jobs running in FIFO order in th...

2018-03-22 Thread Alexis-D
GitHub user Alexis-D opened a pull request: https://github.com/apache/spark/pull/20881 Add a note about jobs running in FIFO order in the default pool ## What changes were proposed in this pull request? Make it clear in the doc that setting `spark.scheduler.mode` to `FAIR`

[GitHub] spark issue #20882: [MINOR][CORE] Renamed long URL with shortened version

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20882 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 > let's include that change here. OK, I'll push the change in a few minutes. Should I close the other PR then? --- -

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20880 **[Test build #88525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88525/testReport)** for PR 20880 at commit

[GitHub] spark issue #20881: Add a note about jobs running in FIFO order in the defau...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20881 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 That's fine. Let's invlove another insrance here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 let's include that change here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-22 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19222 @cloud-fan Do you have additional comments? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88518/ Test PASSed. ---

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 ok to teat --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20882: [MINOR][CORE] Renamed long URL with shortened ver...

2018-03-22 Thread arucard21
Github user arucard21 closed the pull request at: https://github.com/apache/spark/pull/20882 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20880 **[Test build #88526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88526/testReport)** for PR 20880 at commit

[GitHub] spark issue #20882: [MINOR][CORE] Renamed long URL with shortened version

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20882 This change has been included in #20880 so a separate PR isn't necessary for it. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #88511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88511/testReport)** for PR 20345 at commit

[GitHub] spark issue #20880: Remove comments that unnecessarily disable Scalastyle ch...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20880 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88524/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88521/ Test PASSed. ---

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/20879 i've had to punt on figuring out how to get spark to reliably build across branches on the ubuntu workers... mostly because i haven't been able to successfully get the proper versions of

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88521/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88520/ Test PASSed. ---

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/20879 other than that, this PR LGTN++ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88518/testReport)** for PR 20877 at commit

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 I just ran `./dev/lint-scala` as well and the result is `Scalastyle checks passed.` As I mentioned in the JIRA issue, we looked at all the instances of `scalastyle:off` comments in

[GitHub] spark pull request #20882: [MINOR][CORE] Renamed long URL with shortened ver...

2018-03-22 Thread arucard21
GitHub user arucard21 opened a pull request: https://github.com/apache/spark/pull/20882 [MINOR][CORE] Renamed long URL with shortened version ## What changes were proposed in this pull request? We found that Scalastyle was disabled in `BlockReplicationPolicy.scala` because

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 yea pease --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 Just pushed another fix for Scalastyle code checking. It just replaces a URL with a shortened version so we don't violate the max line length. Also tested with `./dev/lint-scala`. ---

[GitHub] spark pull request #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler ...

2018-03-22 Thread blue666man
Github user blue666man commented on a diff in the pull request: https://github.com/apache/spark/pull/20641#discussion_r176475736 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala --- @@ -199,6 +199,38 @@

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88520/testReport)** for PR 20787 at commit

[GitHub] spark pull request #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uui...

2018-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20861 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20731: [SPARK-23579][Documentation] Added context model image a...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20731 I could try to create a simplified version of this image with just a few of these relations. But since that's still an image it would still be hard to update. So I can remove the image

[GitHub] spark issue #20731: [SPARK-23579][Documentation] Added context model image a...

2018-03-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/20731 Yea we gotta be careful with adding commercial vendor logos here. It's part of the complexity we need to navigate being hosted at the Apache Software Foundation. The project needs to be very vendor

[GitHub] spark issue #20867: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20867 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20867: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20867 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88527/ Test FAILed. ---

[GitHub] spark issue #20867: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20867 **[Test build #88527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88527/testReport)** for PR 20867 at commit

[GitHub] spark issue #20867: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread felixalbani
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20867 @vanzin I changed the base branch from master to branch-2.2 - 2 days ago - do I still need to close this and create it again? (its my first PR - my apologies for any inconvenience) ---

  1   2   3   4   >