Github user jcuquemelle commented on a diff in the pull request:
https://github.com/apache/spark/pull/19881#discussion_r176365454
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -116,9 +120,12 @@ private[spark] class ExecutorAllocationManager(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20327
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88521 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88521/testReport)**
for PR 20787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88524/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88524/testReport)**
for PR 20787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20786
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20877
I am neutral. Does that fix actual usecases? I can help review anyway.
Would you like to make a followup separately?
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88523/testReport)**
for PR 20787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20877
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1712/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #88516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88516/testReport)**
for PR 19222 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88520 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88520/testReport)**
for PR 20787 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88522/testReport)**
for PR 20787 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20786
**[Test build #88508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88508/testReport)**
for PR 20786 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20786
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88508/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20327
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88514/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20327
**[Test build #88514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88514/testReport)**
for PR 20327 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20851
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88512/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20851
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20826
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88513/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20877
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20877
**[Test build #88515 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88515/testReport)**
for PR 20877 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20877
**[Test build #88518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88518/testReport)**
for PR 20877 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20877
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88515/
Test FAILed.
---
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/20877
What about to make the option more flexible like in the PR:
https://github.com/MaxGekk/spark-1/pull/1 ? It would be nice to handle JSON
Streaming for example:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20633
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88510/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20633
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20877
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20877
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20541
in my opinion, this is considered that PushProjectionThroughUnion optimizes
rules when there are multiple columns of union in data sources, while
projection requires only a few columns, and the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20879
cc @felixcheung and @shaneknapp
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/20879
[MINOR][R] Fix R lint failure
## What changes were proposed in this pull request?
The lint failure bugged me:
```R
R/SQLContext.R:715:97: style: Trailing whitespace is
GitHub user arucard21 opened a pull request:
https://github.com/apache/spark/pull/20880
Remove comments that unnecessarily disable Scalastyle check
## What changes were proposed in this pull request?
I re-enabled the Scalastyle checker on a line of code. It was previously
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88522/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88522/testReport)**
for PR 20787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20826
**[Test build #88513 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88513/testReport)**
for PR 20826 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20851
**[Test build #88512 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88512/testReport)**
for PR 20851 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20345
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88511/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20345
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20879
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20864
`add jar 'hdfs:///xxx.jar'`
or create UDF will download jars to the resource dir:
`CREATE FUNCTION xxx AS 'xxx' USING JAR 'hdfs:///xxx.jar'
SELECT xxx()`
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20879
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1713/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20879
**[Test build #88519 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88519/testReport)**
for PR 20879 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88516/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20880
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88523/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88523 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88523/testReport)**
for PR 20787 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20633
**[Test build #88510 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88510/testReport)**
for PR 20633 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20879
**[Test build #88519 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88519/testReport)**
for PR 20879 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20879
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20879
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88519/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
Minor change does't need a JIRA though. Mind checking if there are similar
instances while we are here?
---
-
To
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/20795
@viirya yes, my latest submitted code only caching the external functions,
skip the built-in functions.
@WeichenXu123 I will change this comment only
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20881
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user arucard21 commented on the issue:
https://github.com/apache/spark/pull/20880
@HyukjinKwon I had actually already created a separate branch for the other
fix and was already creating a separate PR for it. So the other fix is in
#20882.
I also think that the typo
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20882
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
Also, I believe more correct way is `./dev/lint-scala`
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user Alexis-D opened a pull request:
https://github.com/apache/spark/pull/20881
Add a note about jobs running in FIFO order in the default pool
## What changes were proposed in this pull request?
Make it clear in the doc that setting `spark.scheduler.mode` to `FAIR`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20882
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user arucard21 commented on the issue:
https://github.com/apache/spark/pull/20880
> let's include that change here.
OK, I'll push the change in a few minutes. Should I close the other PR then?
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20880
**[Test build #88525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88525/testReport)**
for PR 20880 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20881
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
That's fine. Let's invlove another insrance here.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
let's include that change here.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
@cloud-fan Do you have additional comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20877
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20877
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88518/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
ok to teat
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user arucard21 closed the pull request at:
https://github.com/apache/spark/pull/20882
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20880
**[Test build #88526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88526/testReport)**
for PR 20880 at commit
Github user arucard21 commented on the issue:
https://github.com/apache/spark/pull/20882
This change has been included in #20880 so a separate PR isn't necessary
for it.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20345
**[Test build #88511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88511/testReport)**
for PR 20345 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20880
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88524/testReport)**
for PR 20787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88521/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/20879
i've had to punt on figuring out how to get spark to reliably build across
branches on the ubuntu workers... mostly because i haven't been able to
successfully get the proper versions of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88521 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88521/testReport)**
for PR 20787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88520/
Test PASSed.
---
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/20879
other than that, this PR LGTN++
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20877
**[Test build #88518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88518/testReport)**
for PR 20877 at commit
Github user arucard21 commented on the issue:
https://github.com/apache/spark/pull/20880
I just ran `./dev/lint-scala` as well and the result is `Scalastyle checks
passed.`
As I mentioned in the JIRA issue, we looked at all the instances of
`scalastyle:off` comments in
GitHub user arucard21 opened a pull request:
https://github.com/apache/spark/pull/20882
[MINOR][CORE] Renamed long URL with shortened version
## What changes were proposed in this pull request?
We found that Scalastyle was disabled in `BlockReplicationPolicy.scala`
because
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20880
yea pease
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user arucard21 commented on the issue:
https://github.com/apache/spark/pull/20880
Just pushed another fix for Scalastyle code checking. It just replaces a
URL with a shortened version so we don't violate the max line length. Also
tested with `./dev/lint-scala`.
---
Github user blue666man commented on a diff in the pull request:
https://github.com/apache/spark/pull/20641#discussion_r176475736
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -199,6 +199,38 @@
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20787
**[Test build #88520 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88520/testReport)**
for PR 20787 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20861
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user arucard21 commented on the issue:
https://github.com/apache/spark/pull/20731
I could try to create a simplified version of this image with just a few of
these relations. But since that's still an image it would still be hard to
update.
So I can remove the image
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/20731
Yea we gotta be careful with adding commercial vendor logos here. It's part
of the complexity we need to navigate being hosted at the Apache Software
Foundation. The project needs to be very vendor
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20867
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20867
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88527/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20867
**[Test build #88527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88527/testReport)**
for PR 20867 at commit
Github user felixalbani commented on the issue:
https://github.com/apache/spark/pull/20867
@vanzin I changed the base branch from master to branch-2.2 - 2 days
ago - do I still need to close this and create it again? (its my first PR - my
apologies for any inconvenience)
---
1 - 100 of 336 matches
Mail list logo