[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 I will first fix the tests, and then assert the performance if you agree. Changing the annotations might impact the performance. Regarding the difference between `NON_NULL`, `NON_ABSENT`,

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92246/ Test FAILed. ---

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21617 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92241/ Test FAILed. ---

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21617 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92246/testReport)** for PR 21596 at commit

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92243/ Test FAILed. ---

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92247: Deflake Build #92089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92247/testReport)** for PR 21109 at commit

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21618 **[Test build #92243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92243/testReport)** for PR 21618 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 Is this patch trying to make this into LICENSE/NOTICE appropriate for a source release? then they wouldn't work for a binary release. Maybe we can - address any gaps in the binary release

[GitHub] spark issue #21601: [SPARK-24610] fix reading small files via wholeTextFiles

2018-06-23 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/21601 I read your changes and in the test I was searching for an check/assert but found none. I understand it is about checking no exception is thrown during the directory content reading but I still

[GitHub] spark pull request #16677: [SPARK-19355][SQL] Use map output statistics to i...

2018-06-23 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16677#discussion_r197606877 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -145,10 +145,12 @@ public void write(Iterator>

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21542 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/433/

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92249/testReport)** for PR 21596 at commit

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/21618 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistics to improve ...

2018-06-23 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/16677 I am not sure if I am missing something - the count's obtained are at map side output per (map-side) partition; while limit is being computed at reduce side (after some arbitrary

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread justinmclean
Github user justinmclean commented on the issue: https://github.com/apache/spark/pull/21610 Yes it 's trying to correct if for the source release. As per the guiding principle [1] the LICENSE and NOTICE needs to represent what in the release this often mean you get different LICENSE

[GitHub] spark pull request #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread justinmclean
Github user justinmclean commented on a diff in the pull request: https://github.com/apache/spark/pull/21610#discussion_r197608023 --- Diff: NOTICE --- @@ -1,667 +1,11 @@ Apache Spark -Copyright 2014 and onwards The Apache Software Foundation. +Copyright 2014 - 20018

[GitHub] spark pull request #21620: [SPARK-24636][SQL] Type coercion of arrays for ar...

2018-06-23 Thread mn-mikke
GitHub user mn-mikke opened a pull request: https://github.com/apache/spark/pull/21620 [SPARK-24636][SQL] Type coercion of arrays for array_join function ## What changes were proposed in this pull request? Presto's implementation accepts arbitrary arrays of primitive types as an

[GitHub] spark issue #21620: [SPARK-24636][SQL] Type coercion of arrays for array_joi...

2018-06-23 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/21620 cc @ueshin @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21620: [SPARK-24636][SQL] Type coercion of arrays for array_joi...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21620 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21620: [SPARK-24636][SQL] Type coercion of arrays for array_joi...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21620 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 @Fokko, btw, I believe https://github.com/apache/spark/pull/21596#issuecomment-399160931 is a valid comment. I think it would be nicer if we execute this benchmark and update the results in

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 BTW, I believe it's okay to use Jenkins resource if that's a faster way to resolve this issue in any event. --- - To

[GitHub] spark issue #21614: Branch 2.3

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21614 @larry88, looks mistakenly open. Mind closing this please? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21610 **[Test build #92252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92252/testReport)** for PR 21610 at commit

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92239/ Test PASSed. ---

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 When looking at the history server, we have a similar issue. From at the list command

[GitHub] spark pull request #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21596#discussion_r197604227 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -244,6 +244,13 @@ class

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21617 **[Test build #92239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92239/testReport)** for PR 21617 at commit

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21617 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21542 @HyukjinKwon Thank you for your kindly look. Both fork and non-fork versions work well in my local environment. I am thinking about available memory size. Now, the different error happens

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21542 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/434/

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21618 **[Test build #92250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92250/testReport)** for PR 21618 at commit

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21542 **[Test build #92248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92248/testReport)** for PR 21542 at commit

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21542 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92248/ Test FAILed. ---

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21542 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread justinmclean
Github user justinmclean commented on a diff in the pull request: https://github.com/apache/spark/pull/21610#discussion_r197608161 --- Diff: NOTICE --- @@ -1,667 +1,11 @@ Apache Spark -Copyright 2014 and onwards The Apache Software Foundation. +Copyright 2014 - 20018

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/432/

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21618 **[Test build #92245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92245/testReport)** for PR 21618 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92246/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 > I will first fix the tests, and then assert the performance if you agree. Changing the annotations might impact the performance. Ah, yea sure. ---

[GitHub] spark pull request #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread Fokko
Github user Fokko commented on a diff in the pull request: https://github.com/apache/spark/pull/21596#discussion_r197604577 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -244,6 +244,13 @@ class

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92247: Deflake Build #92089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92247/testReport)** for PR 21109 at commit

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92245/ Test FAILed. ---

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21618 **[Test build #92245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92245/testReport)** for PR 21618 at commit

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21617 **[Test build #92241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92241/testReport)** for PR 21617 at commit

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21542 **[Test build #92248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92248/testReport)** for PR 21542 at commit

[GitHub] spark issue #21542: [SPARK-24529][Build][test-maven] Add spotbugs into maven...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21542 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21619 **[Test build #92251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92251/testReport)** for PR 21619 at commit

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/435/

[GitHub] spark pull request #16677: [SPARK-19355][SQL] Use map output statistics to i...

2018-06-23 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16677#discussion_r197607227 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala --- @@ -93,25 +96,94 @@ trait BaseLimitExec extends UnaryExecNode with

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 re: https://github.com/apache/spark/pull/21596#issuecomment-399639768 can we keep the previous behaviour although it's by kind of a bug in Jackson? BTW, I thought we should use

[GitHub] spark pull request #21619: [SPARK-24635][SQL] Remove Blocks class from JavaC...

2018-06-23 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/21619 [SPARK-24635][SQL] Remove Blocks class from JavaCode class hierarchy ## What changes were proposed in this pull request? The `Blocks` class in `JavaCode` class hierarchy is not necessary.

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21619 cc @cloud-fan @kiszk @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21618 **[Test build #92250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92250/testReport)** for PR 21618 at commit

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-06-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20701 thanks for your review @holdenk. I don't know how to retrigger AppVeyor too, unfortunately :( --- - To unsubscribe, e-mail:

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20701 **[Test build #92257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92257/testReport)** for PR 20701 at commit

[GitHub] spark pull request #21619: [SPARK-24635][SQL] Remove Blocks class from JavaC...

2018-06-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21619#discussion_r197611597 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -148,14 +149,17 @@ trait Block extends

[GitHub] spark pull request #21621: [SPARK-24633][SQL] Fix codegen when split is requ...

2018-06-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21621#discussion_r197611612 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -199,7 +199,7 @@ case class

[GitHub] spark issue #21624: [SPARK-24639][DOC] Add three config in the doc

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21624 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21624: [SPARK-24639][DOC] Add three config in the doc

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21624 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21624: [SPARK-24639][DOC] Add three config in the doc

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21624 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21622: [SPARK-24637][SS] Add metrics regarding state and waterm...

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21622 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21622: [SPARK-24637][SS] Add metrics regarding state and waterm...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21622 **[Test build #92260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92260/testReport)** for PR 21622 at commit

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21623 cc @rdblue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21621: [SPARK-24633][SQL] Fix codegen when split is required fo...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21621 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92255/ Test PASSed. ---

[GitHub] spark issue #21621: [SPARK-24633][SQL] Fix codegen when split is required fo...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21621 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 So now it trims too much, we get: ``` [ { "id" : "local-1422981759269", "name" : "Spark shell", "attempts" : [ { "startTime" : "2015-02-03T16:42:38.277GMT",

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92254/testReport)** for PR 21596 at commit

[GitHub] spark pull request #21621: [SPARK-24633][SQL] Fix codegen when split is requ...

2018-06-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21621#discussion_r197611537 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -199,7 +199,7 @@ case class

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20701 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20701 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/437/

[GitHub] spark issue #21621: [SPARK-24633][SQL] Fix codegen when split is required fo...

2018-06-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21621 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21619: [SPARK-24635][SQL] Remove Blocks class from JavaC...

2018-06-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21619#discussion_r197611766 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -148,14 +149,17 @@ trait Block extends

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21623 **[Test build #92258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92258/testReport)** for PR 21623 at commit

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21623 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21623 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/438/

[GitHub] spark pull request #21624: [SPARK-24639][DOC] Add three config in the doc

2018-06-23 Thread xueyumusic
GitHub user xueyumusic opened a pull request: https://github.com/apache/spark/pull/21624 [SPARK-24639][DOC] Add three config in the doc ## What changes were proposed in this pull request? add three config which are mentioned in the pr #21567 , they are

[GitHub] spark pull request #21619: [SPARK-24635][SQL] Remove Blocks class from JavaC...

2018-06-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21619#discussion_r197612970 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -148,14 +149,17 @@ trait Block extends

[GitHub] spark pull request #21542: [SPARK-24529][Build][test-maven] Add spotbugs int...

2018-06-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/21542#discussion_r197613977 --- Diff: pom.xml --- @@ -2606,6 +2606,35 @@ + +com.github.spotbugs +

[GitHub] spark issue #21622: [SPARK-24637][SS] Add metrics regarding state and waterm...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21622 **[Test build #92261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92261/testReport)** for PR 21622 at commit

[GitHub] spark issue #21622: [SPARK-24637][SS] Add metrics regarding state and waterm...

2018-06-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/21622 retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistics to improve ...

2018-06-23 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/16677 If there is some codepath not updating shuffle write metrics (introduced for sql), that would be a bug. On Sat, Jun 23, 2018 at 7:27 AM Liang-Chi Hsieh wrote: > *@viirya*

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 OK if you want to pare down the PR to fixes we had discussed here and on the thread, I can get it in. I will need to just reevaluate the whole LICENSE and NOTICE anyway as it's clear it's at least a

[GitHub] spark issue #21622: [SPARK-24637][SS] Add metrics regarding state and waterm...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21622 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92260/ Test FAILed. ---

[GitHub] spark issue #21622: [SPARK-24637][SS] Add metrics regarding state and waterm...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21622 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92249/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92249/ Test FAILed. ---

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92251/ Test PASSed. ---

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21619 **[Test build #92251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92251/testReport)** for PR 21619 at commit

[GitHub] spark issue #21619: [SPARK-24635][SQL] Remove Blocks class from JavaCode cla...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   >