[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202534636 --- Diff: docs/running-on-kubernetes.md --- @@ -399,18 +426,18 @@ specific to Spark on Kubernetes. Path to the CA cert file for

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202535016 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,37 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21758: [SPARK-24795][CORE] Implement barrier execution m...

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21758#discussion_r202535313 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1386,29 +1418,90 @@ class DAGScheduler( )

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202534469 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,10 +75,22 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202534384 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModelSuite.scala --- @@ -72,6 +72,22 @@ class

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20629 **[Test build #93016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93016/testReport)** for PR 20629 at commit

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-15 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/21556 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93018/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/965/

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93020/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/969/

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21589 AFAIK, we always have num of executor and then num of core per executor right? https://spark.apache.org/docs/latest/configuration.html#execution-behavior maybe we should have the

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21657 **[Test build #93015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93015/testReport)** for PR 21657 at commit

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21657 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/961/

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21657 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20629 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/962/

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20629 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

2018-07-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202536655 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,35 @@ private[spark] class

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-15 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 hey @gatorsmile, sorry to bother, could you just clarify the above? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

2018-07-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202537869 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,36 @@ private[spark] class

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93025/testReport)** for PR 21711 at commit

[GitHub] spark issue #21769: [SPARK-24805][SQL] Do not ignore avro files without exte...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21769 **[Test build #93023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93023/testReport)** for PR 21769 at commit

[GitHub] spark issue #21769: [SPARK-24805][SQL] Do not ignore avro files without exte...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21769 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93023/ Test PASSed. ---

[GitHub] spark issue #21769: [SPARK-24805][SQL] Do not ignore avro files without exte...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21769 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21758: [SPARK-24795][CORE] Implement barrier execution m...

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21758#discussion_r202533650 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -359,17 +368,49 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request #21758: [SPARK-24795][CORE] Implement barrier execution m...

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21758#discussion_r202533903 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -359,17 +368,49 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request #21758: [SPARK-24795][CORE] Implement barrier execution m...

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21758#discussion_r202533477 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1386,29 +1418,90 @@ class DAGScheduler( )

[GitHub] spark pull request #21771: [SPARK-24807][CORE] Adding files/jars twice: outp...

2018-07-15 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21771#discussion_r202536141 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1555,6 +1559,9 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20629 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20629 **[Test build #93016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93016/testReport)** for PR 20629 at commit

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20629 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93016/ Test PASSed. ---

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93019/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-15 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21766 Just checked out the PR, ```scala scala> spark.sql("SELECT CAST(1 as NUMERIC)") res0: org.apache.spark.sql.DataFrame = [CAST(1 AS DECIMAL(10,0)): decimal(10,0)] scala>

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

2018-07-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21754 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/963/

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21556 **[Test build #93017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93017/testReport)** for PR 21556 at commit

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

2018-07-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202536673 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -2005,6 +2005,24 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/966/

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93021/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/967/

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93022/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93024/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/968/

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21769: [SPARK-24805][SQL] Do not ignore avro files without exte...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21769 **[Test build #93023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93023/testReport)** for PR 21769 at commit

[GitHub] spark issue #21770: [SPARK-24806][SQL] Brush up generated code so that JDK c...

2018-07-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21770 I'll fix the failures soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21770: [SPARK-24806][SQL] Brush up generated code so tha...

2018-07-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21770#discussion_r202534515 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -318,7 +318,8 @@ case class SampleExec(

[GitHub] spark pull request #21770: [SPARK-24806][SQL] Brush up generated code so tha...

2018-07-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21770#discussion_r202534499 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3758,7 +3758,10 @@ case class

[GitHub] spark pull request #21770: [SPARK-24806][SQL] Brush up generated code so tha...

2018-07-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21770#discussion_r202534510 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1585,6 +1585,9 @@ case class

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/964/

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

2018-07-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202536743 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,35 @@ private[spark] class

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21657 **[Test build #93015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93015/testReport)** for PR 21657 at commit

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21657 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93015/ Test PASSed. ---

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21657 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93018/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93018/ Test FAILed. ---

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93020/ Test PASSed. ---

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21762: [SPARK-24800][SQL] Refactor Avro Serializer and Deserial...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21762 **[Test build #93026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93026/testReport)** for PR 21762 at commit

[GitHub] spark issue #21762: [SPARK-24800][SQL] Refactor Avro Serializer and Deserial...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21762 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93026/ Test PASSed. ---

[GitHub] spark issue #21762: [SPARK-24800][SQL] Refactor Avro Serializer and Deserial...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21762 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21762: [SPARK-24800][SQL] Refactor Avro Serializer and Deserial...

2018-07-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21762 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21773: [SPARK-24810][SQL] Fix paths to test files in Avr...

2018-07-15 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/21773 [SPARK-24810][SQL] Fix paths to test files in AvroSuite ## What changes were proposed in this pull request? In the PR, I propose to move `testFile()` to the common trait

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21589 Yarn can use dynamic allocation as well. That's why I said "in general". To address @felixcheung's concern, I guess it's good to mention like see the configuration section and details can be

[GitHub] spark issue #21773: [SPARK-24810][SQL] Fix paths to test files in AvroSuite

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21773 **[Test build #93028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93028/testReport)** for PR 21773 at commit

[GitHub] spark pull request #21773: [SPARK-24810][SQL] Fix paths to test files in Avr...

2018-07-15 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21773#discussion_r202550099 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -37,27 +37,27 @@ import

[GitHub] spark issue #21775: [SPARK-24812][SQL] Last Access Time in the table descrip...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21775 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21775: [SPARK-24812][SQL] Last Access Time in the table descrip...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21775 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21775: [SPARK-24812][SQL] Last Access Time in the table descrip...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21775 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21769: [SPARK-24805][SQL] Do not ignore avro files without exte...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21769 **[Test build #93034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93034/testReport)** for PR 21769 at commit

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-15 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r202539843 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerRuleExclusionSuite.scala --- @@ -0,0 +1,84 @@ +/* + *

[GitHub] spark issue #21772: [SPARK-24809] [SQL] Serializing LongHashedRelation in ex...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21772 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21773: [SPARK-24810][SQL] Fix paths to test files in AvroSuite

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21773 **[Test build #93028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93028/testReport)** for PR 21773 at commit

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202547781 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,11 +75,29 @@ class

[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-07-15 Thread koertkuipers
Github user koertkuipers commented on the issue: https://github.com/apache/spark/pull/18714 should this be exposed per write instead of as a global variable? e.g. dataframe.write.csv.partitionMode(Dynamic).partitionBy(...).save(...) ---

[GitHub] spark issue #21755: Doc fix: The Imputer is an Estimator

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21755 **[Test build #4214 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4214/testReport)** for PR 21755 at commit

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21765 **[Test build #4213 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4213/testReport)** for PR 21765 at commit

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21589 **[Test build #93031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93031/testReport)** for PR 21589 at commit

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-15 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r202538924 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -46,7 +47,23 @@ abstract class

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-15 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r202539342 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +179,35 @@ abstract class

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-15 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r202539784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -127,6 +127,14 @@ object SQLConf { } }

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93020/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93021/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93021/ Test PASSed. ---

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93024/ Test PASSed. ---

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21711 **[Test build #93024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93024/testReport)** for PR 21711 at commit

[GitHub] spark issue #21711: [SPARK-24681][SQL] Verify nested column names in Hive me...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21711 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202542318 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -165,7 +183,7 @@ class

[GitHub] spark pull request #21770: [SPARK-24806][SQL] Brush up generated code so tha...

2018-07-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21770#discussion_r202542918 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -318,7 +318,8 @@ case class SampleExec( v

[GitHub] spark issue #21698: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-07-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21698 Actually I think @mridulm have a point here - if we only retry all the tasks for repartition/zip*, it's still possible that some tasks in a succeeding stage may have finished before retry, and

[GitHub] spark issue #21770: [SPARK-24806][SQL] Brush up generated code so that JDK c...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21770 **[Test build #93029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93029/testReport)** for PR 21770 at commit

[GitHub] spark issue #21770: [SPARK-24806][SQL] Brush up generated code so that JDK c...

2018-07-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21770 **[Test build #93030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93030/testReport)** for PR 21770 at commit

[GitHub] spark issue #21770: [SPARK-24806][SQL] Brush up generated code so that JDK c...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21770 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21770: [SPARK-24806][SQL] Brush up generated code so that JDK c...

2018-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93029/ Test FAILed. ---

  1   2   3   4   5   >