[GitHub] spark pull request #22249: [SPARK-16281][SQL][FOLLOW-UP] Add parse_url to fu...

2018-08-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22249#discussion_r213227841 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2459,6 +2459,26 @@ object functions { StringTrimLeft(e.expr,

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 @holdenk @srowen anyway I realized that computing the lift for previously saved models is not feasible as we don't know the number of training records, so we cannot compute the items support.

[GitHub] spark pull request #22249: [SPARK-16281][SQL][FOLLOW-UP] Add parse_url to fu...

2018-08-28 Thread TomaszGaweda
Github user TomaszGaweda commented on a diff in the pull request: https://github.com/apache/spark/pull/22249#discussion_r213232338 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2459,6 +2459,26 @@ object functions { StringTrimLeft(e.expr,

[GitHub] spark issue #22226: [SPARK-25252][SQL] Support arrays of any types by to_jso...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/6 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22226: [SPARK-25252][SQL] Support arrays of any types by to_jso...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/6 **[Test build #95331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95331/testReport)** for PR 6 at commit

[GitHub] spark issue #22233: [SPARK-25240][SQL] Fix for a deadlock in RECOVER PARTITI...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22233 **[Test build #95343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95343/testReport)** for PR 22233 at commit

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22205 **[Test build #95344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95344/testReport)** for PR 22205 at commit

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-08-28 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r213273861 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -950,6 +950,15 @@ object SQLConf { .booleanConf

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22246 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22173: [SPARK-24335] Spark external shuffle server improvement ...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22173 **[Test build #95352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95352/testReport)** for PR 22173 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95341/testReport)** for PR 22236 at commit

[GitHub] spark issue #22226: [SPARK-25252][SQL] Support arrays of any types by to_jso...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/6 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95331/ Test FAILed. ---

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-08-28 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r213274849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -950,6 +950,15 @@ object SQLConf { .booleanConf

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22246 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22246 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22254: [CATALYST] Add a call to apply method explicitly in comb...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22254 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22254: [CATALYST] Add a call to apply method explicitly in comb...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22254 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #95339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95339/testReport)** for PR 20965 at commit

[GitHub] spark issue #22255: [SPARK-25102][Spark Core] Write Spark version informatio...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22255 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 thanks for pointing that out @hhbyyh . I wasn't aware of it. I think lift and confidence are more useful metrics than the support (the votes on the JIRAs seem also to agree with me on this).

[GitHub] spark issue #22252: [SPARK-25261][MINOR][DOC] correct the default unit for s...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22252 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-28 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22048 @xuejianbest thank you for your update. Would it be possible to commit test cases, too? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22112: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22112 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95332/ Test FAILed. ---

[GitHub] spark issue #22112: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22112 **[Test build #95332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95332/testReport)** for PR 22112 at commit

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22246 **[Test build #95333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95333/testReport)** for PR 22246 at commit

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22246 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95333/ Test FAILed. ---

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22243 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22226: [SPARK-25252][SQL] Support arrays of any types by to_jso...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/6 **[Test build #95347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95347/testReport)** for PR 6 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20965 ok, I stop this work. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22243 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22255: [SPARK-25102][Spark Core] Write Spark version informatio...

2018-08-28 Thread npoberezkin
Github user npoberezkin commented on the issue: https://github.com/apache/spark/pull/22255 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22252: [SPARK-25261][MINOR][DOC] correct the default unit for s...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22252 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22252: [SPARK-25261][MINOR][DOC] correct the default unit for s...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22252 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22243 **[Test build #95342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95342/testReport)** for PR 22243 at commit

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22205 **[Test build #95344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95344/testReport)** for PR 22205 at commit

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22205 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22205 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95344/ Test FAILed. ---

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95336/ Test PASSed. ---

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20965 since according to previous discussion we are going to revisit our code generation framework I am nor sure about this PR... ---

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #95339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95339/testReport)** for PR 20965 at commit

[GitHub] spark pull request #22252: [SPARK-25261][MINOR][DOC] correct the default uni...

2018-08-28 Thread ivoson
GitHub user ivoson opened a pull request: https://github.com/apache/spark/pull/22252 [SPARK-25261][MINOR][DOC] correct the default unit for spark.executor|driver.memory as described in configuration.md ## What changes were proposed in this pull request? As described in

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22233: [SPARK-25240][SQL] Fix for a deadlock in RECOVER ...

2018-08-28 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22233#discussion_r213252905 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand(

[GitHub] spark issue #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory operat...

2018-08-28 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21968 @cloud-fan `VectorizedHashMapGenerator`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22205 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22205 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22243 **[Test build #95342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95342/testReport)** for PR 22243 at commit

[GitHub] spark issue #22112: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22112 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95342/ Test FAILed. ---

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #95346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95346/testReport)** for PR 22146 at commit

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22243 **[Test build #95345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95345/testReport)** for PR 22243 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95334/ Test PASSed. ---

[GitHub] spark pull request #22253: [SPARK-24411][SQL] Adding native Java tests for '...

2018-08-28 Thread aai95
GitHub user aai95 opened a pull request: https://github.com/apache/spark/pull/22253 [SPARK-24411][SQL] Adding native Java tests for 'isInCollection' ## What changes were proposed in this pull request? Conversion of Scala Seq to Java collections were replaced by native Java

[GitHub] spark issue #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 ...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22246 **[Test build #95348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95348/testReport)** for PR 22246 at commit

[GitHub] spark issue #22254: [CATALYST] Add a call to apply method explicitly in comb...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22254 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #95337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95337/testReport)** for PR 20965 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95339/ Test PASSed. ---

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22243 **[Test build #95350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95350/testReport)** for PR 22243 at commit

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22205 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22205: [SPARK-25212][SQL] Support Filter in ConvertToLocalRelat...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22205 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22104: [SPARK-24721][SQL] Exclude Python UDFs filters in FileSo...

2018-08-28 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/22104 Thanks all for the review! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21546 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-28 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 I looked at all the 0x-0x characters (unicode) and showed them under Xshell, then found all the full width characters. Get the latest regular expression. A new version has been

[GitHub] spark issue #22215: [SPARK-25222][K8S] Improve container status logging

2018-08-28 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22215 @liyinan926 @nrchakradhar Addressed all your comments, thanks for the reviews. Is someone able to kick off the Jenkins testing on this PR? ---

[GitHub] spark pull request #22238: [SPARK-25245][DOCS][SS] Explain regarding limitin...

2018-08-28 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/22238#discussion_r213264912 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -868,7 +870,9 @@ object SQLConf { .internal()

[GitHub] spark pull request #22238: [SPARK-25245][DOCS][SS] Explain regarding limitin...

2018-08-28 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/22238#discussion_r213264786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -266,7 +266,9 @@ object SQLConf {

[GitHub] spark pull request #22238: [SPARK-25245][DOCS][SS] Explain regarding limitin...

2018-08-28 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/22238#discussion_r213267299 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -266,7 +266,9 @@ object SQLConf {

[GitHub] spark pull request #22238: [SPARK-25245][DOCS][SS] Explain regarding limitin...

2018-08-28 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/22238#discussion_r213267329 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -868,7 +870,9 @@ object SQLConf { .internal()

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/2614/ ---

[GitHub] spark pull request #22254: [CATALYST] Add a call to apply method explicitly ...

2018-08-28 Thread SongYadong
GitHub user SongYadong opened a pull request: https://github.com/apache/spark/pull/22254 [CATALYST] Add a call to apply method explicitly in combineFilterFunction ## What changes were proposed in this pull request? This PR do: add an apply method explicitly for

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22243 **[Test build #95345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95345/testReport)** for PR 22243 at commit

[GitHub] spark issue #22243: [MINOR] Avoid code duplication for nullable in Higher Or...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22243 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95345/ Test FAILed. ---

[GitHub] spark issue #22255: [SPARK-25102][Spark Core] Write Spark version informatio...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22255 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213231887 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala --- @@ -143,29 +143,25 @@ object SchemaConverters {

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #95336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95336/testReport)** for PR 20965 at commit

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21546 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95340/ Test FAILed. ---

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21546 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21546 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21546 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21546 **[Test build #95340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95340/testReport)** for PR 21546 at commit

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213233392 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213232867 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with

[GitHub] spark issue #22253: [SPARK-24411][SQL] Adding native Java tests for 'isInCol...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22253 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22253: [SPARK-24411][SQL] Adding native Java tests for 'isInCol...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22253 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #95349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95349/testReport)** for PR 20965 at commit

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21546 **[Test build #95340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95340/testReport)** for PR 21546 at commit

[GitHub] spark issue #22250: [SPARK-25259][SQL] left/right join support push down dur...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22250 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95335/ Test PASSed. ---

  1   2   3   4   5   6   7   >