[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22407 @dilipbiswal Thanks! I'll take a look at it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22402 **[Test build #96019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96019/testReport)** for PR 22402 at commit

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96019/ Test FAILed. ---

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22409 **[Test build #96025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96025/testReport)** for PR 22409 at commit

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217279564 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22394 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96018/ Test FAILed. ---

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22410 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22394 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22410 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96023/ Test FAILed. ---

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96024/ Test FAILed. ---

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22410 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22410 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-09-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22029 kindly ping @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22407: [SPARK-25416][SQL] ArrayPosition function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22407#discussion_r217267902 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2062,18 +2062,23 @@ case class

[GitHub] spark pull request #22407: [SPARK-25416][SQL] ArrayPosition function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22407#discussion_r217267848 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -1045,6 +1045,31 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22407 **[Test build #96024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96024/testReport)** for PR 22407 at commit

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217272407 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217272398 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217269231 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1331,26 +1331,31 @@ case class

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96021/ Test FAILed. ---

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22394 **[Test build #96018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96018/testReport)** for PR 22394 at commit

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22407 **[Test build #96024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96024/testReport)** for PR 22407 at commit

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7 **[Test build #96021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96021/testReport)** for PR 7 at commit

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22410 **[Test build #96023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96023/testReport)** for PR 22410 at commit

[GitHub] spark pull request #22374: [SPARK-25387][SQL] Fix for NPE caused by bad CSV ...

2018-09-13 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22374#discussion_r217279960 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -240,23 +240,25 @@ object

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22407 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22410 **[Test build #96026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96026/testReport)** for PR 22410 at commit

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22407 **[Test build #96027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96027/testReport)** for PR 22407 at commit

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22394 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22410 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22409 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22375: [WIP][SPARK-25388][Test][SQL] Detect incorrect nullable ...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/7 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22394 **[Test build #96029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96029/testReport)** for PR 22394 at commit

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22407 **[Test build #96028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96028/testReport)** for PR 22407 at commit

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22394 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7 **[Test build #96030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96030/testReport)** for PR 7 at commit

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22394 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22408 **[Test build #96031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96031/testReport)** for PR 22408 at commit

[GitHub] spark pull request #22402: [SPARK-25414][SS] The numInputRows metrics can be...

2018-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22402#discussion_r217286827 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala --- @@ -598,18 +599,20 @@ abstract class

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22402 **[Test build #96032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96032/testReport)** for PR 22402 at commit

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22407 > Seems like ArrayContains, ArrayRemove, and ElementAt for map types could have the same problem? @ueshin I have a PR opened for ArrayContains

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/22409 LGTM. Wait for the test. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22408 **[Test build #96017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96017/testReport)** for PR 22408 at commit

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22409 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22408 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22408 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22375: [WIP][SPARK-25388][Test][SQL] Detect incorrect nullable ...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96034/testReport)** for PR 22375 at commit

[GitHub] spark issue #22375: [WIP][SPARK-25388][Test][SQL] Detect incorrect nullable ...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22408 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22408 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96017/ Test PASSed. ---

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217277655 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217287140 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22403: [SPARK-25402][SQL][BACKPORT-2.2] Null handling in Boolea...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22403 **[Test build #96033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96033/testReport)** for PR 22403 at commit

[GitHub] spark issue #22403: [SPARK-25402][SQL][BACKPORT-2.2] Null handling in Boolea...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22403 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22403: [SPARK-25402][SQL][BACKPORT-2.2] Null handling in Boolea...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22403 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22409 **[Test build #96025 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96025/testReport)** for PR 22409 at commit

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96025/ Test FAILed. ---

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217274487 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1331,26 +1331,31 @@ case class

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217274391 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217274643 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96022/ Test FAILed. ---

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22409 **[Test build #96022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96022/testReport)** for PR 22409 at commit

[GitHub] spark issue #22401: [SPARK-25413] Precision value is going for toss when Avg...

2018-09-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22401 Just to be clear: > current code which does p+10 breaks usecase mentioned by SPARK-25413 I think setting `spark.sql.decimalOperations.allowPrecisionLoss` to `false` can solve the

[GitHub] spark pull request #22395: [SPARK-16323][SQL] Add IntegralDivide expression

2018-09-13 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22395#discussion_r217285630 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -314,6 +314,27 @@ case class Divide(left:

[GitHub] spark pull request #22395: [SPARK-16323][SQL] Add IntegralDivide expression

2018-09-13 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22395#discussion_r217289728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -314,6 +314,27 @@ case class Divide(left:

[GitHub] spark issue #22364: [SPARK-25379][SQL] Improve AttributeSet and ColumnPrunin...

2018-09-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22364 anymore comments @maropu @gatorsmile ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22407 **[Test build #96028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96028/testReport)** for PR 22407 at commit

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22029 **[Test build #96035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96035/testReport)** for PR 22029 at commit

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22408 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22408 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22408 **[Test build #96036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96036/testReport)** for PR 22408 at commit

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22409 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22379 @MaxGekk, BTW, when the json functionailities were added at the first place, it was suggested to ask it to dev mailing list and see if people really want it or not. Mind if I ask this when

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22379 **[Test build #96038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96038/testReport)** for PR 22379 at commit

[GitHub] spark issue #22394: [SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, ...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22394 **[Test build #96029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96029/testReport)** for PR 22394 at commit

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-13 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22379 > Out of curiosity, is this one related with an actual usecase Maxim? or is this proposed for API consistency? This is actual use case when users received CSV content dumped from another

[GitHub] spark issue #22403: [SPARK-25402][SQL][BACKPORT-2.2] Null handling in Boolea...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22403 **[Test build #96033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96033/testReport)** for PR 22403 at commit

[GitHub] spark issue #22403: [SPARK-25402][SQL][BACKPORT-2.2] Null handling in Boolea...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22403 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22408 **[Test build #96036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96036/testReport)** for PR 22408 at commit

[GitHub] spark issue #22411: [SPARK-25421][SQL] Abstract an output path field in trai...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22411 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22411: [SPARK-25421][SQL] Abstract an output path field ...

2018-09-13 Thread LantaoJin
GitHub user LantaoJin opened a pull request: https://github.com/apache/spark/pull/22411 [SPARK-25421][SQL] Abstract an output path field in trait DataWritingCommand ## What changes were proposed in this pull request? #22353 import a metadata field in ```SparkPlanInfo``` and

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22407 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96028/ Test FAILed. ---

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22409: [SPARK-25352][SQL][Followup] Add helper method and addre...

2018-09-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22409 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

  1   2   3   4   5   >