[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571841510 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala ## @@ -46,6 +47,23 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571842005 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] HeartSaVioR commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
HeartSaVioR commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774977557 1. Let's address SparkHadoopWriter as well. 2. If these three occurrences are calling exactly the same method, probably extract it to the one of method of

[GitHub] [spark] SparkQA commented on pull request #31484: [SPARK-34374][SQL][DSTREAM] Use standard methods to extract keys or values from a Map

2021-02-08 Thread GitBox
SparkQA commented on pull request #31484: URL: https://github.com/apache/spark/pull/31484#issuecomment-774985138 **[Test build #135003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135003/testReport)** for PR 31484 at commit

[GitHub] [spark] SparkQA commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774997465 **[Test build #135011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135011/testReport)** for PR 31517 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31484: [SPARK-34374][SQL][DSTREAM] Use standard methods to extract keys or values from a Map

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31484: URL: https://github.com/apache/spark/pull/31484#issuecomment-774997259 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135003/

[GitHub] [spark] AmplabJenkins commented on pull request #31519: [SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31519: URL: https://github.com/apache/spark/pull/31519#issuecomment-774997257 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39593/

[GitHub] [spark] AmplabJenkins commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774997258 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39597/

[GitHub] [spark] AmplabJenkins commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774997260 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135006/

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
HyukjinKwon commented on a change in pull request #31466: URL: https://github.com/apache/spark/pull/31466#discussion_r571911907 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -155,9 +155,13 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
HyukjinKwon commented on a change in pull request #31466: URL: https://github.com/apache/spark/pull/31466#discussion_r571911907 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -155,9 +155,13 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] SparkQA commented on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA commented on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775042017 **[Test build #135024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135024/testReport)** for PR 31466 at commit

[GitHub] [spark] SparkQA commented on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA commented on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775046285 **[Test build #135023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135023/testReport)** for PR 31466 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775042017 **[Test build #135024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135024/testReport)** for PR 31466 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775046285 **[Test build #135023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135023/testReport)** for PR 31466 at commit

[GitHub] [spark] steveloughran commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
steveloughran commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571948537 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] SparkQA commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
SparkQA commented on pull request #31521: URL: https://github.com/apache/spark/pull/31521#issuecomment-775069973 **[Test build #135017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135017/testReport)** for PR 31521 at commit

[GitHub] [spark] cloud-fan commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-775084376 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571982639 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -481,8 +481,14 @@ class

[GitHub] [spark] AngersZhuuuu commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AngersZh commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774955534 gentle ping @HeartSaVioR This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774960953 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39594/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-774960236 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39588/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31471: [SPARK-34355][SQL] Add log and time cost for commit job

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31471: URL: https://github.com/apache/spark/pull/31471#issuecomment-774960234 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134999/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-774960233 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39590/

[GitHub] [spark] SparkQA commented on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-774962959 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39595/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31491: [SPARK-34379][SQL] Map JDBC RowID to StringType rather than LongType

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31491: URL: https://github.com/apache/spark/pull/31491#issuecomment-774960235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134997/

[GitHub] [spark] AmplabJenkins commented on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-774966146 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39595/

[GitHub] [spark] SparkQA commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774966551 **[Test build #135009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135009/testReport)** for PR 31517 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-774966146 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39595/

[GitHub] [spark] AngersZhuuuu commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AngersZh commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774998922 > 1. Let's address SparkHadoopWriter as well. > 2. If these three occurrences are calling exactly the same method, probably extract it to the one of method of

[GitHub] [spark] ulysses-you commented on pull request #31471: [SPARK-34355][SQL] Add log and time cost for commit job

2021-02-08 Thread GitBox
ulysses-you commented on pull request #31471: URL: https://github.com/apache/spark/pull/31471#issuecomment-775020058 thanks all ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AngersZh commented on a change in pull request #31520: URL: https://github.com/apache/spark/pull/31520#discussion_r571918707 ## File path: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriterUtils.scala ## @@ -106,6 +110,18 @@ object SparkHadoopWriterUtils {

[GitHub] [spark] AmplabJenkins commented on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-775034692 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39601/

[GitHub] [spark] SparkQA commented on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
SparkQA commented on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-775034662 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39601/

[GitHub] [spark] AmplabJenkins commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-775034586 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39598/

[GitHub] [spark] AmplabJenkins commented on pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31485: URL: https://github.com/apache/spark/pull/31485#issuecomment-775034585 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135004/

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775034381 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39603/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31485: URL: https://github.com/apache/spark/pull/31485#issuecomment-775034585 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135004/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-775034692 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39601/

[GitHub] [spark] SparkQA commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-02-08 Thread GitBox
SparkQA commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-775045063 **[Test build #135022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135022/testReport)** for PR 31470 at commit

[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function

2021-02-08 Thread GitBox
SparkQA commented on pull request #31504: URL: https://github.com/apache/spark/pull/31504#issuecomment-775049517 **[Test build #135008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135008/testReport)** for PR 31504 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-774906642 **[Test build #135005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135005/testReport)** for PR 31518 at commit

[GitHub] [spark] viirya commented on a change in pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
viirya commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r571846243 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -3799,6 +3801,27 @@ class SQLConf extends Serializable with

[GitHub] [spark] AmplabJenkins commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774964850 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135014/

[GitHub] [spark] SparkQA commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
SparkQA commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774964805 **[Test build #135014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135014/testReport)** for PR 30363 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774964850 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135014/

[GitHub] [spark] beliefer commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
beliefer commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-774976629 @cloud-fan Thanks for your work! @HyukjinKwon @MaxGekk Thanks for your review! This is an automated message

[GitHub] [spark] AngersZhuuuu opened a new pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-02-08 Thread GitBox
AngersZh opened a new pull request #31522: URL: https://github.com/apache/spark/pull/31522 ### What changes were proposed in this pull request? Since we have add log about commit time, I think this useful and we can make user know it directly in SQL tab's UI.

[GitHub] [spark] SparkQA commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
SparkQA commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-775030795 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39602/

[GitHub] [spark] SparkQA commented on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA commented on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775047390 **[Test build #135024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135024/testReport)** for PR 31466 at commit

[GitHub] [spark] SparkQA commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-02-08 Thread GitBox
SparkQA commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-775063552 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39605/

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775068766 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39604/

[GitHub] [spark] SparkQA commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
SparkQA commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-775071517 **[Test build #135005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135005/testReport)** for PR 31518 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-775071591 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135007/

[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31504: URL: https://github.com/apache/spark/pull/31504#issuecomment-775071594 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135008/

[GitHub] [spark] AmplabJenkins commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775071544 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-775071597 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39602/

[GitHub] [spark] AmplabJenkins commented on pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-775071600 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39599/

[GitHub] [spark] AmplabJenkins commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31521: URL: https://github.com/apache/spark/pull/31521#issuecomment-775071605 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775071514 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39604/

[GitHub] [spark] AmplabJenkins commented on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775071593 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-02-08 Thread GitBox
SparkQA commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-775080149 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39605/

[GitHub] [spark] AngersZhuuuu opened a new pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AngersZh opened a new pull request #31520: URL: https://github.com/apache/spark/pull/31520 ### What changes were proposed in this pull request? When doing https://issues.apache.org/jira/browse/SPARK-34399 based on https://github.com/apache/spark/pull/31471 Found FileBatchWrite

[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
viirya commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571843989 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] AmplabJenkins commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-774960236 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39588/

[GitHub] [spark] AmplabJenkins commented on pull request #31471: [SPARK-34355][SQL] Add log and time cost for commit job

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31471: URL: https://github.com/apache/spark/pull/31471#issuecomment-774960234 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134999/

[GitHub] [spark] AmplabJenkins commented on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-774960233 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39590/

[GitHub] [spark] AmplabJenkins commented on pull request #31491: [SPARK-34379][SQL] Map JDBC RowID to StringType rather than LongType

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31491: URL: https://github.com/apache/spark/pull/31491#issuecomment-774960235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134997/

[GitHub] [spark] SparkQA removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774961216 **[Test build #135014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135014/testReport)** for PR 30363 at commit

[GitHub] [spark] hammertank commented on pull request #30894: [SPARK-33152][SQL] Improve the performance of constraint propagation for Project and Aggregate

2021-02-08 Thread GitBox
hammertank commented on pull request #30894: URL: https://github.com/apache/spark/pull/30894#issuecomment-774965798 Checked the 2 git action errors: 1. CliSuite.SPARK-29022: Commands using SerDe provided in --hive.aux.jars.path It is a timeout error and cannot be reproduced in my

[GitHub] [spark] SparkQA commented on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-774966109 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39595/

[GitHub] [spark] beliefer commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
beliefer commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571861728 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
HyukjinKwon commented on a change in pull request #31466: URL: https://github.com/apache/spark/pull/31466#discussion_r571868026 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -566,7 +563,14 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] Ngone51 commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
Ngone51 commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571870722 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala ## @@ -46,6 +47,23 @@ import

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571870795 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571870795 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] beliefer commented on a change in pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
beliefer commented on a change in pull request #31466: URL: https://github.com/apache/spark/pull/31466#discussion_r571876655 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -566,7 +563,14 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] AmplabJenkins commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774998444 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135011/

[GitHub] [spark] SparkQA commented on pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-02-08 Thread GitBox
SparkQA commented on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-775008712 **[Test build #135016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135016/testReport)** for PR 31522 at commit

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-775013310 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39598/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-775034586 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39598/

[GitHub] [spark] AmplabJenkins commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-775072743 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135005/

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571983429 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -6,6 +6,13 @@ SHOW TBLPROPERTIES tbl; SHOW TBLPROPERTIES

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571983429 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -6,6 +6,13 @@ SHOW TBLPROPERTIES tbl; SHOW TBLPROPERTIES

[GitHub] [spark] cloud-fan commented on a change in pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31348: URL: https://github.com/apache/spark/pull/31348#discussion_r571844600 ## File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ## @@ -750,6 +750,36 @@ private[deploy] class Worker( } } +

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571850667 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571850667 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774967588 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135009/

[GitHub] [spark] SparkQA commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774968263 **[Test build #135006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135006/testReport)** for PR 31517 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774906502 **[Test build #135006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135006/testReport)** for PR 31517 at commit

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-774968499 **[Test build #135015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135015/testReport)** for PR 31245 at commit

[GitHub] [spark] cloud-fan closed pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
cloud-fan closed pull request #31245: URL: https://github.com/apache/spark/pull/31245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-774975197 The last commit just updates a comment, merging to master, thanks! This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on pull request #31484: [SPARK-34374][SQL][DSTREAM] Use standard methods to extract keys or values from a Map

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31484: URL: https://github.com/apache/spark/pull/31484#issuecomment-774858316 **[Test build #135003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135003/testReport)** for PR 31484 at commit

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774999865 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39596/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774997260 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31484: [SPARK-34374][SQL][DSTREAM] Use standard methods to extract keys or values from a Map

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31484: URL: https://github.com/apache/spark/pull/31484#issuecomment-774997259 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135003/

[GitHub] [spark] SparkQA removed a comment on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774931027 **[Test build #135011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135011/testReport)** for PR 31517 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774997258 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39597/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31519: [SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31519: URL: https://github.com/apache/spark/pull/31519#issuecomment-774997257 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39593/

  1   2   3   4   5   6   7   8   >