[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54112614 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19578/consoleFull) for PR 2134 at commit

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54113146 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19579/consoleFull) for PR 2134 at commit

[GitHub] spark pull request: [SPARK-2179] [SQL] Public API for DataTypes an...

2014-09-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1774#issuecomment-54113233 @yhuai can you close this now? I think it was fixed in another PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2179] [SQL] Public API for DataTypes an...

2014-09-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/1774#issuecomment-54113827 @pwendell seems it is not a part of our sql programming guide. I can update it next week (I am out of town this week). --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-2636: Expose job ID in JobWaiter API

2014-09-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2176#issuecomment-54113840 Thanks. I'm merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2973][SQL] Lightweight SQL commands wit...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2215#issuecomment-54113907 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19580/consoleFull) for PR 2215 at commit

[GitHub] spark pull request: SPARK-2636: Expose job ID in JobWaiter API

2014-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2179] [SQL] Public API for DataTypes an...

2014-09-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1774#issuecomment-54114283 I plan to use this branch as the starting point for the documentation I'll be writing this week. On Sep 1, 2014 11:28 PM, Yin Huai notificati...@github.com wrote:

[GitHub] spark pull request: SPARK-3052. Misleading and spurious FileSystem...

2014-09-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/1956#issuecomment-54114366 Here's the exception: java.io.IOException: Filesystem closed at org.apache.hadoop.hdfs.DFSClient.checkOpen(DFSClient.java:703) at

[GitHub] spark pull request: SPARK-3052. Misleading and spurious FileSystem...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1956#issuecomment-54114804 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19581/consoleFull) for PR 1956 at commit

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54115828 @ScrapCodes Thanks for your comment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-2461. Add a toString method to Generaliz...

2014-09-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/1388#issuecomment-54115928 Updated the patch to match existing conventions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54115957 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19578/consoleFull) for PR 2134 at commit

[GitHub] spark pull request: SPARK-2461. Add a toString method to Generaliz...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1388#issuecomment-54116020 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19583/consoleFull) for PR 1388 at commit

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54116132 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19579/consoleFull) for PR 2134 at commit

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54116534 @mridulm , @tdas , @andrewor14 , @ScrapCodes Can one of you help review the code? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54117989 Can you explain how this differs from SPARK-1888/#791? Is this just a duplicate? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-3052. Misleading and spurious FileSystem...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1956#issuecomment-54118325 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19581/consoleFull) for PR 1956 at commit

[GitHub] spark pull request: [SPARK-2096][SQL] Correctly parse dot notation...

2014-09-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2230#issuecomment-54118647 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54118785 @pwendell I think they are duplicated in JIRA (I didn't discovered there is a similar JIRA before I opened a new one). But the two PR are based on different code

[GitHub] spark pull request: [SPARK-2096][SQL] Correctly parse dot notation...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2230#issuecomment-54118896 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19584/consoleFull) for PR 2230 at commit

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54118968 But this one is 5X more code, so I'm just wondering if there is a difference in the feature set... --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-2096][SQL] Correctly parse dot notation...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2230#issuecomment-54118942 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19584/consoleFull) for PR 2230 at commit

[GitHub] spark pull request: [SPARK-3061] Fix Maven build under Windows

2014-09-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2165#issuecomment-54119183 Hey @andrewor14 you can merge this into master and just leave the JIRA as unresolved and add targetVersion 1.1.1 and fixVersion 1.2.0 and make it a blocker. That way it

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54119365 /cc @andrewor14 - I'm guessing we just want to set this variable in maven for the tests rather than changing the order of initialization in the code. --- If your

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54119463 @pwendell This patch also fix some existing bugs introduced from [SPARK-1777]. Since [SPARK-1777] need to resolve the OOM problem, the logic of the original

[GitHub] spark pull request: SPARK-2461. Add a toString method to Generaliz...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1388#issuecomment-54120288 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19583/consoleFull) for PR 1388 at commit

[GitHub] spark pull request: [SPARK-2987] - Adjust build system and tests t...

2014-09-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1905#discussion_r16974721 --- Diff: dev/change-version-to-2.11.sh --- @@ -0,0 +1,20 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-2973][SQL] Lightweight SQL commands wit...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2215#issuecomment-54121454 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19580/consoleFull) for PR 2215 at commit

[GitHub] spark pull request: [SPARK-2987] - Adjust build system and tests t...

2014-09-02 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/1905#discussion_r16975033 --- Diff: dev/change-version-to-2.11.sh --- @@ -0,0 +1,20 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-3000][CORE] drop old blocks to disk in ...

2014-09-02 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/2134#issuecomment-54121834 @pwendell And also, SPARK-1888/[#791](https://github.com/apache/spark/pull/791) has a problem to maintain the freeMemory, the freeMemory is not changed for next

[GitHub] spark pull request: [SPARK-2096][SQL] Correctly parse dot notation...

2014-09-02 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/2230#issuecomment-54122147 sorry for the code style, fixed! Test again please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2096][SQL] Correctly parse dot notation...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2230#issuecomment-54122521 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19585/consoleFull) for PR 2230 at commit

[GitHub] spark pull request: [SPARK-3344]Reformat code: add blank lines

2014-09-02 Thread WangTaoTheTonic
GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/spark/pull/2234 [SPARK-3344]Reformat code: add blank lines Add blank lines between test cases. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-3344]Reformat code: add blank lines

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2234#issuecomment-54123388 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19586/consoleFull) for PR 2234 at commit

[GitHub] spark pull request: [SPARK-3344]Reformat code: add blank lines

2014-09-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2234#issuecomment-54123960 Meta-question -- is this too trivial to bother with a PR and JIRA and review cycle? it's adding two blank lines in a test. --- If your project is set up for it, you can

[GitHub] spark pull request: Added support for accessing secured HDFS

2014-09-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/265#issuecomment-54124179 (I imagine part of the reason is that it doesn't merge into master, and failed tests) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54124416 Set this variable in maven also fix this issue, both is ok. Here i moved ```executorSparkHome``` is because ```executorSparkHome``` only used in ```createCommand ``` ---

[GitHub] spark pull request: [WIP][SPARK-3098]In some cases, the result of ...

2014-09-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2083#issuecomment-54124826 @nchammas to be clear, the question isn't about ordering really. The issue is that result of the same RDD in this example changes when it is reevaluated. It's more like

[GitHub] spark pull request: [SPARK-3344]Reformat code: add blank lines

2014-09-02 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2234#issuecomment-54125511 @WangTaoTheTonic Yeah, Mind closing this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-3337 Paranoid quoting in shell to allow ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2229#issuecomment-54126494 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19587/consoleFull) for PR 2229 at commit

[GitHub] spark pull request: SPARK-3337 Paranoid quoting in shell to allow ...

2014-09-02 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2229#issuecomment-54126820 Tested it by have spark directory as Apache Spark. all scripts seemed to work. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-3337 Paranoid quoting in shell to allow ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2229#issuecomment-54126961 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19588/consoleFull) for PR 2229 at commit

[GitHub] spark pull request: [SPARK-3344]Reformat code: add blank lines

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2234#issuecomment-54129154 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19586/consoleFull) for PR 2234 at commit

[GitHub] spark pull request: [SPARK-2096][SQL] Correctly parse dot notation...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2230#issuecomment-54131873 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19585/consoleFull) for PR 2230 at commit

[GitHub] spark pull request: [SPARK-3345] Do correct parameters for Shuffle...

2014-09-02 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/2235 [SPARK-3345] Do correct parameters for ShuffleFileGroup In the method `newFileGroup` of class `FileShuffleBlockManager`, the parameters for creating new `ShuffleFileGroup` object is in wrong order.

[GitHub] spark pull request: [SPARK-3345] Do correct parameters for Shuffle...

2014-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2235#issuecomment-54134053 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-3337 Paranoid quoting in shell to allow ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2229#issuecomment-54137068 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19588/consoleFull) for PR 2229 at commit

[GitHub] spark pull request: SPARK-3069 [DOCS] Build instructions in README...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2014#issuecomment-54141725 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19589/consoleFull) for PR 2014 at commit

[GitHub] spark pull request: [SPARK-3344]Reformat code: add blank lines

2014-09-02 Thread WangTaoTheTonic
Github user WangTaoTheTonic closed the pull request at: https://github.com/apache/spark/pull/2234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: SPARK-3069 [DOCS] Build instructions in README...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2014#issuecomment-54147529 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19589/consoleFull) for PR 2014 at commit

[GitHub] spark pull request: SPARK-3069 [DOCS] Build instructions in README...

2014-09-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2014#issuecomment-54147642 (Test failure looks spurious -- it's in the Python code and no code was touched in this PR.) --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3304] [YARN] ApplicationMaster's Finish...

2014-09-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2198#issuecomment-54151738 Can you add some details about the cases you are seeing this happen in? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-2096 [SQL]: Correctly parse dot notation...

2014-09-02 Thread chuxi
Github user chuxi commented on the pull request: https://github.com/apache/spark/pull/2082#issuecomment-54152206 @marmbrus , do I need to check something else? Or merge the code? Besides, I see another PR : https://github.com/apache/spark/pull/2230 :) it is my friend,

[GitHub] spark pull request: [SPARK-3286] - Cannot view ApplicationMaster U...

2014-09-02 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/2206#discussion_r16987150 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -174,7 +174,7 @@ private[spark] class

[GitHub] spark pull request: [SPARK-3304] [YARN] ApplicationMaster's Finish...

2014-09-02 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2198#issuecomment-54155111 As I mentioned in JIRA, if uncaught exception is thrown from Reporter thread, finish status is marked as SUCCEEDED. Futhermore, in YARN Cluster mode, if we don't

[GitHub] spark pull request: SPARK-3223 runAsSparkUser cannot change HDFS w...

2014-09-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2126#issuecomment-54155475 How is the user field in mesos usually set? Is mesos launching a separate process or using threads? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-3286] - Cannot view ApplicationMaster U...

2014-09-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2206#issuecomment-54157824 It looks like you added SPARK-3287 into this PR, can you please separate that out? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-3286] - Cannot view ApplicationMaster U...

2014-09-02 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/2206#discussion_r16989335 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -174,7 +174,7 @@ private[spark] class

[GitHub] spark pull request: [SPARK-3304] [YARN] ApplicationMaster's Finish...

2014-09-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2198#issuecomment-54162723 sorry I should have clarified, I am just curious what particular exception you are seeing that is causing this? I agree the change is a good idea. Its just

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread willb
Github user willb commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54165469 @concretevitamin I cherry-picked @aarondav's fix (and added a very simple fix to handle cases that it didn't). --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54165982 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19590/consoleFull) for PR 2220 at commit

[GitHub] spark pull request: SPARK-2461. Add a toString method to Generaliz...

2014-09-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/1388#issuecomment-54174652 I believe the failure is unrelated. I noticed it on SPARK-3052 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-3052. Misleading and spurious FileSystem...

2014-09-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/1956#issuecomment-54174772 I believe the failure is unrelated. I noticed it on SPARK-2461 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [WIP][SPARK-3098]In some cases, the result of ...

2014-09-02 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2083#issuecomment-54176053 @srowen Thanks for clarifying that. I agree that it would be confusing for people to get different results depending on when they lookup an item in an RDD. Perhaps the

[GitHub] spark pull request: [SPARK-3304] [YARN] ApplicationMaster's Finish...

2014-09-02 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2198#issuecomment-54177193 Sorry too, I didn't understand what you intended. Actually, I didn't see exception causing Reporter thread dead but unexpected exception like OOM or any other

[GitHub] spark pull request: [SPARK-2845] Add timestamps to block manager e...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/654#discussion_r16997720 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -467,12 +469,14 @@ private[spark] object JsonProtocol { def

[GitHub] spark pull request: [SPARK-3076] [Jenkins] catch report test tim...

2014-09-02 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/1974#issuecomment-54177354 I merged this and bumped the timeout here to 120m and bumped the Jenkins-side timeout to 130m Btw @pwendell how did you do that? I'm curious since the [commit

[GitHub] spark pull request: [SPARK-2845] Add timestamps to block manager e...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/654#issuecomment-54177509 The changes look good to me. Can you up-merge this again (sorry) once you have a chance? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1218#issuecomment-54177665 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1218#issuecomment-54178220 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19591/consoleFull) for PR 1218 at commit

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r16998247 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -28,6 +28,7 @@ class FakeSchedulerBackend extends

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r16998271 --- Diff: project/MimaExcludes.scala --- @@ -106,6 +106,13 @@ object MimaExcludes { MimaBuild.excludeSparkClass(storage.Values) ++

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r16998390 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -28,6 +28,7 @@ class FakeSchedulerBackend extends

[GitHub] spark pull request: SPARK-3014. Log a more informative messages in...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1934#issuecomment-54180326 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19592/consoleFull) for PR 1934 at commit

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r16999218 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -91,15 +100,36 @@ private[history] class

[GitHub] spark pull request: [MLlib] Squash bug in IndexedRowMatrix

2014-09-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2224#issuecomment-54181678 Merged into master and branch-1.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r16999386 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -91,15 +100,36 @@ private[history] class

[GitHub] spark pull request: [FIX][MLLIB] Use SquaredL2Updater in LogisticR...

2014-09-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54181765 Jenkins, add to whitelist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r16999473 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -91,15 +100,36 @@ private[history] class

[GitHub] spark pull request: [MLlib] Squash bug in IndexedRowMatrix

2014-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [FIX][MLLIB] Use SquaredL2Updater in LogisticR...

2014-09-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54182179 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

2014-09-02 Thread xinyunh
Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54184220 May I know in which test cases do we failed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

2014-09-02 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54184669 The link to the test results is in Spark QA's latest message: QA tests have finished It looks like you have a Scala style problem. You can run tests locally by

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17000779 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -117,84 +147,80 @@ private[history] class

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17000875 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -117,84 +147,80 @@ private[history] class

[GitHub] spark pull request: [SPARK-3347] [yarn] Fix yarn-alpha compilation...

2014-09-02 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/2236 [SPARK-3347] [yarn] Fix yarn-alpha compilation. Missing import. Oops. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-3347

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17000918 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -117,84 +147,80 @@ private[history] class

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17000986 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -117,84 +147,80 @@ private[history] class

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17001036 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala --- @@ -31,4 +31,8 @@ private[spark] trait SchedulerBackend { def

[GitHub] spark pull request: [SPARK-3347] [yarn] Fix yarn-alpha compilation...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2236#issuecomment-54186018 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19595/consoleFull) for PR 2236 at commit

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17001214 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -116,4 +126,22 @@ private[spark] class

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17001259 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -116,4 +126,22 @@ private[spark] class

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

2014-09-02 Thread xinyunh
Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54186634 Thank you! Fixed this code style issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54186757 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19596/consoleFull) for PR 2099 at commit

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1218#issuecomment-54186816 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19591/consoleFull) for PR 1218 at commit

[GitHub] spark pull request: [SPARK-3347] [yarn] Fix yarn-alpha compilation...

2014-09-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2236#issuecomment-54187014 thanks, I'll pull this in when jenkins finishes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1218#discussion_r17001484 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -116,4 +126,22 @@ private[spark] class

[GitHub] spark pull request: SPARK-3331 [BUILD] PEP8 tests fail because the...

2014-09-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/#issuecomment-54187735 LGTM, so I've merged this into `master`. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-3331 [BUILD] PEP8 tests fail because the...

2014-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   4   >