Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@JustinPihony You know, I do not care which PR is merged eventually. You
can try to clean your PR at your best. I will review your PR when it is ready.
Thanks for your work! Please continue to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61895 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61895/consoleFull)**
for PR 14004 at commit
Github user uzadude commented on the issue:
https://github.com/apache/spark/pull/14068
Hi srowen,
I have read the "how to contribute" wiki. I thought that it is too small of
enhancement to open a jira for it and it passes the tests.
---
If your project is set up for it, you can
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Thank you, @cloud-fan .
I updated the PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/13876
Looks pretty good.
cc @cloud-fan for another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13876#discussion_r69854463
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -820,16 +820,24 @@ object ConstantFolding extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69854388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class StringRPad(str:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69854198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -198,6 +203,66 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14072
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14084
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14075
Sure, let me know whether I need to submit another PR for backporting to
2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13983#discussion_r69854073
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -58,4 +61,17 @@ public void overlappingCopyMemory() {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13983#discussion_r69854030
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -58,4 +61,17 @@ public void overlappingCopyMemory() {
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14084
LGTM - I'm going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/14084
cc @rxin @ericl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14072
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14075
Thanks - then we should merge this in 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
Then the best course of action would be to use my current impl as it works
no matter the position of copy. I can add the additional tests if that would
make it more amenable? Otherwise I'll
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69853706
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,145 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69853682
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,41 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69853668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,145 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14084
**[Test build #61894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61894/consoleFull)**
for PR 14084 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13494
hi @lianhuiwang can you rebase your PR to master? I think it's pretty close!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69853496
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -347,4 +347,24 @@ class StringFunctionsSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69853489
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1689,4 +1689,76 @@ class SQLQuerySuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14026
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/14084
[SPARK-16021][test-maven] Fix the maven build
## What changes were proposed in this pull request?
Fixed the maven build for #13983
## How was this patch tested?
The
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61892/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14026
**[Test build #61892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61892/consoleFull)**
for PR 14026 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69853099
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,52 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69853050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14077
(Personally, I hope this does not get delayed because this usage was
introduced in Spark Summit PPT and I guess users would try to use this API.)
---
If your project is set up for it, you can
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69851574
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,52 @@ class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69851306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69851163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69851130
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,52 @@ class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69851065
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69851040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69850990
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
Thank you for confirming that it is a bug in another PR.
Regarding the solution of this PR, it is not a true circular reference. The
solution in this PR is to minimize the duplicate
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69850899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69850820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +654,160 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850568
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850526
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13494
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61891/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13494
**[Test build #61891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61891/consoleFull)**
for PR 13494 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850344
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850312
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850289
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850272
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14075
@rxin This is a regression. I did try it in Spark 1.6. It works well. I
think we need to fix it in Spark 2.0
Thanks!
---
If your project is set up for it, you can reply to this email
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850225
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850211
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14030
**[Test build #61893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61893/consoleFull)**
for PR 14030 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850185
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala
---
@@ -18,27 +18,126 @@
package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850087
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala
---
@@ -18,27 +18,126 @@
package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850001
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -33,91 +38,144 @@
// The
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -189,28 +189,29 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849874
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -189,28 +189,29 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13494
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61890/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13494
**[Test build #61890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61890/consoleFull)**
for PR 13494 at commit
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14082
@shivaram @mengxr It would be nice if any of you can help review this one,
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
@gatorsmile If `copy` is a bug, then that is fine with me (I just commented
my findings on this and will be curious to hear back). That said, it would make
my implementation simpler. I'd be
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849567
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -19,9 +19,14 @@
import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849512
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -341,63 +328,115 @@ public UnsafeArrayData
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849441
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -341,63 +328,115 @@ public UnsafeArrayData
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14083#discussion_r69849376
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -165,111 +169,99 @@ abstract class
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14075
@rxin It does look like this might have been a regression introduced via
[the initial creation of
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849225
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -237,62 +229,57 @@ public Decimal
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14083#discussion_r69849157
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -165,111 +169,99 @@ abstract class LogicalPlan
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r69849058
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -236,29 +246,41 @@ private[spark] class TaskSchedulerImpl(
*
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14053
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14053
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14004
LGTM except some style comment, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69848762
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -347,4 +347,24 @@ class StringFunctionsSuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69848674
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,41 @@ class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13517
NP :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69848618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -198,6 +203,66 @@ case class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13517
Oh... sorry... and thanks..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13517
@HyukjinKwon still on holiday...
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/14083
yea. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14083
@viirya you mean I forgot to add `time(sql(query))`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@JustinPihony Thanks for your review! Let me try to answer your concerns.
- The `copy` function location is actually a bug. See another PR:
https://github.com/apache/spark/pull/14075.
-
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r69848182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -277,14 +268,52 @@ case class Divide(left:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/14083
The codes in the description seems incomplete?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13517
(@hvanhovell I just addressed your comments!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r69848124
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -249,11 +244,7 @@ case class Divide(left:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13890#discussion_r69848022
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -74,13 +74,71 @@ object RDDConversions {
}
}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13988
(@rxin gentle ping..)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14026
**[Test build #61892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61892/consoleFull)**
for PR 14026 at commit
Github user cloud-fan closed the pull request at:
https://github.com/apache/spark/pull/8066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14072
**[Test build #3167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3167/consoleFull)**
for PR 14072 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13876
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13876
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61888/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13876
**[Test build #61888 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61888/consoleFull)**
for PR 13876 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/13701
I will update this soon..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r69844600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -374,13 +407,15 @@ object MapObjects {
*
1 - 100 of 736 matches
Mail list logo
