[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62043 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62043/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62043/ Test FAILed. ---

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SQL] Make CSV cast null value...

2016-07-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14118 I just wonder why string should be ignored in the case above. I mean, you just said "we don't need to handle type-specific null values" and it seems strings are okay to handle together. ---

[GitHub] spark pull request #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-07-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13993#discussion_r70176040 --- Diff: R/pkg/R/mllib.R --- @@ -53,26 +53,27 @@ setClass("AFTSurvivalRegressionModel", representation(jobj = "jobj")) #' @note KMeansModel since

[GitHub] spark issue #14121: [MINOR][ML] update comment where is inconsistent with co...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14121 **[Test build #62042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62042/consoleFull)** for PR 14121 at commit

[GitHub] spark issue #14121: [MINOR][ML] update comment where is inconsistent with co...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14121 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14121: [MINOR][ML] update comment where is inconsistent with co...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14121 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62042/ Test PASSed. ---

[GitHub] spark issue #14011: [SparkR] [Doc] SparkR ML user guides update for 2.0

2016-07-09 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14011 @shivaram I think it's good to go, I only did user guides sync and reorg. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SQL] Make CSV cast null value...

2016-07-09 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/14118 FYI, before [SPARK-14143](https://issues.apache.org/jira/browse/SPARK-14143), null values had been handled this way: : ```scala if (datum == options.nullValue && nullable &&

[GitHub] spark issue #14121: [MINOR][ML] update comment where is inconsistent with co...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14121 **[Test build #62042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62042/consoleFull)** for PR 14121 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62043/consoleFull)** for PR 14116 at commit

[GitHub] spark pull request #14121: [MINOR][ML] update comment where is inconsistent ...

2016-07-09 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/14121 [MINOR][ML] update comment where is inconsistent with code in ml.regression.LinearRegression ## What changes were proposed in this pull request? In `train` method of

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SQL] Make CSV cast null value...

2016-07-09 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/14118 The diff that github shows is a mess. The actual diff (which is quite small) is:

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62041/ Test FAILed. ---

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62041/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62040/ Test FAILed. ---

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62040/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14114 Hi, @rxin . Now, it's ready for review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62039/ Test PASSed. ---

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62039/consoleFull)** for PR 14114 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62041/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62040/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SQL] Make CSV cast null value...

2016-07-09 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14118 No - I just noticed a JIRA that said it was a regression, so I wanted to make sure you caught this in the RC cycle --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62038/ Test FAILed. ---

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62038/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62039/consoleFull)** for PR 14114 at commit

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14115 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14115 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62037/ Test PASSed. ---

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14115 **[Test build #62037 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62037/consoleFull)** for PR 14115 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62038/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62036/ Test FAILed. ---

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62036/consoleFull)** for PR 14114 at commit

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62035/ Test FAILed. ---

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62035/consoleFull)** for PR 14114 at commit

[GitHub] spark pull request #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA ...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14116#discussion_r70173703 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala --- @@ -0,0 +1,230 @@ +/* + * Licensed

[GitHub] spark pull request #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA ...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14116#discussion_r70173700 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala --- @@ -0,0 +1,230 @@ +/* + * Licensed

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14115 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14115 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62034/ Test FAILed. ---

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14115 **[Test build #62034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62034/consoleFull)** for PR 14115 at commit

[GitHub] spark issue #11317: [SPARK-12639] [SQL] Mark Filters Fully Handled By Source...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11317 **[Test build #3176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3176/consoleFull)** for PR 11317 at commit

[GitHub] spark issue #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13969 **[Test build #3174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3174/consoleFull)** for PR 13969 at commit

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #3175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3175/consoleFull)** for PR 13991 at commit

[GitHub] spark pull request #14071: [SPARK-16397][SQL] make CatalogTable more general...

2016-07-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14071#discussion_r70173359 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -45,35 +45,28 @@ case class CatalogFunction( */

[GitHub] spark pull request #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA ...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14116#discussion_r7017 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala --- @@ -0,0 +1,230 @@ +/* + * Licensed

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14115 **[Test build #62037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62037/consoleFull)** for PR 14115 at commit

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14114 Now, `getTableMetadata` is improved. Thank you for that advice, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70173212 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -146,8 +148,10 @@ class SessionCatalog(

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62036/consoleFull)** for PR 14114 at commit

[GitHub] spark pull request #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL pr...

2016-07-09 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/14119#discussion_r70173180 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/JavaSparkSqlExample.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62035/consoleFull)** for PR 14114 at commit

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14115 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14115 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62032/ Test FAILed. ---

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14115 **[Test build #62032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62032/consoleFull)** for PR 14115 at commit

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70173134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -146,8 +148,10 @@ class SessionCatalog(

[GitHub] spark pull request #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL pr...

2016-07-09 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/14119#discussion_r70173131 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/SqlDataSourceExample.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70173113 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -146,8 +148,10 @@ class SessionCatalog(

[GitHub] spark pull request #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL pr...

2016-07-09 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/14119#discussion_r70173058 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -41,43 +35,47 @@ object HiveFromSpark { //

[GitHub] spark pull request #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL pr...

2016-07-09 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/14119#discussion_r70173035 --- Diff: docs/sql-programming-guide.md --- @@ -1380,17 +949,17 @@ metadata. {% highlight scala %} -// spark is an existing

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-09 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/14112 @jkbradley I find it not easy to add a unit test to cover the logic. Appreciate your thoughts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70172847 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -146,8 +148,10 @@ class SessionCatalog(

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-09 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/14112 PR created. Sorry I got something else that I need to turn to. Ideally, the overriding `getAndSetParams` should be in LDAParams, thus it can be reused by LDA and LDA Local/Distributed Model. Please

[GitHub] spark pull request #14114: [SPARK-16458][SQL] SessionCatalog should support ...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14114#discussion_r70172672 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -442,6 +442,10 @@ class SessionCatalog(

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14115 **[Test build #62034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62034/consoleFull)** for PR 14115 at commit

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14115 Now, it preserves the previous behavior for dropping default db, and throws new exception message for new cases only. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62031/ Test FAILed. ---

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62031/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14116 **[Test build #62030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62030/consoleFull)** for PR 14116 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62030/ Test FAILed. ---

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14120: [SPARK-16199][SQL] Add a method to list the referenced c...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14120 **[Test build #62033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62033/consoleFull)** for PR 14120 at commit

[GitHub] spark issue #14120: [SPARK-16199][SQL] Add a method to list the referenced c...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14120 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62033/ Test FAILed. ---

[GitHub] spark issue #14120: [SPARK-16199][SQL] Add a method to list the referenced c...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14120 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70172456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -146,8 +148,8 @@ class SessionCatalog(

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70172359 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1270,21 +1270,28 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #14115: [SPARK-16459][SQL] Prevent dropping current datab...

2016-07-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14115#discussion_r70172357 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -146,8 +148,8 @@ class SessionCatalog(

[GitHub] spark issue #14120: [SPARK-16199][SQL] Add a method to list the referenced c...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14120 **[Test build #62033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62033/consoleFull)** for PR 14120 at commit

[GitHub] spark pull request #14120: [SPARK-16199][SQL] Add a method to list the refer...

2016-07-09 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/14120 [SPARK-16199][SQL] Add a method to list the referenced columns in data source Filter ## What changes were proposed in this pull request? It would be useful to support listing the columns

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

2016-07-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13901 @rxin I added tests to this pull request and submitted https://github.com/apache/spark/pull/14120 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14116 Sure. I'll update the PR and proceed in this way. Thank you, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA ...

2016-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14116#discussion_r70172331 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchemaSuite.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] spark issue #14115: [SPARK-16459][SQL] Prevent dropping current database

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14115 **[Test build #62032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62032/consoleFull)** for PR 14115 at commit

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-09 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/14112 Thanks @GayathriMurali for the PR. I think we'll need to override the default behavior of getAndSetParams. Meanwhile, we need to invoke both convertVectorColumnsToML and convertMatrixColumnsToML.

[GitHub] spark issue #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL programmi...

2016-07-09 Thread aokolnychyi
Github user aokolnychyi commented on the issue: https://github.com/apache/spark/pull/14119 @liancheng could you, please, review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14090#discussion_r70172206 --- Diff: docs/sparkr.md --- @@ -306,6 +306,64 @@ head(ldf, 3) {% endhighlight %} + Run a given function on a large dataset

[GitHub] spark issue #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL programmi...

2016-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14119 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14117: [SPARK-16461][SQL] Support partition batch pruning with ...

2016-07-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14117 Thank you! Could you take a look @davies and @liancheng ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #11317: [SPARK-12639] [SQL] Mark Filters Fully Handled By Source...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11317 **[Test build #3176 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3176/consoleFull)** for PR 11317 at commit

[GitHub] spark issue #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13969 **[Test build #3174 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3174/consoleFull)** for PR 13969 at commit

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #3175 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3175/consoleFull)** for PR 13991 at commit

[GitHub] spark pull request #14119: [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL pr...

2016-07-09 Thread aokolnychyi
GitHub user aokolnychyi opened a pull request: https://github.com/apache/spark/pull/14119 [SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL programming guide and examples ## What changes were proposed in this pull request? - Hard-coded Spark SQL sample snippets were moved

[GitHub] spark issue #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA support

2016-07-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14116 This looks pretty good. Can you add more comments explaining what each class/method does, and how the whole thing works? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #14116: [SPARK-16452][SQL][WIP] Basic INFORMATION_SCHEMA ...

2016-07-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14116#discussion_r70172130 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala --- @@ -0,0 +1,230 @@ +/* + * Licensed to the

  1   2   3   >