[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63715/ Test PASSed. ---

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #63715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63715/consoleFull)** for PR 14531 at commit

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-12 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74681629 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +308,91 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #63715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63715/consoleFull)** for PR 14531 at commit

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14625 @cloud-fan I see. Will try to rewrite the test cases with very few records. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-08-12 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13428 Modulo the minor review comments already left on this PR, this looks good to me as well. Is there any risk in putting this into 2.0.1 / 2.1.0? Will this change the resolution behavior for any

[GitHub] spark pull request #13428: [SPARK-12666][CORE] SparkSubmit packages fix for ...

2016-08-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/13428#discussion_r74680766 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -891,10 +891,12 @@ private[spark] object SparkSubmitUtils { val

[GitHub] spark pull request #13428: [SPARK-12666][CORE] SparkSubmit packages fix for ...

2016-08-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/13428#discussion_r74680747 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -891,10 +891,12 @@ private[spark] object SparkSubmitUtils { val

[GitHub] spark pull request #13428: [SPARK-12666][CORE] SparkSubmit packages fix for ...

2016-08-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/13428#discussion_r74680749 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -891,10 +891,12 @@ private[spark] object SparkSubmitUtils { val

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 Could you take a look please @rxin and @liancheng ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14627 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14627 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63714/ Test PASSed. ---

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14627 **[Test build #63714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63714/consoleFull)** for PR 14627 at commit

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74680540 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -207,15 +310,52 @@ private[spark] class

[GitHub] spark pull request #14524: [SPARK-16832] [ML] [WIP] CrossValidator and Train...

2016-08-12 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14524#discussion_r74680486 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala --- @@ -67,7 +67,7 @@ private[shared] object

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74680428 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -396,40 +393,6 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74680404 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -363,3 +503,82 @@ private[spark] class

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74680384 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -144,16 +162,101 @@ private[spark] class

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74680344 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -81,6 +86,19 @@ private[spark] class

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 Ah, yes thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14627 Only committers know what is needed at Spark. We are just contributors to send a pull request as a proposal. You can do anything in your PR. I'm not against you or this PR. Good luck! :)

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 BTW, I am waiting for the Jenkins tests before cc someone. However, as you are already in here (I appreciate it), I appreciate it if you take a look. --- If your project is set up for it, you

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 Yes, it is not. I am sorry for the confusion. It seems your fix is perfectly fine and correct but it is just a clean-up to get rid of duplicated logics. BTW, I am also okay with

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14625 I think `HiveCompatibilitySuite` has 2 purposes: 1. using Hive's test to improve our test coverage 2. make sure our result is same with Hive for same query(with blacklist) Now

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14627 Then, it's not about fixing new or remaining bugs of the previous one (SPARK-16975). I see! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 @dongjoon-hyun Thanks for taking a look! Actually, I intended to test your fix for all data sources just to make sure the issue in `SPARK-16975` is resolved for all. As it is a

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74680082 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultinomialLogisticRegressionSuite.scala --- @@ -0,0 +1,1001 @@ +/* + * Licensed

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 I am happy to add some more tests but I am a bit confused of what I should test. Maybe a test for `HadoopFsRelation.listLeafFiles` to make sure directories are not included for the return

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14118 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63713/ Test PASSed. ---

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14118 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14118 **[Test build #63713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63713/consoleFull)** for PR 14118 at commit

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74680015 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1078,58 +1200,53 @@ private class LogisticCostFun(

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679998 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -981,42 +1133,12 @@ private class LogisticAggregator(

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679990 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -966,10 +1102,26 @@ private class LogisticAggregator(

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14627 Hi, @HyukjinKwon . You test code seems to pass without your code. Could you confirm that first? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679956 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -966,10 +1102,26 @@ private class LogisticAggregator(

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679921 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -966,10 +1102,26 @@ private class LogisticAggregator(

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-12 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/14537 @rxin Can you please review when you find time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-12 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/14537 Thank you thejas and @mallman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679442 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679034 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74679001 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74678972 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14627 **[Test build #63714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63714/consoleFull)** for PR 14627 at commit

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 FYI, in most data sources, it would try to read duplicately or fail to infer the schema (haven't tested this yet) if directories are allowed in `FileFormat.inferSchema`. --- If your project

[GitHub] spark pull request #14627: [SPARK-16975][SQL] Do not duplicately check file ...

2016-08-12 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14627 [SPARK-16975][SQL] Do not duplicately check file paths in data sources implementing FileFormat and prevent to attempt to list twice in ORC ## What changes were proposed in this pull request?

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-12 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74678564 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63709/ Test FAILed. ---

[GitHub] spark issue #14311: [SPARK-16550] [core] Certain classes fail to deserialize...

2016-08-12 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14311 Hmm, weird. Looks like replication tests are still failing. I can help investigate later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63709/consoleFull)** for PR 14607 at commit

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63708/ Test FAILed. ---

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63708/consoleFull)** for PR 14607 at commit

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-08-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14452 @hvanhovell By fixing some bugs in latest code changes, this PR now can be general to all subqueries, instead of just CTE subqueries. Please suggest and review when you can. Thanks! --- If your

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14118 **[Test build #63713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63713/consoleFull)** for PR 14118 at commit

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-12 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/14118 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63711/ Test PASSed. ---

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14447 **[Test build #63711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63711/consoleFull)** for PR 14447 at commit

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-12 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/14118 This is ready for review. To summarize, this patch casts user-specified `nullValue`s to `null`s for all supported types including the string type: - this fixes the problem where null

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63707/ Test FAILed. ---

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63707/consoleFull)** for PR 14607 at commit

[GitHub] spark issue #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics that cr...

2016-08-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14626 @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics that cr...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63712/ Test PASSed. ---

[GitHub] spark issue #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics that cr...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14626 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics that cr...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14626 **[Test build #63712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63712/consoleFull)** for PR 14626 at commit

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14182 Please see comment https://github.com/apache/spark/pull/14182#discussion_r73985582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14613: [SPARK-16883][SparkR]:SQL decimal type is not properly c...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14613 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics that cr...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14626 **[Test build #63712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63712/consoleFull)** for PR 14626 at commit

[GitHub] spark issue #14613: [SPARK-16883][SparkR]:SQL decimal type is not properly c...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14613 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63710/ Test PASSed. ---

[GitHub] spark issue #14613: [SPARK-16883][SparkR]:SQL decimal type is not properly c...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14613 **[Test build #63710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63710/consoleFull)** for PR 14613 at commit

[GitHub] spark pull request #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics ...

2016-08-12 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/14626 [SPARK-16519][SPARKR] Handle SparkR RDD generics that create warnings in R CMD check ## What changes were proposed in this pull request? Rename RDD functions for now to avoid CRAN

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14623 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63706/ Test PASSed. ---

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14623 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14623 **[Test build #63706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63706/consoleFull)** for PR 14623 at commit

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676531 --- Diff: R/pkg/R/mllib.R --- @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676513 --- Diff: R/pkg/R/mllib.R --- @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676433 --- Diff: R/pkg/R/mllib.R --- @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676368 --- Diff: R/pkg/R/mllib.R --- @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676118 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676054 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74676001 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675990 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675925 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14447 **[Test build #63711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63711/consoleFull)** for PR 14447 at commit

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675732 --- Diff: R/pkg/R/mllib.R --- @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675724 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675709 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark issue #14613: [SPARK-16883][SparkR]:SQL decimal type is not properly c...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14613 **[Test build #63710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63710/consoleFull)** for PR 14613 at commit

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-12 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74675584 --- Diff: R/pkg/R/mllib.R --- @@ -433,15 +433,15 @@ setMethod("predict", signature(object = "KMeansModel"), #' #' @param data A

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675514 --- Diff: R/pkg/R/mllib.R --- @@ -313,6 +313,7 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' @return \code{spark.posterior}

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675553 --- Diff: R/pkg/R/mllib.R --- @@ -724,7 +728,8 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula #' @param

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74675520 --- Diff: R/pkg/R/mllib.R --- @@ -377,6 +380,7 @@ setMethod("spark.perplexity", signature(object = "LDAModel"), #' which means

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63709/consoleFull)** for PR 14607 at commit

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74675268 --- Diff: R/pkg/R/mllib.R --- @@ -633,9 +635,10 @@ setMethod("write.ml", signature(object = "KMeansModel", path = "character"), #'

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74675213 --- Diff: R/pkg/R/mllib.R --- @@ -433,15 +433,15 @@ setMethod("predict", signature(object = "KMeansModel"), #' #' @param data A

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63708/consoleFull)** for PR 14607 at commit

  1   2   3   4   5   6   >