[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-30 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 @zsxwing I think it may cause some other problem. For example, if we got some ExecutorLostFailure and the speculated task was running on it, the `numRunningTasks` will never be zero. ---

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16422 After rethinking about it, `DESC EXTENDED/FORMATTED COLUMN` discloses the data patterns/statistics info. These info are pretty sensitive. Not all the users should be allowed to access it.

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16422 To get the column names and types, we do not need `DESC COLUMN`. For retrieving the statistics, each vendor has different ways. Normally, users can access the statistics from the

[GitHub] spark issue #16341: [SQL] [WIP] Switch internal catalog types to use URI ins...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16341 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16341: [SQL] [WIP] Switch internal catalog types to use URI ins...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16341 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70762/ Test FAILed. ---

[GitHub] spark issue #16341: [SQL] [WIP] Switch internal catalog types to use URI ins...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16341 **[Test build #70762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70762/testReport)** for PR 16341 at commit

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94267919 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16417 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70761/ Test PASSed. ---

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16417 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16417 **[Test build #70761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70761/testReport)** for PR 16417 at commit

[GitHub] spark issue #16341: [SQL] [WIP] Switch internal catalog types to use URI ins...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16341 **[Test build #70762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70762/testReport)** for PR 16341 at commit

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16441 Thanks for the PR; I do want to get this fixed. However, I don't think this is the right way to make predictions of probabilities for GBTs. I believe it should depend on the loss used. E.g.,

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16417 **[Test build #70761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70761/testReport)** for PR 16417 at commit

[GitHub] spark issue #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn't fail...

2016-12-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16387 cc @rxin @zsxwing too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16417 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #16403: [SPARK-18819][CORE] Double byte alignment on ARM ...

2016-12-30 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/16403#discussion_r94264691 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -244,6 +251,18 @@ public static void throwException(Throwable t) {

[GitHub] spark pull request #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against a...

2016-12-30 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16405#discussion_r94264468 --- Diff: examples/src/main/python/mllib/decision_tree_regression_example.py --- @@ -44,7 +44,7 @@ # Evaluate model on test instances and compute

[GitHub] spark pull request #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against a...

2016-12-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16405#discussion_r94263914 --- Diff: dev/lint-python --- @@ -19,10 +19,8 @@ SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" SPARK_ROOT_DIR="$(dirname

[GitHub] spark pull request #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against a...

2016-12-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16405#discussion_r94263510 --- Diff: examples/src/main/python/mllib/decision_tree_regression_example.py --- @@ -44,7 +44,7 @@ # Evaluate model on test instances and

[GitHub] spark pull request #16424: [SPARK-19016][SQL][DOC] Document scalable partiti...

2016-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-30 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/16424 OK, I'm merging this to master and branch-2.1. Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16441 **[Test build #70760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70760/testReport)** for PR 16441 at commit

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16441 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70760/ Test FAILed. ---

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16441 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16441 **[Test build #70760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70760/testReport)** for PR 16441 at commit

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16441 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against a...

2016-12-30 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16405#discussion_r94259691 --- Diff: examples/src/main/python/mllib/decision_tree_regression_example.py --- @@ -44,7 +44,7 @@ # Evaluate model on test instances and compute

[GitHub] spark pull request #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against a...

2016-12-30 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16405#discussion_r94259548 --- Diff: dev/lint-python --- @@ -19,10 +19,8 @@ SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" SPARK_ROOT_DIR="$(dirname "$SCRIPT_DIR")"

[GitHub] spark pull request #16403: [SPARK-18819][CORE] Double byte alignment on ARM ...

2016-12-30 Thread michaelkamprath
Github user michaelkamprath commented on a diff in the pull request: https://github.com/apache/spark/pull/16403#discussion_r94259189 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -22,10 +22,14 @@ import java.lang.reflect.Method;

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16441 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70759/ Test FAILed. ---

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16441 **[Test build #70759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70759/testReport)** for PR 16441 at commit

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16441 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16403: [SPARK-18819][CORE] Double byte alignment on ARM ...

2016-12-30 Thread michaelkamprath
Github user michaelkamprath commented on a diff in the pull request: https://github.com/apache/spark/pull/16403#discussion_r94257179 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -244,6 +251,18 @@ public static void throwException(Throwable t)

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70758/ Test PASSed. ---

[GitHub] spark issue #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict pr...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16441 **[Test build #70759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70759/testReport)** for PR 16441 at commit

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13077 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13077 **[Test build #70758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70758/testReport)** for PR 13077 at commit

[GitHub] spark pull request #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to pre...

2016-12-30 Thread imatiach-msft
GitHub user imatiach-msft opened a pull request: https://github.com/apache/spark/pull/16441 [SPARK-14975][ML][WIP] Fixed GBTClassifier to predict probability per training instance and fixed interfaces ## What changes were proposed in this pull request? For all of the

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13077 **[Test build #70758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70758/testReport)** for PR 13077 at commit

[GitHub] spark pull request #16401: [SPARK-18998] [SQL] Add a cbo conf to switch betw...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16401#discussion_r94253091 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -95,6 +96,29 @@ abstract class LogicalPlan

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16233 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70757/ Test PASSed. ---

[GitHub] spark issue #16403: [SPARK-18819][CORE] Double byte alignment on ARM platfor...

2016-12-30 Thread michaelkamprath
Github user michaelkamprath commented on the issue: https://github.com/apache/spark/pull/16403 @srowen To answer the use case question, it is primarily academic for learning and testing. Students and researchers build clusters of Raspberry PI, ODROID, or other SBCs to have a cost

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16233 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16233 **[Test build #70757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70757/testReport)** for PR 16233 at commit

[GitHub] spark pull request #16401: [SPARK-18998] [SQL] Add a cbo conf to switch betw...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16401#discussion_r94251780 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/estimation/EstimationSuite.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16401: [SPARK-18998] [SQL] Add a cbo conf to switch betw...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16401#discussion_r94251558 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -642,6 +642,13 @@ object SQLConf { .doubleConf

[GitHub] spark pull request #16401: [SPARK-18998] [SQL] Add a cbo conf to switch betw...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16401#discussion_r94251460 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -95,6 +96,29 @@ abstract class LogicalPlan

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15664 Thank you, @gatorsmile . Happy New Year! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16320 LGTM cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #16403: [SPARK-18819][CORE] Double byte alignment on ARM ...

2016-12-30 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/16403#discussion_r94249364 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -244,6 +251,18 @@ public static void throwException(Throwable t) {

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16404 LGTM cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15664 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15664: [SPARK-18123][SQL] Use db column names instead of...

2016-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15664 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70756/ Test PASSed. ---

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16371 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16371 **[Test build #70756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70756/testReport)** for PR 16371 at commit

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16233 **[Test build #70757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70757/testReport)** for PR 16233 at commit

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70755/ Test PASSed. ---

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #70755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70755/testReport)** for PR 15880 at commit

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16404 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70754/ Test PASSed. ---

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16404 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16404 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70753/ Test PASSed. ---

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16404 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16404 **[Test build #70753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70753/testReport)** for PR 16404 at commit

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16404 **[Test build #70754 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70754/testReport)** for PR 16404 at commit

[GitHub] spark pull request #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread cjuexuan
Github user cjuexuan commented on a diff in the pull request: https://github.com/apache/spark/pull/16428#discussion_r94239683 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -573,6 +573,7 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16428#discussion_r94239452 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -573,6 +573,7 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread cjuexuan
Github user cjuexuan commented on a diff in the pull request: https://github.com/apache/spark/pull/16428#discussion_r94239100 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -71,7 +71,9 @@ private[csv] class

[GitHub] spark pull request #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16428#discussion_r94238157 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -71,7 +71,9 @@ private[csv] class

[GitHub] spark issue #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16428 Ah, I meant to add a test there in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16417 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16417 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70752/ Test FAILed. ---

[GitHub] spark issue #16417: [SPARK-19014][SQL] support complex aggregate buffer in H...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16417 **[Test build #70752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70752/testReport)** for PR 16417 at commit

[GitHub] spark issue #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread cjuexuan
Github user cjuexuan commented on the issue: https://github.com/apache/spark/pull/16428 @HyukjinKwon ,I already run `CSVSuite` ,and all tests passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16371 **[Test build #70756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70756/testReport)** for PR 16371 at commit

[GitHub] spark issue #16428: [SPARK-19018][SQL] ADD csv write charset param

2016-12-30 Thread cjuexuan
Github user cjuexuan commented on the issue: https://github.com/apache/spark/pull/16428 @HyukjinKwon ,I see ,because my version is `2.0.2`,we use `ByteArrayOutputStream` and call toString method ,this will using `Charset.defaultCharset()` and bind with env ,and in master branch ,we

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94234598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -510,32 +539,91 @@ class Analyzer( * Replaces

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94234459 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala --- @@ -44,39 +44,48 @@ abstract class Collect

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94234334 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94234295 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94234184 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94233910 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94233881 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94233778 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2016-12-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94232541 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class

[GitHub] spark issue #16401: [SPARK-18998] [SQL] Add a cbo conf to switch between def...

2016-12-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16401 Just one minor question about the config. other LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #16401: [SPARK-18998] [SQL] Add a cbo conf to switch betw...

2016-12-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16401#discussion_r94232049 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -642,6 +642,13 @@ object SQLConf { .doubleConf

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16233 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16233 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70750/ Test PASSed. ---

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16233 **[Test build #70750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70750/testReport)** for PR 16233 at commit

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #70755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70755/testReport)** for PR 15880 at commit

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-12-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15880 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16401: [SPARK-18998] [SQL] Add a cbo conf to switch between def...

2016-12-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16401 LGTM. What if we just add the conf parameter to the `statistics` method and give it a default value? e.g. `def statistics(conf: CatalystConf = SimpleCatalystConf)`. How much mode do we need to

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16404 **[Test build #70754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70754/testReport)** for PR 16404 at commit

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16404 **[Test build #70753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70753/testReport)** for PR 16404 at commit

[GitHub] spark pull request #16404: [SPARK-18969][SQL] Support grouping by nondetermi...

2016-12-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16404#discussion_r94229396 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1918,28 +1918,37 @@ class Analyzer( case

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2016-12-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16404 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16233 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70748/ Test PASSed. ---

  1   2   3   >