[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-03 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r119986035 --- Diff: external/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisInputDStreamBuilderSuite.java --- @@ -45,7 +46,7 @@ public

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-03 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r119986280 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisInputDStreamBuilderSuite.scala --- @@ -111,5 +110,28 @@ class

[GitHub] spark pull request #18159: [SPARK-20703][SQL] Associate metrics with data wr...

2017-06-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r12935 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -17,38 +17,97 @@ package

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77710/testReport)** for PR 18159 at commit

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12478 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -730,4 +730,58 @@ public void testToLong() throws

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77709/testReport)** for PR 18159 at commit

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12519 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -502,69 +503,232 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12313 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,58 +503,63 @@ case class FindInSet(left:

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12268 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -746,10 +751,6 @@ public void trim() { @Test

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12329 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,58 +503,63 @@ case class FindInSet(left:

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12347 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -578,39 +583,29 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1105,19 +1105,26 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12233 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -511,7 +511,7 @@ public UTF8String trim() { }

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12208 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2658,17 +2658,17 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-03 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r12222 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2658,17 +2658,17 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77708/testReport)** for PR 18159 at commit

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77707/testReport)** for PR 18159 at commit

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-06-03 Thread kevinyu98
Github user kevinyu98 commented on the issue: https://github.com/apache/spark/pull/12646 @wzhfy Hello Zhenhua, can you help take a look at updated codes? thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #18159: [SPARK-20703][SQL] Associate metrics with data wr...

2017-06-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r11871 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -17,38 +17,97 @@ package

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18159 can you also post some screenshots? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18159: [SPARK-20703][SQL] Associate metrics with data wr...

2017-06-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r11816 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -17,38 +17,97 @@ package

[GitHub] spark issue #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastable to fo...

2017-06-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18189 I found this problem when I was playing with CBO stuff. This name(`isBroadcastable`) will be displayed with the query plan when users run `EXPLAIN COST`, that's why I think it matters. --- If

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-03 Thread zhengcanbin
Github user zhengcanbin commented on the issue: https://github.com/apache/spark/pull/18192 @heary-cao Tks, and what title you suggest and which comment format is correct ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77706/ Test PASSed. ---

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77706/testReport)** for PR 18128 at commit

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77706/testReport)** for PR 18128 at commit

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/18128 @felixcheung if I remove `as.integer`, backend doesn't recognize it as `integer`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-06-03 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r119996472 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -95,7 +93,123 @@ class TypedAverage[IN](val f: IN

[GitHub] spark issue #17969: [SPARK-20729][SPARKR][ML] Reduce boilerplate in Spark ML...

2017-06-03 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17969 Not a problem. It is just easier to reopen this in a future, than resolving ongoing conflicts. This is mostly deletions, but covers large part of the API, and even with recursive + patience git

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18148 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77704/ Test PASSed. ---

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18148 **[Test build #77704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77704/testReport)** for PR 18148 at commit

[GitHub] spark pull request #18128: [SPARK-20906][SparkR]:Constrained Logistic Regres...

2017-06-03 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18128#discussion_r119995950 --- Diff: R/pkg/R/mllib_classification.R --- @@ -239,21 +253,64 @@ function(object, path, overwrite = FALSE) { setMethod("spark.logit",

[GitHub] spark issue #17969: [SPARK-20729][SPARKR][ML] Reduce boilerplate in Spark ML...

2017-06-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17969 @zero323 I think folks are generally very busy these 2 weeks for various reasons ;) I'd suggest revisiting this in a couple of weeks. --- If your project is set up for it, you can reply to

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to flip adjacent...

2017-06-03 Thread ptkool
Github user ptkool commented on the issue: https://github.com/apache/spark/pull/17899 @hvanhovell @gatorsmile Can you have another look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #17969: [SPARK-20729][SPARKR][ML] Reduce boilerplate in S...

2017-06-03 Thread zero323
Github user zero323 closed the pull request at: https://github.com/apache/spark/pull/17969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17969: [SPARK-20729][SPARKR][ML] Reduce boilerplate in Spark ML...

2017-06-03 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17969 @felixcheung I assume there is no interest in that. We can revisit this some other time I guess. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18159 hmm anyway to shorten the change? this change is a bit too big for metrics ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #18159: [SPARK-20703][SQL] Associate metrics with data wr...

2017-06-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r119995109 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -17,38 +17,97 @@ package

[GitHub] spark issue #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastable to fo...

2017-06-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18189 tbh the difference is so small that i don't think it is worth spending time here ... as pointed out it is not forceBroadcast either. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/18128 Local test passed. Let me check it tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17922: [SPARK-20601][PYTHON][ML] Python API Changes for Constra...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17922 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17922: [SPARK-20601][PYTHON][ML] Python API Changes for Constra...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17922 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77705/ Test PASSed. ---

[GitHub] spark issue #17922: [SPARK-20601][PYTHON][ML] Python API Changes for Constra...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17922 **[Test build #77705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77705/testReport)** for PR 17922 at commit

[GitHub] spark issue #18052: [SPARK-20347][PYSPARK][WIP] Provide AsyncRDDActions in P...

2017-06-03 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/18052 __Note__: [Waiting for some feedback](https://twitter.com/holdenkarau/status/866672579318337537). --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17922: [SPARK-20601][PYTHON][ML] Python API Changes for Constra...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17922 **[Test build #77705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77705/testReport)** for PR 17922 at commit

[GitHub] spark issue #17922: [SPARK-20601][PYTHON][ML] Python API Changes for Constra...

2017-06-03 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17922 Sure @yanboliang. Give me a sec. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18066: [SPARK-20822][SQL] Generate code to build table cache us...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18066 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77702/ Test PASSed. ---

[GitHub] spark issue #18066: [SPARK-20822][SQL] Generate code to build table cache us...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18066 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18066: [SPARK-20822][SQL] Generate code to build table cache us...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18066 **[Test build #77702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77702/testReport)** for PR 18066 at commit

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18148 **[Test build #77704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77704/testReport)** for PR 18148 at commit

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18148 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18148 Fun, but probably unrelated: ``` # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x7f115a81f0e9, pid=125279, tid=139711419225856

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-03 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r119992981 --- Diff: python/pyspark/ml/tests.py --- @@ -819,6 +847,84 @@ def logistic_regression_check_thresholds(self): LogisticRegression,

[GitHub] spark issue #17094: [SPARK-19762][ML] Hierarchy for consolidating ML aggrega...

2017-06-03 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/17094 @srowen Speaking for myself, I think the other concerns can be issued as follow ups, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18046: [SPARK-20749][SQL] Built-in SQL Function Support - all v...

2017-06-03 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18046 ping @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18128 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77703/ Test FAILed. ---

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77703/testReport)** for PR 18128 at commit

[GitHub] spark issue #18066: [SPARK-20822][SQL] Generate code to build table cache us...

2017-06-03 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18066 ping @hvanhovell @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18128 **[Test build #77703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77703/testReport)** for PR 18128 at commit

[GitHub] spark issue #18128: [SPARK-20906][SparkR]:Constrained Logistic Regression fo...

2017-06-03 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/18128 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18066: [SPARK-20822][SQL] Generate code to build table cache us...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18066 **[Test build #77702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77702/testReport)** for PR 18066 at commit

[GitHub] spark issue #18033: [SPARK-20807][SQL] Add compression/decompression of colu...

2017-06-03 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18033 ping @hvanhovell @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-03 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18192 Suggest modifying the title and Comment format is incorrect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17953: [SPARK-20680][SQL] Spark-sql do not support for void col...

2017-06-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17953 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17953: [SPARK-20680][SQL] Spark-sql do not support for void col...

2017-06-03 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/17953 retest this commit please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18192 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort...

2017-06-03 Thread zhengcanbin
GitHub user zhengcanbin opened a pull request: https://github.com/apache/spark/pull/18192 [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from SortShuffleWri… …ter to SortShuffleManager ## What changes were proposed in this pull request? You can merge this pull

[GitHub] spark issue #18174: [SPARK-20950][CORE]Improve diskWriteBufferSize configura...

2017-06-03 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18174 @srowen yes, you're right, It's time, and their unit is MS. the numbers Is the average time of 10 times running` forceSorterToSpill`. I assume big buffer copies time consuming longer

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18029 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77701/ Test FAILed. ---

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18029 **[Test build #77701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77701/testReport)** for PR 18029 at commit

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18029 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18029 **[Test build #77701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77701/testReport)** for PR 18029 at commit

[GitHub] spark issue #18171: [SPARK-20945] Fix TID key not found in TaskSchedulerImpl

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18171 **[Test build #3775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3775/testReport)** for PR 18171 at commit

[GitHub] spark issue #18186: [SPARK-20966][WEB-UI][SQL]Table data is not sorted by st...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18186 **[Test build #3774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3774/testReport)** for PR 18186 at commit

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18029 **[Test build #77700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77700/testReport)** for PR 18029 at commit

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18029 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77700/ Test FAILed. ---

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18029 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18029: [SPARK-20168][WIP][DStream] Add changes to use kinesis f...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18029 **[Test build #77700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77700/testReport)** for PR 18029 at commit

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-03 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r119984045 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -38,6 +40,7 @@ private[kinesis] class

[GitHub] spark pull request #17759: [DOCS] Fix a typo in Encoder.clsTag

2017-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17759 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17759: [DOCS] Fix a typo in Encoder.clsTag

2017-06-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17759 Merged this to close it, but we'd generally discourage this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18186: [SPARK-20966][WEB-UI][SQL]Table data is not sorted by st...

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18186 **[Test build #3774 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3774/testReport)** for PR 18186 at commit

[GitHub] spark issue #18171: [SPARK-20945] Fix TID key not found in TaskSchedulerImpl

2017-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18171 **[Test build #3775 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3775/testReport)** for PR 18171 at commit

[GitHub] spark pull request #18186: [SPARK-20966][WEB-UI][SQL]Table data is not sorte...

2017-06-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18186#discussion_r119982964 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala --- @@ -147,42 +147,6 @@ private[ui]

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2017-06-03 Thread lianhuiwang
Github user lianhuiwang commented on the issue: https://github.com/apache/spark/pull/13373 @cloud-fan I do not think that PruneFileSourcePartitions rule is for Hive's CatalogRelation. example in this PR with master branch cannot get expected result. So i will update it with the

[GitHub] spark issue #18174: [SPARK-20950][CORE]Improve diskWriteBufferSize configura...

2017-06-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18174 There's no description of your test or what the numbers mean. I assume they're times. Why would a smaller buffer be faster? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request #18158: [SPARK-20936][CORE]Lack of an important case abou...

2017-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17094: [SPARK-19762][ML] Hierarchy for consolidating ML aggrega...

2017-06-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17094 @sethah @MLnick am I reading right that this can be merged as a step forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18158: [SPARK-20936][CORE]Lack of an important case about the t...

2017-06-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18158 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #18188: [SPARK-20790] [MLlib] Remove extraneous logging i...

2017-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18188: [SPARK-20790] [MLlib] Remove extraneous logging in test

2017-06-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18188 Merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #12894: [SPARK-15117][SQL][WIP] Generate Java code that gets a v...

2017-06-03 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/12894 @HyukjinKwon Thank you for pointing out this. This PR will be replaced with https://issues.apache.org/jira/browse/SPARK-20823 --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request #12894: [SPARK-15117][SQL][WIP] Generate Java code that g...

2017-06-03 Thread kiszk
Github user kiszk closed the pull request at: https://github.com/apache/spark/pull/12894 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18174: [SPARK-20950][CORE]Improve diskWriteBufferSize configura...

2017-06-03 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18174 @srowen thanks for review it. In our performance tuning, find the row of record the size of more than 2M. so need to initialSerBufferSize configurable. but Change `initialSerBufferSize

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-03 Thread rezasafi
Github user rezasafi commented on the issue: https://github.com/apache/spark/pull/18148 Not clear why the tests were failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] Add fill functions fo...

2017-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is