[GitHub] spark issue #19607: [SPARK-22395][SQL][PYTHON] Fix the behavior of timestamp...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #83205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83205/testReport)** for PR 19607 at commit

[GitHub] spark pull request #19607: [SPARK-22395][SQL][PYTHON] Fix the behavior of ti...

2017-10-29 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/19607 [SPARK-22395][SQL][PYTHON] Fix the behavior of timestamp values for Pandas to respect session timezone ## What changes were proposed in this pull request? When converting Pandas

[GitHub] spark pull request #19605: [SPARK-22394] [SQL] Remove redundant synchronizat...

2017-10-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19605#discussion_r147619876 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -89,10 +89,12 @@ private[spark] class

[GitHub] spark issue #18805: [SPARK-19112][CORE] Support for ZStandard codec

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18805 **[Test build #83204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83204/testReport)** for PR 18805 at commit

[GitHub] spark pull request #18805: [SPARK-19112][CORE] Support for ZStandard codec

2017-10-29 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/18805#discussion_r147618796 --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala --- @@ -216,3 +218,33 @@ private final class SnappyOutputStreamWrapper(os:

[GitHub] spark issue #19605: [SPARK-22394] [SQL] Remove redundant synchronization for...

2017-10-29 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/19605 cc @cloud-fan @rxin @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83201/ Test PASSed. ---

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19604 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19604 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19604 **[Test build #83201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83201/testReport)** for PR 19604 at commit

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19604 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83200/ Test PASSed. ---

[GitHub] spark issue #19604: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19604 **[Test build #83200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83200/testReport)** for PR 19604 at commit

[GitHub] spark issue #19605: [SPARK-22394] [SQL] Remove redundant synchronization for...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19605 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83202/ Test PASSed. ---

[GitHub] spark issue #19605: [SPARK-22394] [SQL] Remove redundant synchronization for...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19605 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19605: [SPARK-22394] [SQL] Remove redundant synchronization for...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19605 **[Test build #83202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83202/testReport)** for PR 19605 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83199/ Test PASSed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83199/testReport)** for PR 19599 at commit

[GitHub] spark issue #19606: [SPARK-22333][SQL][Backport-2.2]timeFunctionCall(CURRENT...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19606 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19606: [SPARK-22333][SQL][Backport-2.2]timeFunctionCall(...

2017-10-29 Thread DonnyZone
GitHub user DonnyZone opened a pull request: https://github.com/apache/spark/pull/19606 [SPARK-22333][SQL][Backport-2.2]timeFunctionCall(CURRENT_DATE, CURRENT_TIMESTAMP) has conflicts with columnReference ## What changes were proposed in this pull request? This is a

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18833 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83203/ Test PASSed. ---

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18833 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18833 **[Test build #83203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83203/testReport)** for PR 18833 at commit

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

2017-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19595 Thank you @ueshin. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18833: [SPARK-21625][SQL] sqrt(negative number) should be null.

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18833 **[Test build #83203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83203/testReport)** for PR 18833 at commit

[GitHub] spark pull request #19595: [SPARK-22379][PYTHON] Reduce duplication setUpCla...

2017-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19595 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

2017-10-29 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19595 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

2017-10-29 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19595 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error when trans...

2017-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19604 Ah, let's remove `[FOLLOWUP]` or replace it to something like `[BRANCH-2.2]` in the PR title. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19559: [SPARK-22333][SQL]timeFunctionCall(CURRENT_DATE, CURRENT...

2017-10-29 Thread DonnyZone
Github user DonnyZone commented on the issue: https://github.com/apache/spark/pull/19559 Sure, I will submit it later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19596 Thanks, @viirya. I wasn't sure if I should add it to the list. My intention was .. this one is like `DataFrameReader` and `DataFrameWriter` (supposed to be used via `spark.read`) and I wanted

[GitHub] spark issue #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error when trans...

2017-10-29 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/19604 I found in this branch the Docker-based integration will fail due to can not pull the image `wnameless/oracle-xe-11g:14.04.4`, should we move on to `wnameless/oracle-xe-11g`? ``` Error

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19589 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR test...

2017-10-29 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/19589 Merging to master, branch-2.2 and branch-2.1 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19605: [SPARK-22394] [SQL] Remove redundant synchronization for...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19605 **[Test build #83202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83202/testReport)** for PR 19605 at commit

[GitHub] spark pull request #19605: [SPARK-22394] [SQL] Remove redundant synchronizat...

2017-10-29 Thread wzhfy
GitHub user wzhfy opened a pull request: https://github.com/apache/spark/pull/19605 [SPARK-22394] [SQL] Remove redundant synchronization for metastore access ## What changes were proposed in this pull request? Before Spark 2.x, synchronization for metastore access was

[GitHub] spark issue #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error when trans...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19604 **[Test build #83201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83201/testReport)** for PR 19604 at commit

[GitHub] spark pull request #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error whe...

2017-10-29 Thread jmchung
Github user jmchung commented on a diff in the pull request: https://github.com/apache/spark/pull/19604#discussion_r147605119 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -440,8 +440,9 @@ object JdbcUtils extends Logging

[GitHub] spark pull request #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error whe...

2017-10-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19604#discussion_r147604947 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -440,8 +440,9 @@ object JdbcUtils extends Logging

[GitHub] spark issue #19520: [SPARK-22298][WEB-UI] url encode APP id before generatin...

2017-10-29 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19520 I would like to ask, under what circumstances the application id will contain a forward slash? --- - To unsubscribe,

[GitHub] spark issue #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error when trans...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19604 **[Test build #83200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83200/testReport)** for PR 19604 at commit

[GitHub] spark issue #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error when trans...

2017-10-29 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/19604 cc @cloud-fan, the follow-up PR for 2.2, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error whe...

2017-10-29 Thread jmchung
GitHub user jmchung opened a pull request: https://github.com/apache/spark/pull/19604 [SPARK-22291][SQL][FOLLOWUP] Conversion error when transforming array types of uuid, inet and cidr to StingType in PostgreSQL … types of uuid, inet and cidr to StingType in PostgreSQL

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19596 I've generated the Python docs. Looks good. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19507: [WEB-UI] Add count in fair scheduler pool page

2017-10-29 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19507 @srowen Help review the code. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19532: [CORE]Modify the duration real-time calculation and upda...

2017-10-29 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19532 @jiangxb1987 @srowen Help review the code. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19596 Don't we like to add it to the list of `Important classes of Spark SQL and DataFrames`? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

2017-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19595 cc @ueshin, could you take a look please when you have some time? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19596: [SPARK-22369][PYTHON][DOCS] Exposes catalog API document...

2017-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19596 cc @holdenk and @viirya, mind taking a look please? I remember I had few talks about Sphinx and `__all__` and I believe you guys are right reviewers. ---

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-10-29 Thread setjet
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 Hi, it has been a while but I can pick it back up when I have time next weekend or so if that's OK. --- - To unsubscribe,

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83199/testReport)** for PR 19599 at commit

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83198/ Test PASSed. ---

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83198/testReport)** for PR 19553 at commit

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r147596592 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala --- @@ -43,10 +43,17 @@ private[spark] object JavaUtils { override

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19603 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83197/ Test PASSed. ---

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19603 **[Test build #83197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83197/testReport)** for PR 19603 at commit

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r147593655 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala --- @@ -43,10 +43,17 @@ private[spark] object JavaUtils { override def

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r147593724 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala --- @@ -43,10 +43,17 @@ private[spark] object JavaUtils { override def

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83196/ Test PASSed. ---

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19603 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19603 **[Test build #83196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83196/testReport)** for PR 19603 at commit

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread Whoosh
Github user Whoosh commented on the issue: https://github.com/apache/spark/pull/19553 @cloud-fan I've checked all core tests, it was fine, should I do smt in addition to? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83198/testReport)** for PR 19553 at commit

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-29 Thread Whoosh
Github user Whoosh commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r147591080 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala --- @@ -43,10 +43,15 @@ private[spark] object JavaUtils { override def

[GitHub] spark issue #19571: [SPARK-15474][SQL] Write and read back non-emtpy schema ...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19571 yes please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19571: [SPARK-15474][SQL] Write and read back non-emtpy schema ...

2017-10-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19571 I see. Then, can we continue on #17980 ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19603 **[Test build #83197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83197/testReport)** for PR 19603 at commit

[GitHub] spark pull request #19593: [WIP][SPARK-22374][SQL][2.2] closeAllForUGI is re...

2017-10-29 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/19593 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19593: [WIP][SPARK-22374][SQL][2.2] closeAllForUGI is required ...

2017-10-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19593 Thank you for review, @vanzin . Sorry, I'll close this PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-10-29 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19601 After I think about the choice for a while, I conclude that it is better to add the new `WritableColumnVector` (i.e. `UnsafeColumnVector`) and to keep the current `ColumnVector.Array`. I think

[GitHub] spark pull request #19603: [SPARK-22385][SQL] MapObjects should not access l...

2017-10-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19603#discussion_r147589361 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -591,18 +591,40 @@ case class MapObjects

[GitHub] spark pull request #19603: [SPARK-22385][SQL] MapObjects should not access l...

2017-10-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19603#discussion_r147589355 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -591,6 +591,9 @@ case class MapObjects private(

[GitHub] spark issue #19529: [SPARK-22308] Support alternative unit testing styles in...

2017-10-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19529 I just reverted this PR. @nkronenfeld Could you submit another PR and update the title to `[SPARK-22308][test-maven] Support alternative unit testing styles in external applications`?

[GitHub] spark issue #19603: [SPARK-22385][SQL] MapObjects should not access list ele...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19603 **[Test build #83196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83196/testReport)** for PR 19603 at commit

[GitHub] spark pull request #19603: [SPARK-22385][SQL] MapObjects should not access l...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19603#discussion_r147587911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -591,18 +591,40 @@ case class MapObjects

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19567 @jmchung can you send a new PR for 2.2? thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19567: [SPARK-22291][SQL] Conversion error when transfor...

2017-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19567 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19567 the last commit just change the test name and shouldn't break pyspark tests, I'm merging to master, thanks! --- - To

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147587396 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -17,47 +17,168 @@ package

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2017-10-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147587392 --- Diff: common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java --- @@ -38,6 +39,10 @@ public static int hashLong(long

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83195/ Test FAILed. ---

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19567 **[Test build #83195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83195/testReport)** for PR 19567 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83192/ Test PASSed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #83192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83192/testReport)** for PR 19222 at commit

[GitHub] spark issue #11403: [SPARK-13523] [SQL] Reuse exchanges in a query

2017-10-29 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/11403 @davies Hi, what do you mean by "Since all the planner only work with tree, so this rule should be the last one for the entire planning."? Thanks if you have time. ---

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to transpose adj...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17899 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83194/ Test PASSed. ---

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to transpose adj...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to transpose adj...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17899 **[Test build #83194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83194/testReport)** for PR 17899 at commit

[GitHub] spark issue #19600: Added more information to Imputer

2017-10-29 Thread tengpeng
Github user tengpeng commented on the issue: https://github.com/apache/spark/pull/19600 I will follow the guideline strictly next time. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83190/ Test PASSed. ---

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19567 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19567: [SPARK-22291][SQL] Conversion error when transforming ar...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19567 **[Test build #83190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83190/testReport)** for PR 19567 at commit

[GitHub] spark issue #19602: [SPARK-22384][SQL] Refine partition pruning when attribu...

2017-10-29 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/19602 @gatorsmile Thanks again for review this pr. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

  1   2   3   >