[GitHub] spark pull request #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite I...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22461 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22461 Thanks! Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22593: [Streaming][DOC] Fix typo & format in DataStreamW...

2018-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22593#discussion_r221497310 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -46,14 +46,16 @@ final class DataStreamWriter[T]

[GitHub] spark issue #22573: [SPARK-25558][SQL] Pushdown predicates for nested fields...

2018-09-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22573 That's great! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22582 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22573: [SPARK-25558][SQL] Pushdown predicates for nested fields...

2018-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22573 Updating `Filter` APIs sounds reasonable to me. This should be part of our data source API v2. cc @cloud-fan @rxin @rdblue ---

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96807/ Test PASSed. ---

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22524 **[Test build #96807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96807/testReport)** for PR 22524 at commit

[GitHub] spark issue #22597: [SPARK-25579][SQL] Use quoted attribute names if needed ...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22597 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22597: [SPARK-25579][SQL] Use quoted attribute names if needed ...

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22597 **[Test build #96810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96810/testReport)** for PR 22597 at commit

[GitHub] spark issue #22597: [SPARK-25579][SQL] Use quoted attribute names if needed ...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22597 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22597: [SPARK-25579][SQL] Use quoted attribute names if ...

2018-09-30 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22597 [SPARK-25579][SQL] Use quoted attribute names if needed in pushed ORC predicates ## What changes were proposed in this pull request? This PR aims to fix an ORC performance

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22596 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96808/ Test PASSed. ---

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22596 **[Test build #96808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96808/testReport)** for PR 22596 at commit

[GitHub] spark issue #22527: [SPARK-17952][SQL] Nested Java beans support in createDa...

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22527 **[Test build #96809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96809/testReport)** for PR 22527 at commit

[GitHub] spark issue #22527: [SPARK-17952][SQL] Nested Java beans support in createDa...

2018-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22527 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22596 Can you link the JIRA https://issues.apache.org/jira/browse/SPARK-25576 ? Please see https://spark.apache.org/contributing.html ---

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22596 **[Test build #96808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96808/testReport)** for PR 22596 at commit

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22596 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22539: [SPARK-25517][SQL] Detect/Infer date type in CSV file

2018-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22539 Looks https://github.com/apache/spark/pull/21363 getting inactive. Can you take this over instead? You can pick up the commits there and open another PR. ---

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22524 **[Test build #96807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96807/testReport)** for PR 22524 at commit

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22573: [SPARK-25558][SQL] Pushdown predicates for nested fields...

2018-09-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22573 Can we update public `Filter` API in Spark 3.0.0? @cloud-fan and @gatorsmile . --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22573: [SPARK-25558][SQL] Pushdown predicates for nested...

2018-09-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22573#discussion_r221477177 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -437,53 +436,65 @@ object

[GitHub] spark pull request #22573: [SPARK-25558][SQL] Pushdown predicates for nested...

2018-09-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22573#discussion_r221476951 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -437,53 +436,65 @@ object

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-09-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/22138 Kindly ask for reviewing. Please never mind when you're busy with fixing bugs on Spark 2.4 RC. @gaborgsomogyi I guess I left two things for committer decision: 1. define soft boundary

[GitHub] spark pull request #22565: [SPARK-25543][K8S] Print debug message iff execId...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22565 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22565: [SPARK-25543][K8S] Print debug message iff execIdsRemove...

2018-09-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22565 Merged to master/branch-2.4. Thank you, @ScrapCodes and @liyinan926 . --- - To unsubscribe, e-mail:

[GitHub] spark issue #19410: [SPARK-22184][CORE][GRAPHX] GraphX fails in case of insu...

2018-09-30 Thread szhem
Github user szhem commented on the issue: https://github.com/apache/spark/pull/19410 Hello @mallman, @sujithjay, @felixcheung, @jkbradley, @mengxr, it's already about a year passed since this pull request has been opened. I'm just wondering whether there is any chance to get any

[GitHub] spark issue #19373: [SPARK-22150][CORE] PeriodicCheckpointer fails in case o...

2018-09-30 Thread szhem
Github user szhem commented on the issue: https://github.com/apache/spark/pull/19373 Hello @sujithjay, @felixcheung, @jkbradley, @mengxr, it's already more than a year passed since this pull request has been opened. I'm just wondering whether there is any chance for this PR to be

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21221 @mccheah When you merged the code, could you also leave the comments about which branches you did the merge? --- - To

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-09-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21221 For the other reviewers, this was merged to master (not 2.4) --- - To unsubscribe, e-mail:

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22596 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22596 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22596: Fix lint failure in 2.2

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22596 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22596: Fix lint failure in 2.2

2018-09-30 Thread samdvr
GitHub user samdvr opened a pull request: https://github.com/apache/spark/pull/22596 Fix lint failure in 2.2 ## What changes were proposed in this pull request? Line length fixes and ## How was this patch tested? Manually verified, but will ensure

[GitHub] spark issue #22539: [SPARK-25517][SQL] Detect/Infer date type in CSV file

2018-09-30 Thread softmanu
Github user softmanu commented on the issue: https://github.com/apache/spark/pull/22539 @dongjoon-hyun @HyukjinKwon Hi, i was not well whole last week, now I am back, so yes, thanks for reviewing and all the comments. whether my PR is a duplicate or not we can see out later,

[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-30 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22592 Thank you @srowen . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22577: [CORE][MINOR] Fix obvious error and compiling for...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22577 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-30 Thread suryag10
Github user suryag10 commented on the issue: https://github.com/apache/spark/pull/21669 > like it, but we could also first support cluster mode and add client mode after. Thats the reason i said "Point to note":)- ---

[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...

2018-09-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22577 Merged to master/2.4/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22594: [MINOR][SQL] When batch reading, the number of bytes can...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22594 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22594: [MINOR][SQL] When batch reading, the number of bytes can...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22594 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96806/ Test PASSed. ---

[GitHub] spark issue #22594: [MINOR][SQL] When batch reading, the number of bytes can...

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22594 **[Test build #96806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96806/testReport)** for PR 22594 at commit

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 If this PR could be merged, #22578 could be added as an additional column as well. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 Gently ping @jerryshao @cloud-fan . Do you have a chance to review? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22595: [SPARK-25577][Web UI] Add an on-off switch to dis...

2018-09-30 Thread LantaoJin
GitHub user LantaoJin opened a pull request: https://github.com/apache/spark/pull/22595 [SPARK-25577][Web UI] Add an on-off switch to display the executor additional columns ## What changes were proposed in this pull request?

[GitHub] spark issue #22594: [MINOR][SQL] When batch reading, the number of bytes can...

2018-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22594 **[Test build #96806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96806/testReport)** for PR 22594 at commit

[GitHub] spark issue #22594: [MINOR][SQL] When batch reading, the number of bytes can...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22594 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22594: [MINOR][SQL] When batch reading, the number of bytes can...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22594 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22594: [MINOR][SQL] When batch reading, the number of by...

2018-09-30 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/22594 [MINOR][SQL] When batch reading, the number of bytes can not be updated as expected. ## What changes were proposed in this pull request? When batch reading, the number of bytes can not

[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22581 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22379#discussion_r221449056 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -520,7 +520,10 @@ object FunctionRegistry {

[GitHub] spark issue #22581: [SPARK-25565][BUILD] Add scalastyle rule to check add Lo...

2018-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22581 Thanks for reviewing this @srowen and @wangyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22581: [SPARK-25565][BUILD] Add scalastyle rule to check add Lo...

2018-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22581 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-30 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22592 Thank you for the review @ajbozarth . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional