Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/22847
Just in case people wonder, the following is the hack patch that I used for
stress testing code splitting before this PR:
```diff
---
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229943260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/19927
@srowen How do you think about this? Current OVR model's transform is too
slow. Thanks.
---
-
To unsubscribe, e-mail:
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229942325
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22087
@imatiach-msft Updated according to your comments! Thanks for your
reviewing!
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22898
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22898
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98345/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22626
This needs to be rebased.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98345/testReport)**
for PR 22087 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22914
> May be we can highlight above the table, that "Invalid page number,
falling back to first page"
Yes, that's what I mean.
No big deal but falling back to the first page seems
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98344/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98344/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98343/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22908
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22908
**[Test build #98343 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98343/testReport)**
for PR 22908 at commit
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
The current behavior is, If we enter a value more than the maximum page
number, the page navigation bar shows the user is in first page and throws an
exception. So, if we really want to throw
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22912
cc @jiangxb1987 and @mengxr
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22905#discussion_r229933689
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ColumnarFileFormat.scala
---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22905#discussion_r229933544
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -306,7 +306,15 @@ case class FileSourceScanExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22905#discussion_r229932838
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ColumnarFileFormat.scala
---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22905#discussion_r229932338
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ColumnarFileFormat.scala
---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22914
I prefer to just highlight the invalid output. E.g.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22905#discussion_r229932234
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ColumnarFileFormat.scala
---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user WenqianZhao commented on the issue:
https://github.com/apache/spark/pull/20899
> @WenqianZhao I think the point of sending deltas instead of absolute
ranks was that, as parts of the graph converge, their deltas would go to zero.
GraphX would then be able to compress those
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98345/testReport)**
for PR 22087 at commit
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
@gengliangwang IMHO, We should try to avoid exceptions in the WEBUI.
User will come to know which page he is, from the page navigation bar.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98344/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98342/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #98342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98342/testReport)**
for PR 19045 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22892
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229919857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22892
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22847
@rednaxelafx ah good point! It's hardcoded as 1024 too, and it's also doing
method splitting. Let's apply the config there too.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22912
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98341/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22912
**[Test build #98341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98341/testReport)**
for PR 22912 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22912
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98340/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22912
**[Test build #98340 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98340/testReport)**
for PR 22912 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22918
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21860
thanks, @cloud-fan, @maropu, @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22918
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22666
Argh, sorry, it was my mistake.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22918
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/22918
[SPARK-25902][SQL]Change AttributeReference.withMetadata's return type to
AttributeReference
## What changes were proposed in this pull request?
Currently the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22666
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22666
Ah no I am sorry @MaxGekk. I made the primary author as me mistakenly.
I showed my email first.
```
=== Pull Request #22666 ===
title [SPARK-25672][SQL]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #4400 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4400/testReport)**
for PR 22914 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22666
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22845
thanks,@dongjoon-hyum
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22908
**[Test build #98343 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98343/testReport)**
for PR 22908 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22908
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98336/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22626
**[Test build #98336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98336/testReport)**
for PR 22626 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22860
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22897
@mccheah @liyinan926
(I'm kinda assuming you guys monitor github / jira instead of relying on
pings.)
---
-
To
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22917
The title seems to describe the problem, can you describe the solution
instead?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22901
Late LGTM!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22883
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98331/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22883
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22883
**[Test build #98331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98331/testReport)**
for PR 22883 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22910
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4688/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4688/
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22910
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #98342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98342/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22883
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98329/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22883
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22883
**[Test build #98329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98329/testReport)**
for PR 22883 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22910
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98328/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22910
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22910
**[Test build #98328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98328/testReport)**
for PR 22910 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229879855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user yogeshg commented on the issue:
https://github.com/apache/spark/pull/22912
In an offline discussion with @MrBago , we noted that there's at most as
many (non-cancelled) `timerTasks` on the `timer` as there are slots. So, one
thread for managing logging is probably fine,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22912
**[Test build #98341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98341/testReport)**
for PR 22912 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22912
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22917
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22917
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22917
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22911
It is actually not needed for client mode because only the driver needs the
keytab.
But whether to store it in secrets is not a question. You either store it
in a secret or you don't
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22917
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98339/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22917
**[Test build #98339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98339/testReport)**
for PR 22917 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98324/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98327/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22909
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22909
**[Test build #98327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98327/testReport)**
for PR 22909 at commit
1 - 100 of 584 matches
Mail list logo
