Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22939#discussion_r232166370
--- Diff: R/pkg/R/functions.R ---
@@ -2230,6 +2237,32 @@ setMethod("from_json", signature(x = "Column",
schema = "characterOrstructType")
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98636/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22987
**[Test build #98636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98636/testReport)**
for PR 22987 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22955
**[Test build #98644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98644/testReport)**
for PR 22955 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22955
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232163956
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -0,0 +1,128 @@
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232163715
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -0,0 +1,128 @@
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232163787
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -0,0 +1,128 @@
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232163738
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -0,0 +1,128 @@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22990
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98638/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22990
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22990
**[Test build #98638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98638/testReport)**
for PR 22990 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22974
**[Test build #98643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98643/testReport)**
for PR 22974 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22990
**[Test build #98642 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98642/testReport)**
for PR 22990 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22990
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22990
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22966#discussion_r232155608
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/execution/benchmark/AvroReadBenchmark.scala
---
@@ -0,0 +1,226 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22966#discussion_r232155430
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/execution/benchmark/AvroReadBenchmark.scala
---
@@ -0,0 +1,226 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22973
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98639/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22973
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22973
**[Test build #98639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98639/testReport)**
for PR 22973 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22975
**[Test build #98641 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98641/testReport)**
for PR 22975 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22975
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22975
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22975
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22979
**[Test build #98640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98640/testReport)**
for PR 22979 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22973
**[Test build #98639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98639/testReport)**
for PR 22973 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98635/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22974
**[Test build #98635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98635/testReport)**
for PR 22974 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22990
good catch! LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22990#discussion_r232148751
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2856,6 +2856,59 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22990#discussion_r232148583
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2856,6 +2856,59 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22975
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22975
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98634/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22975
**[Test build #98634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98634/testReport)**
for PR 22975 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22990
**[Test build #98638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98638/testReport)**
for PR 22990 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22990
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22990
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22990
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22990
[SPARK-25988] [SQL] Keep names unchanged when deduplicating the column
names in Analyzer
## What changes were proposed in this pull request?
When the queries do not use the column names
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98633/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22987
**[Test build #98633 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98633/testReport)**
for PR 22987 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22275
ping @HyukjinKwon and @viirya to maybe take another look at the recent
changes to make this cleaner, if you are able to. Thanks!
---
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/22275#discussion_r232145973
--- Diff: python/pyspark/sql/tests.py ---
@@ -4923,6 +4923,28 @@ def test_timestamp_dst(self):
self.assertPandasEqual(pdf,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22880
Let me take a look on this weekends.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98637/testReport)**
for PR 22989 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/22989
[SPARK-25986][Build] Banning throw new OutOfMemoryErrors
## What changes were proposed in this pull request?
Add scala and java lint check rules to ban the usage of `throw new
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22966
@dongjoon-hyun I think we can merge this one first.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22976
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98632/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22976
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22976
**[Test build #98632 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98632/testReport)**
for PR 22976 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22976
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22976
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98631/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22976
**[Test build #98631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98631/testReport)**
for PR 22976 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22988
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22988
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98627/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22988
**[Test build #98627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98627/testReport)**
for PR 22988 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22987
**[Test build #98636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98636/testReport)**
for PR 22987 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22974
not all public serializable classes are needed to registered. Only those
one which needed ser-deser should be registered, one important groups should be
transformers and prediction models.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22987
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r232136609
--- Diff: sql/core/src/test/resources/sql-tests/inputs/window.sql ---
@@ -109,3 +109,9 @@ last_value(false, false) OVER w AS
last_value_contain_null
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22985
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22974
I am not sure, but maybe all serializable classes need to be registered.
Since `MultivariateGaussian` is a public class, so I think we need to add
it.
I also wonder whether a test is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98629/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22275
**[Test build #98629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98629/testReport)**
for PR 22275 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22985
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22939
Hey @felixcheung, it should be ready for another look.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r232135028
--- Diff: sql/core/src/test/resources/sql-tests/inputs/window.sql ---
@@ -109,3 +109,9 @@ last_value(false, false) OVER w AS
last_value_contain_null
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98630/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22954
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98628/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22954
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22954
**[Test build #98628 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98628/testReport)**
for PR 22954 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22275
**[Test build #98630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98630/testReport)**
for PR 22275 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22974
OK, that's the issue, yeah. Registration is an optimization. I wonder, what
other classes should we add if we're going to add this one? I don't know if it
needs a test. But if there are 10 other
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22974
Do you mean fail in this pr? It was caused by a non-registered filed
`BDM[Double]`.
`MultivariateGaussian` is used in GMM, kryo-registration should help
performance.
As to
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22974
You're requiring registration, which is what makes this fail, right? why do
that? I think I'm missing something.
---
-
To
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22974
@srowen Existing kryo-register testsuite need to import spark-core:
```
import org.apache.spark.SparkConf
import org.apache.spark.serializer.KryoSerializer
val conf = new
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22974
**[Test build #98635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98635/testReport)**
for PR 22974 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22974
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22975
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22975
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22975
@srowen Yes, we should keep user input data and column names. Thanks for
your explain!
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22975
**[Test build #98634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98634/testReport)**
for PR 22975 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22987
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 559 matches
Mail list logo
