Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99646/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99645/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99645/testReport)**
for PR 23088 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99646/testReport)**
for PR 23213 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23214
It's easy to track `numKeyLookups` at `HashedRelation`, but it's hard to
track `numProbes`. One idea is, we pass a `MutableInt` to
`LongToUnsafeRowMap.getValue` as a parameter, and in the method
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23214
I might know the root cause: `LongToUnsafeRowMap` is acutally accessed by
multiple threads.
For broadcast hash join, we will copy the broadcasted hash relation to
avoid multi-thread
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99653 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99653/testReport)**
for PR 23088 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22899
@gatorsmile Thanks a lot. I completely agree that we should try and combine
these two. I will continue to think about it :-)
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23194
**[Test build #99652 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99652/testReport)**
for PR 23194 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99649/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/23207
cc @cloud-fan @gatorsmile @rxin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23194
**[Test build #99649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99649/testReport)**
for PR 23194 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23214#discussion_r238549645
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -398,8 +399,8 @@ private[execution] final class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23214
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99648/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99648 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99648/testReport)**
for PR 23169 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99643/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23214
**[Test build #99651 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99651/testReport)**
for PR 23214 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23214
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23207
**[Test build #99643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99643/testReport)**
for PR 23207 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22899
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22899
LGTM
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22899
To be honest, we might still need to revisit it since it is still very
confusing to the developer which one they should use, top-down? or bottom-up?
The current use case for top-down is majorly
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23171
Basically logically there are only two expressions: In which handles
arbitrary expressions, and InSet which handles expressions with literals. Both
could work: (1) we provide two separate expressions
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99644/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/23171
@rxin `switch` in Java is still significantly faster than hash set even
without boxing / unboxing problems when the number of elements are small. We
were thinking about to have two implementations
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23194
**[Test build #99644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99644/testReport)**
for PR 23194 at commit
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
@adrian-wang ok~ I will add some comments to explain the reason
---
-
To unsubscribe, e-mail:
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
@JkSelf thx~
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23214
@LuciferYang the patch is fine in my test environment.
@adrian-wang I will run all the tpcds queries in spark2.3 and spark2.3
with this patch later.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22468
**[Test build #99650 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99650/testReport)**
for PR 22468 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238543369
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan @viirya #23214 maybe reslove this problem and we needn't revert
this patch.
---
-
To unsubscribe, e-mail:
Github user adrian-wang commented on the issue:
https://github.com/apache/spark/pull/23214
maybe add some detailed test result in description and explain the reason
for this in code comment?
---
-
To unsubscribe,
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
ping @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
cc @cloud-fan , help to review this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23214
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
cc @JkSelf help to check this patch.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23214
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23214
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user LuciferYang opened a pull request:
https://github.com/apache/spark/pull/23214
[SPARK-26155] Optimizing the performance of LongToUnsafeRowMap
## What changes were proposed in this pull request?
To slove @JkSelf report problem at
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99642/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22899
**[Test build #99642 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99642/testReport)**
for PR 22899 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23194
**[Test build #99649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99649/testReport)**
for PR 23194 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23171
How about, we create an `OptimizedIn`, and convert `In` to `OptimizedIn` if
the list is all literals? `OptimizedIn` will pick `switch` or hash set based on
the length of the list.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99648/testReport)**
for PR 23169 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23169
@DaveDeCaprio
You might miss to roll back change in test.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238534101
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23169
retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238533700
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238530264
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,100 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22468
**[Test build #99647 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99647/testReport)**
for PR 22468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23171
I thought InSwitch logically is the same as InSet, in which all the child
expressions are literals?
On Mon, Dec 03, 2018 at 8:38 PM, Wenchen Fan < notificati...@github.com >
wrote:
>
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23171
I think `InSet` is not an optimized version of `In`, but just a way to
separate the implementation for different conditions (the length of the list).
Maybe we should do the same thing here,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99646/testReport)**
for PR 23213 at commit
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/23213
[SPARK-26262][SQL] Run SQLQueryTestSuite with
WHOLESTAGE_CODEGEN_ENABLED=false
## What changes were proposed in this pull request?
For better test coverage, this pr set `false` at
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99645/testReport)**
for PR 23088 at commit
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23088
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23194
LGTM except for minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238526892
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -377,41 +377,41 @@ abstract class DDLSuite extends QueryTest
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99637/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22514
**[Test build #99637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99637/testReport)**
for PR 22514 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23171
That probably means we should just optimize InSet to have the switch
version though? Rather than do it in In?
On Mon, Dec 03, 2018 at 8:20 PM, Wenchen Fan < notificati...@github.com >
wrote:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23171
@rxin I proposed the same thing before, but one problem is that, we only
convert `In` to `InSet` when the length of list reaches the threshold. If the
`switch` way is faster than hash set when
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23212
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99640/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23212
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23212
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23212
**[Test build #99640 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99640/testReport)**
for PR 23212 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23208#discussion_r238524973
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/SupportsBatchWrite.java
---
@@ -25,14 +25,14 @@
import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22957#discussion_r238524763
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -145,9 +145,14 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99638/
Test PASSed.
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238524452
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #99638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99638/testReport)**
for PR 20433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99635/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 626 matches
Mail list logo
