[GitHub] viirya commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
viirya commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#discussion_r240503360 ## File path:

[GitHub] viirya commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
viirya commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446104710 I think wholeStageCodegen doesn't disallow using those objects in

[GitHub] HeartSaVioR commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
HeartSaVioR commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446103258 @vanzin Thanks for the detailed review! Addressed review comments.

[GitHub] LucaCanali commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
LucaCanali commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446102201 Thanks @vanzin for looking at this.

[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446100267 Merged build finished. Test PASSed.

[GitHub] SparkQA removed a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446096365 **[Test build #99955 has

[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446100271 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446100267 Merged build finished. Test PASSed. This is an

[GitHub] SparkQA commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446100212 **[Test build #99955 has

[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446100271 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446097111 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446097107 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446097107 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446097111 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-10 Thread GitBox
felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23072#discussion_r240491948 ## File path: R/pkg/R/mllib_clustering.R ## @@ -610,3 +616,59 @@ setMethod("write.ml", signature(object =

[GitHub] felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-10 Thread GitBox
felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23072#discussion_r240492041 ## File path: R/pkg/R/mllib_clustering.R ## @@ -610,3 +616,59 @@ setMethod("write.ml", signature(object =

[GitHub] felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-10 Thread GitBox
felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23072#discussion_r240492482 ## File path: R/pkg/R/mllib_clustering.R ## @@ -610,3 +616,59 @@ setMethod("write.ml", signature(object =

[GitHub] felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-10 Thread GitBox
felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23072#discussion_r240492887 ## File path: R/pkg/R/mllib_clustering.R ## @@ -610,3 +616,59 @@ setMethod("write.ml", signature(object =

[GitHub] SparkQA removed a comment on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446057878 **[Test build #99944 has

[GitHub] felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-10 Thread GitBox
felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23072#discussion_r240493499 ## File path: R/pkg/R/mllib_clustering.R ## @@ -610,3 +616,59 @@ setMethod("write.ml", signature(object =

[GitHub] felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-10 Thread GitBox
felixcheung commented on a change in pull request #23072: [SPARK-19827][R]spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23072#discussion_r240492789 ## File path: R/pkg/R/mllib_clustering.R ## @@ -610,3 +616,59 @@ setMethod("write.ml", signature(object =

[GitHub] SparkQA commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
SparkQA commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446096788 **[Test build #99944 has

[GitHub] SparkQA commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2018-12-10 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr URL: https://github.com/apache/spark/pull/23260#issuecomment-446096365 **[Test build #99955 has

[GitHub] AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446094075 Merged build finished. Test PASSed. This is

[GitHub] SparkQA commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-10 Thread GitBox
SparkQA commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446094215 **[Test build #99954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99954/testReport)**

[GitHub] AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446094078 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446094075 Merged build finished. Test PASSed. This is an

[GitHub] KyleLi1985 commented on a change in pull request #23271: [SPARK-26318][SQL] Enhance function merge performance in Row

2018-12-10 Thread GitBox
KyleLi1985 commented on a change in pull request #23271: [SPARK-26318][SQL] Enhance function merge performance in Row URL: https://github.com/apache/spark/pull/23271#discussion_r240491652 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@ -58,8

[GitHub] AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446094078 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] KyleLi1985 commented on a change in pull request #23271: [SPARK-26318][SQL] Enhance function merge performance in Row

2018-12-10 Thread GitBox
KyleLi1985 commented on a change in pull request #23271: [SPARK-26318][SQL] Enhance function merge performance in Row URL: https://github.com/apache/spark/pull/23271#discussion_r240491672 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@ -58,8

[GitHub] HyukjinKwon commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
HyukjinKwon commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#discussion_r240489089 ## File path:

[GitHub] HyukjinKwon commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
HyukjinKwon commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#discussion_r240488920 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446090350 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446090350 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446090346 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446090346 Merged build finished. Test PASSed.

[GitHub] SparkQA removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446057021 **[Test build #99943 has

[GitHub] SparkQA commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
SparkQA commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-44608 **[Test build #99943 has

[GitHub] cloud-fan commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
cloud-fan commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446089670 when wholeStageCogen is on, there is no way to avoid codegen, so

[GitHub] HyukjinKwon edited a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
HyukjinKwon edited a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446088412 Ah, I had the same question as

[GitHub] HyukjinKwon commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
HyukjinKwon commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446088412 Ah, I had the same question as

[GitHub] cloud-fan commented on issue #23248: [SPARK-26293][SQL] Cast exception when having python udf in subquery

2018-12-10 Thread GitBox
cloud-fan commented on issue #23248: [SPARK-26293][SQL] Cast exception when having python udf in subquery URL: https://github.com/apache/spark/pull/23248#issuecomment-446086659 thanks, merging to master/2.4! This is an

[GitHub] AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446086294 Test PASSed. Refer to this link for build results (access

[GitHub] asfgit closed pull request #23248: [SPARK-26293][SQL] Cast exception when having python udf in subquery

2018-12-10 Thread GitBox
asfgit closed pull request #23248: [SPARK-26293][SQL] Cast exception when having python udf in subquery URL: https://github.com/apache/spark/pull/23248 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446086294 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446086290 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446086290 Merged build finished. Test PASSed.

[GitHub] SparkQA removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446081233 **[Test build #99950 has

[GitHub] SparkQA commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
SparkQA commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446086071 **[Test build #99950 has

[GitHub] dongjoon-hyun commented on a change in pull request #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB URL: https://github.com/apache/spark/pull/23243#discussion_r240483099 ## File path: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala

[GitHub] AmplabJenkins removed a comment on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#issuecomment-446084116 Merged build finished. Test PASSed. This

[GitHub] AmplabJenkins removed a comment on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#issuecomment-446084120 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#issuecomment-446084120 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#issuecomment-446084116 Merged build finished. Test PASSed. This is an

[GitHub] SparkQA commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
SparkQA commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#issuecomment-446084058 **[Test build #99953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99953/testReport)**

[GitHub] dongjoon-hyun commented on a change in pull request #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB URL: https://github.com/apache/spark/pull/23243#discussion_r240482510 ## File path: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala

[GitHub] dongjoon-hyun commented on a change in pull request #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB URL: https://github.com/apache/spark/pull/23243#discussion_r240482510 ## File path: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala

[GitHub] AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446083193 Merged build finished. Test PASSed.

[GitHub] dongjoon-hyun commented on issue #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB

2018-12-10 Thread GitBox
dongjoon-hyun commented on issue #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB URL: https://github.com/apache/spark/pull/23243#issuecomment-446083308 Hi, @weixiuli . You can use `[CORE]` instead of `[ExternalShuffleService]`.

[GitHub] dongjoon-hyun edited a comment on issue #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB

2018-12-10 Thread GitBox
dongjoon-hyun edited a comment on issue #23243: [SPARK-26288][ExternalShuffleService]add initRegisteredExecutorsDB URL: https://github.com/apache/spark/pull/23243#issuecomment-446083308 Hi, @weixiuli . You can use `[CORE]` instead of `[ExternalShuffleService]` in the PR title.

[GitHub] AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446083198 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446083193 Merged build finished. Test PASSed.

[GitHub] HyukjinKwon commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
HyukjinKwon commented on issue #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#issuecomment-446083244 retest this please This is an automated message

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446083128 Test PASSed. Refer to this link for build results (access rights

[GitHub] SparkQA commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
SparkQA commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446083119 **[Test build #99951 has

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446083121 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446083128 Test PASSed. Refer to this link for build results

[GitHub] SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446083138 **[Test build #99952 has

[GitHub] AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446083198 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446083121 Merged build finished. Test PASSed.

[GitHub] HyukjinKwon commented on issue #23271: [SPARK-26318][SQL] Enhance function merge performance in Row

2018-12-10 Thread GitBox
HyukjinKwon commented on issue #23271: [SPARK-26318][SQL] Enhance function merge performance in Row URL: https://github.com/apache/spark/pull/23271#issuecomment-446082473 +1 for deprecation. This is an automated message from

[GitHub] AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446082207 Merged build finished. Test PASSed. This

[GitHub] AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446082209 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes. URL: https://github.com/apache/spark/pull/23280#discussion_r240481288 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala ##

[GitHub] JkSelf commented on a change in pull request #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
JkSelf commented on a change in pull request #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#discussion_r240481284 ## File path:

[GitHub] AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446082207 Merged build finished. Test PASSed. This is an

[GitHub] AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446082209 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446081262 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446081265 Test PASSed. Refer to this link for build results (access

[GitHub] HyukjinKwon commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
HyukjinKwon commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446081444 Looks fine to me This is an automated

[GitHub] AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446081262 Merged build finished. Test PASSed.

[GitHub] CarolinePeng commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.

2018-12-10 Thread GitBox
CarolinePeng commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes. URL: https://github.com/apache/spark/pull/23280#discussion_r240480174 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala ## @@

[GitHub] SparkQA commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
SparkQA commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446081221 **[Test build #99949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99949/testReport)**

[GitHub] SparkQA commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
SparkQA commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446081233 **[Test build #99950 has

[GitHub] AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446081265 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446081142 cc @tdas , too. This is an automated message from

[GitHub] dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call

2018-12-10 Thread GitBox
dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant `checkForStreaming` call URL: https://github.com/apache/spark/pull/23251#issuecomment-446081024 Retest this please. This is an automated message

[GitHub] HyukjinKwon commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
HyukjinKwon commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#discussion_r240480046 ## File path:

[GitHub] BryanCutler commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run

2018-12-10 Thread GitBox
BryanCutler commented on issue #22273: [SPARK-25272][PYTHON][TEST] Add test to better indicate pyarrow is installed and related tests will run URL: https://github.com/apache/spark/pull/22273#issuecomment-446080278 retest this please

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079822 Test FAILed. Refer to this link for build results

[GitHub] SparkQA removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446078542 **[Test build #99948 has

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079818 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079818 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079822 Test FAILed. Refer to this link for build results (access rights

[GitHub] SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079811 **[Test build #99948 has

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079415 Test FAILed. Refer to this link for build results

[GitHub] SparkQA removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077714 **[Test build #99947 has

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079413 Merged build finished. Test FAILed.

[GitHub] SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079407 **[Test build #99947 has

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079415 Test FAILed. Refer to this link for build results (access rights

  1   2   3   4   5   6   7   8   9   >