[GitHub] spark pull request: [Spark-14761][SQL][WIP] Reject invalid join me...

2016-04-27 Thread bkpathak
Github user bkpathak commented on the pull request: https://github.com/apache/spark/pull/12691#issuecomment-215205728 @JoshRosen I have added regression test. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [Spark-14761][SQL][WIP] Reject invalid join me...

2016-04-26 Thread bkpathak
Github user bkpathak commented on the pull request: https://github.com/apache/spark/pull/12691#issuecomment-214931412 Thank's Josh. I'll add the regression test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-14761][SQL][WIP] Reject invalid join me...

2016-04-26 Thread bkpathak
GitHub user bkpathak opened a pull request: https://github.com/apache/spark/pull/12691 [Spark-14761][SQL][WIP] Reject invalid join methods even when join columns are not specified in PySpark DataFrame join. ## What changes were proposed in this pull request? In PySpark

[GitHub] spark pull request: [Spark-14761][SQL][WIP] Reject invalid join me...

2016-04-26 Thread bkpathak
Github user bkpathak commented on the pull request: https://github.com/apache/spark/pull/12691#issuecomment-214647792 @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-07-04 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/12691 Hi @JoshRosen, could you please look at the pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #12691: [Spark-14761][SQL][WIP] Reject invalid join metho...

2016-10-08 Thread bkpathak
GitHub user bkpathak reopened a pull request: https://github.com/apache/spark/pull/12691 [Spark-14761][SQL][WIP] Reject invalid join methods when join columns are not specified in PySpark DataFrame join. ## What changes were proposed in this pull request? In PySpark

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-08 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/12691 Hi @holdenk I am still interested in working on this but it looks like I pull and merged with a master branch instead of rebasing it. Can I close it and open another pull request. Or how should I

[GitHub] spark pull request #12691: [Spark-14761][SQL][WIP] Reject invalid join metho...

2016-10-08 Thread bkpathak
GitHub user bkpathak reopened a pull request: https://github.com/apache/spark/pull/12691 [Spark-14761][SQL][WIP] Reject invalid join methods when join columns are not specified in PySpark DataFrame join. ## What changes were proposed in this pull request? In PySpark

[GitHub] spark pull request #12691: [Spark-14761][SQL][WIP] Reject invalid join metho...

2016-10-08 Thread bkpathak
Github user bkpathak closed the pull request at: https://github.com/apache/spark/pull/12691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #12691: [Spark-14761][SQL][WIP] Reject invalid join metho...

2016-10-08 Thread bkpathak
Github user bkpathak closed the pull request at: https://github.com/apache/spark/pull/12691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15409: [Spark-14761][SQL] Reject invalid join methods when join...

2016-10-11 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/15409 @rxin , @srinathshankar Could you please review the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #15409: [Spark-14761][SQL] Reject invalid join methods wh...

2016-10-09 Thread bkpathak
GitHub user bkpathak opened a pull request: https://github.com/apache/spark/pull/15409 [Spark-14761][SQL] Reject invalid join methods when join columns are not specified in PySpark DataFrame join. ## What changes were proposed in this pull request? In PySpark, the invalid

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-09 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/12691 @srowen @holdenk I have created new branch, applied patch and created the new pull request. Closing this pull request. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #12691: [Spark-14761][SQL][WIP] Reject invalid join metho...

2016-10-09 Thread bkpathak
Github user bkpathak closed the pull request at: https://github.com/apache/spark/pull/12691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15409: [Spark-14761][SQL] Reject invalid join methods when join...

2016-10-09 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/15409 @holdenk @JoshRosen Can you please review this pull requst. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15409: [Spark-14761][SQL] Reject invalid join methods when join...

2016-10-10 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/15409 Hi @rxin, I removed those lines and fixed the errors. @srinathshankar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your