Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23186#discussion_r237990120
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala
---
@@ -65,6 +65,34 @@ class FileIndexSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r237985559
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1209,9 +1209,9 @@ class PowerIterationClustering(HasMaxIter,
HasWeightCol, JavaParams, JavaMLReada
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r237984857
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/PowerIterationClusteringWrapper.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r237983768
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/FPGrowthExample.scala ---
@@ -64,4 +64,3 @@ object FPGrowthExample
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237977599
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -245,8 +245,7 @@ class SparkContextSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r237956662
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/FPGrowthExample.scala ---
@@ -64,4 +64,3 @@ object FPGrowthExample
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23177
Oh, @kiszk . Could you update AppVoyer script together? AppVoyer still uses
a static version number unlike with `build/mvn`.
-
https://github.com/apache/spark/blob/master/dev/appveyor
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r237948799
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23177#discussion_r237945252
--- Diff: pom.xml ---
@@ -114,7 +114,7 @@
1.8
${java.version}
${java.version}
-3.5.4
+3.6.0
--- End
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23177
Thank you for pinging me, @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22514
Oh, PySpark UT failures look weird.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r237337683
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23132#discussion_r237247452
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1610,6 +1610,13 @@ object SQLConf {
"&quo
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22514
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23124
Thank you so much, @cloud-fan !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23132#discussion_r236874565
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1610,6 +1610,13 @@ object SQLConf {
"&quo
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23132#discussion_r236873488
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -9,6 +9,8 @@ displayTitle: Spark SQL Upgrading Guide
## Upgrading From Spark SQL 2.4
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23155#discussion_r236870888
--- Diff: docs/running-on-kubernetes.md ---
@@ -932,15 +935,31 @@ specific to Spark on Kubernetes.
(none)
Specify the local
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23155
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23155
Thank you for your first contribution, @aditanase .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r236866087
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -111,6 +111,8 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 2.0, Spark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r236835472
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r236797263
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -111,6 +111,8 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 2.0, Spark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23108
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236057105
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -341,8 +341,6 @@ displayTitle: Spark SQL Upgrading Guide
APIs. Instead, `DataFrame
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23133
Thank you, @Leemoonsoo . Merged to `master/branch-2.4`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23133
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Thanks, @gaborgsomogyi and @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235999222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235999040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23121
I had better ask about the target branches. :)
Thanks, @jerryshao . Now, it lands for 2.4.1.
---
-
To unsubscribe, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23121
Merged to `branch-2.4`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Merged to master to recover `master` branch Maven testings.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235852779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Hi, @cloud-fan . Could you review this, please?
[Test build #99205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99205/testReport)
is almost passed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235851923
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -558,8 +558,11 @@ private
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235851798
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -19,6 +19,8 @@ displayTitle: Spark SQL Upgrading Guide
- In Spark version 2.4
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235851554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
The current one hangs on `BroadcastSuite`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
The previous successful one was `sbt`.
The current on-going one fails with another flacky test,
[SPARK-25903](https://issues.apache.org/jira/browse/SPARK-25903
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23116
Thank you, @jerryshao . Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23118
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
[ChunkFetchIntegrationSuite](https://issues.apache.org/jira/browse/SPARK-25692)
seems to be very flacky in Maven build. This causes two consequtive irrelevant
failures in this PR
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
I forgot `[test-maven]` is a case-sensitive tag. The previous one went to
`sbt` Jenkins. Hopefully, next one will go to 'maven' Jenkins
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23119
`sbt` and `maven` have different behavior to resolve the dependencies. So,
in Apache Spark community, `maven` is the official one although we support both
and `sbt` is used in PR builder
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23119
[SPARK-25954][SS][FOLLOWUP][TEST-MAVEN] Add Zookeeper 3.4.7 test dependency
to Kafka modules
## What changes were proposed in this pull request?
This is a followup of #23099 . After
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23116
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23118
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23118#discussion_r235799947
--- Diff: build/mvn ---
@@ -116,7 +116,8 @@ install_zinc() {
# the build/ folder
install_scala() {
# determine the Scala version used
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23118#discussion_r235674477
--- Diff: build/mvn ---
@@ -116,7 +116,8 @@ install_zinc() {
# the build/ folder
install_scala() {
# determine the Scala version used
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23110
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r235671486
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -597,6 +597,38 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r235670505
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -111,6 +111,8 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 2.0, Spark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23108
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23118
Thank you, @HyukjinKwon . :D
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23118
cc @srowen , @shaneknapp , @dbtsai , @HyukjinKwon
I noticed this during investigating Scala-2.11 Jenkins jobs. Sorry for
pinging you guys at Thanks Giving holiday. As I'm the one who
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23118
[SPARK-26144][BUILD] `build/mvn` should detect `scala.version` based on
`scala.binary.version`
## What changes were proposed in this pull request?
Currently, `build/mvn` downloads
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23027
I like new benchmark, but I still hope we have a separate suite for
in-memory benchmark.
The current one looks misleading and inconsistent in this file
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23101
Welcome, @tasanuma !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23101
Thank you all. Merged to `master`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23115
This is merged to `branch-2.2`. Please close this PR.
Thanks, @attilapiros .
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23114
This is merged now. Please close this PR.
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23114
Merged to `branch-2.3`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23115
Thank you, @attilapiros . I'll do the manual test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23114
Apache Spark merge script removes '@' from the commit message in order to
avoid pinging people.
---
-
To unsubscribe, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23114
Oh, I got it. The PR description is wrong in this PR.
The current one.
```
$ curl -H cookie http://458apiros-MBP.lan:18080/
```
The correct one needs
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23114
@attilapiros . I followed the verification steps in the PR description,
but I cannot reproduce this issue at Spark 2.4.0 and 2.3.2 History Server. I'm
using Mac like the following
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23114
Thank you, @attilapiros . If Jenkins pass, I'll merge this to `branch-2.3`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23102
Hi, @markpavey .
According to the JIRA description, you tested your PR on the Windows. As
@kiszk advised, could you add more specific description about what you tested
on Windows manually
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23102
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23107
Hi, @Charele .
Could you read http://spark.apache.org/community.html ?
You had better close
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
Merged to master. Thank you, @MaxGekk and @HyukjinKwon , @kiszk .
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23096#discussion_r235505190
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -648,7 +648,11 @@ class SparkSession private(
* @since 2.0.0
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23090
Thank you, @squito , @attilapiros , @srowen .
Then, @attilapiros , could you send backporting PRs against `branch-2.3`
and `branch-2.2` please
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23055
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23099
Thank you for review, @HyukjinKwon and @gaborgsomogyi .
Merged to master.
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23101
cc @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23099
Thank you for retriggering, @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23099
[WIP][SPARK-25954][SS] Upgrade to Kafka 2.1.0
## What changes were proposed in this pull request?
[Kafka 2.1.0
vote](https://lists.apache.org/thread.html
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23096#discussion_r235185654
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -648,7 +648,11 @@ class SparkSession private(
* @since 2.0.0
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23096#discussion_r235112175
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -648,7 +648,11 @@ class SparkSession private(
* @since 2.0.0
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23090
I understand the situation. However, according to the content of the patch,
it's an improvement to add a missing configuration, @attilapiros .
```
httpConfig.setRequestHeaderSize
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23090
Hi, @squito .
SPARK-26118 is marked as 'Improvement', we don't backport 'Improvement'.
---
-
To unsubscribe, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23064
Since 2.2.0 was released on July 11 2017, I cherry-picked to `branch-2.2`,
too.
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23059
Thank you, @HyukjinKwon, @felixcheung , and @srowen .
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23064
Thank you, @HyukjinKwon , @felixcheung , and @gengliangwang !
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23064
[MINOR][SQL] Fix typo in CTAS plan database string
## What changes were proposed in this pull request?
Since Spark 1.6.0, there was a redundant '}' character in CTAS string
plan's
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23059
[SPARK-26091][SQL] Upgrade to 2.3.4 for Hive Metastore Client 2.3
## What changes were proposed in this pull request?
Hive 2.3.4 is released on [Nov.
7th](https://issues.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23039#discussion_r234303428
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/util/UtilsSuite.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
How about the following?
```
Move `truncatedString` to `sql/catalyst` and add
`spark.sql.debug.maxToStringFields` conf
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23045#discussion_r234037904
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
---
@@ -46,12 +46,20 @@ object TypeUtils
101 - 200 of 7331 matches
Mail list logo
