[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-23 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11320 [SPARK-11381][DOCS] Replace example code in mllib-linear-methods.md using include_example ## What changes were proposed in this pull request? This PR replaces example codes

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-187924844 Oh, thanks. I'll check the Jenkins in detail. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-187928402 To be sure, I rebased this PR to the master, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-187926696 Actually, the error was Github timeout. I pushed force again. Could you ask Jenkins to retest please? ``` +refs/pull/11320/*:refs/remotes/origin/pr/11320

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-187939511 Let me fix the Scala style. I thought I passed since `build/mvn -DskipTests checkstyle:check` ends with 'SUCCESS'. Now, I see that there were printed '[ERROR

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-187940614 Thank you so much, @yinxusen ! I'll fix soon and let you know here. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11320#discussion_r54215098 --- Diff: examples/src/main/java/org/apache/spark/examples/mllib/JavaL1UpdaterExample.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-189160467 Okay. No problem! I will update soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11320#discussion_r54217273 --- Diff: examples/src/main/python/mllib/svm_with_sgd_example.py --- @@ -0,0 +1,47 @@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11320#discussion_r54217329 --- Diff: examples/src/main/python/mllib/svm_with_sgd_example.py --- @@ -0,0 +1,47 @@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-189161103 Oh, I see. Then, let me know when you finish. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [MINOR][SQL] Fix modifier order.

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11390#issuecomment-189492992 Thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-188902755 Thank you, @yinxusen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190455685 Thank you, @srowen ! Up to know, I'm not sure about enforcing Scala Imports but I'll check that, too. I'll leave a message soon. By the way

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190463372 Hi, @srowen . Surprisingly, according to the [ScalaStyle Ruleset](http://www.scalastyle.org/rules-0.8.0.html) , it seems that we can not do that for Scala

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11438 [SPARK-13583][BUILD] Enforce `UnusedImports` Java checkstyle rule ## What changes were proposed in this pull request? After SPARK-6990, `dev/lint-java` keeps Java code healthy

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190473353 Oh, thank you for informing that, @zsxwing . By the way, `dev\lint-java` does not depend on `mvn install`. I think It depends on compiled classes

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190473820 @srowen , for the scala code, should we take advantage of `-Ywarn-unused-import` option for that in some way? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190475570 Oh, I see. Then, this PR will not enforce automatically, just helps developers to check before pushing PR. Thank you, @zsxwing ! --- If your project

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-189184319 Thank you, @yinxusen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-189195673 I pushed the commit. I've learn many things from you. Thank you very much, @yinxusen . --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [MINOR][SQL] Fix modifier order.

2016-02-26 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11390 [MINOR][SQL] Fix modifier order. ## What changes were proposed in this pull request? This PR fixes the order of modifier from `abstract public` into `public abstract`. Currently

[GitHub] spark pull request: [MINOR][DOCS] Fix all typos in markdown files ...

2016-02-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11300#issuecomment-187292436 Thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR][SQL] Fix modifier order.

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11390#issuecomment-189335070 @srowen , right. That's the only one error message. And, I wondered that, too. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-189394636 Hi, @mengxr . Could you close this PR? It is merged to the master successfully, but is not closed until now. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-189364055 Thank you so much, @mengxr and @yinxusen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-02-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-188505409 Hi, @yinxusen and @mengxr . Could you review this if you squeeze some time out of your schedule? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11289 [MINOR][DOCS] Fix typos in `NOTICE`, `configuration.md`, and `hardware-provisioning.md` ## What changes were proposed in this pull request? This PR fixes some typos in the following

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186894117 Oh, thank you, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186942753 Oh, sure. No problem. Only for `NOTICE`, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186943382 Thank you, @rxin. I remove the change on NOTICE file and rebased it now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `configuration.md` ...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186943912 Thank you for merging, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11295 [MINOR][DOCS] Fix typos in ML doc ## What changes were proposed in this pull request? This PR fixes some typos in ML and MLLib markdown document files. ## How

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186979478 Oh, sure! Then, I will close this and make another PR after reviewing all md files in docs. Is it okay for you? --- If your project is set up for it, you can

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/11295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186980619 Thank you for your advice, @rxin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR][DOCS] Fix all typos in markdown files ...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11300#issuecomment-187046857 Hi, @rxin . I finished reviewing all files under the `docs` module and related stuff. I think it's all typos for now. Thank you again. --- If your

[GitHub] spark pull request: [MINOR][DOCS] Fix all typos in markdown files ...

2016-02-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11300 [MINOR][DOCS] Fix all typos in markdown files of `doc` and similar patterns in other comments ## What changes were proposed in this pull request? This PR tries to fix all typos

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190880411 Thank you for the testing, @srowen . Unfortunately, it still fails. For the Scala Unused Imports, I see what you mean. Then, I'll update Jira issue

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190886825 Thank you, @zsxwing ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-190874901 Thank you for closing this, @srowen and @mengxr . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190483710 Hi, @srowen . I've test more, but found that `-Ywarn-unused-import` option is not reliable yet in Scala 2.11.7. Please refer https://issues.scala

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190562653 Rebased to trigger the Jenkins test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190537588 It seems that Jenkins fails due to irrelevant things like the following. ``` Error instrumenting

[GitHub] spark pull request: [SPARK-13423] [WIP] [CORE] [SQL] [STREAMING] S...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11292#issuecomment-191004045 I'm a big fan of this PR. When will it be merge, @srowen ? :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [MINOR][STREAMING] Replace deprecated `apply` ...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11451#issuecomment-190959346 Right, @srowen . This is one of Spark deprecated warnings. I chose this one as a minor since it's an example and only one line fix for Twitter library

[GitHub] spark pull request: [MINOR][STREAMING] Replace deprecated `apply` ...

2016-03-01 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11451 [MINOR][STREAMING] Replace deprecated `apply` with `create` in example. ## What changes were proposed in this pull request? Twitter Algebird deprecated `apply` in HyperLogLog.scala

[GitHub] spark pull request: [SPARK-11381][DOCS] Replace example code in ml...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11320#issuecomment-190632701 Hi, @mengxr . Could you close this PR? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-194377592 Thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13702][CORE][SQL][MLLIB] Use diamond op...

2016-03-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11541#issuecomment-194378260 Thank you, @srowen . Yes, it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194931833 With Scala 2.10, it still has a problem. I will close this PR right now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/11630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11630 [SPARK-12653] Re-enable test "SPARK-8489: MissingRequirementError during reflection" ## What changes were proposed in this pull request? This PR re-enable the dis

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194722327 Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11629 [MINOR][SQL] Replace DataFrameWriter.stream() with startStream() in comments. ## What changes were proposed in this pull request? According to #11627 , this PR replace

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194687743 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194771186 Please note that the error message is changed. I think it's due to the change of master branch. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194776565 Hmm. I'll test with Scala 2.10 and report here soon. I hope I didn't make the same mistake again. Thank you for review, @srowen . --- If your

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194761126 @srowen , please let me know if I did some mistake. Thank you always! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194760855 I fixed this according @rxin 's original guess. It was right. The prebuilt jar file is built with old spark. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194760415 Sure. It is described in the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194744926 Jenkins is still running, but we can see the re-enabled test is passed correctly from the log. ``` - stdout> Regression test for SPARK-8489 succ

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194756823 Hi, @rxin . Could you review and merge this PR? It's about your [SPARK-12653](https://issues.apache.org/jira/browse/SPARK-12653) on 2.0.0

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11630#issuecomment-194770619 Ah, the description in JIRA issue was short, and I didn't wrote the real error message. Sorry for lack of description. When I enabled that test

[GitHub] spark pull request: [SPARK-3854] Scala style: require spaces befor...

2016-03-10 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11637 [SPARK-3854] Scala style: require spaces before `{`. ## What changes were proposed in this pull request? Since the opening curly brace, '{', has many usages as discussed in [SPARK

[GitHub] spark pull request: [SPARK-3854][BUILD] Scala style: require space...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11637#issuecomment-195040212 Hi, @JoshRosen . Could you review this issue? I can add more patterns if you want. I think this PR has its meaning on automated prevention by ScalaStyle

[GitHub] spark pull request: [SPARK-3854][BUILD] Scala style: require space...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11637#issuecomment-195095680 @andrewor14 Thank you for your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3854][BUILD] Scala style: require space...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11637#issuecomment-195080538 Thank you, @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][DOC] Fix supported hive version in doc

2016-03-10 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11639 [MINOR][DOC] Fix supported hive version in doc ## What changes were proposed in this pull request? Today, Spark 1.6.1 and updated docs are release. Unfortunately, there is obsolete

[GitHub] spark pull request: [SPARK-3854][BUILD] Scala style: require space...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11637#issuecomment-195106654 Finally, it passed. Could you merge this PR, @rxin and @andrewor14 ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3854][BUILD] Scala style: require space...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11637#issuecomment-195108609 Thank you, @andrewor14 ! My JIRA account is `dongjoon`. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-195109056 Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][DOC] Fix supported hive version in doc

2016-03-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11639#issuecomment-195128051 Thank you, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12653][SQL] Re-enable test "SPARK-8489:...

2016-03-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11744#issuecomment-197379330 Thank you, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12653] Re-enable test "SPARK-8489: Miss...

2016-03-15 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11744 [SPARK-12653] Re-enable test "SPARK-8489: MissingRequirementError during reflection" ## What changes were proposed in this pull request? The purpose of [SPARK-12

[GitHub] spark pull request: [MINOR][DOCS] Update build descriptions and co...

2016-03-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11838#issuecomment-198648575 Thank you, @rxin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...

2016-03-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196043144 Hi, @JoshRosen . If it's possible, could you review this PR, too? This supersedes #11661 . This is a build PR, so I think we need more careful review

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11661#issuecomment-195606637 My bad. I'll close this PR now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/11661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11661 [SPARK-13834] Update sbt for 2.x. ## What changes were proposed in this pull request? For 2.0.0, we had better bump `sbt`, too. SBT 0.13.11 fixes wrong warnings and improve

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11661#issuecomment-195610240 Actually, it seems that MIMA test passes on JDK8 and fails on JDK7. I didn't check that before PR. I'm investigating the reason now. Although I closed

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11661#issuecomment-195625234 Oh, @JoshRosen . I'll merge both PR. It passed now based on #11669 . Sorry for making you confused. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11661#issuecomment-195620503 Hi, @JoshRosen . I made a PR for MiMa first: #11669 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11661#issuecomment-195617676 Thank you, @JoshRosen . I tried both together, too. But, it still has a problem. By the way, during that procedure, I found that new MiMa plugin reports

[GitHub] spark pull request: [SPARK-13834] Update sbt for 2.x.

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11661#issuecomment-195617712 Really, it's interesting issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-XXX][BUILD] Update MiMa plugin to 0.1.9...

2016-03-11 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11669 [SPARK-XXX][BUILD] Update MiMa plugin to 0.1.9. ## What changes were proposed in this pull request? NOTE: Apache JIRA is down now. I'll update the title as soon as possible

[GitHub] spark pull request: [SPARK-13834] Update sbt and MiMa plugin for 2...

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195626487 Hi, @JoshRosen . Now, this PR includes SBT/MiMa updates for SPARK-13834. Build and MiMa is tested on both JDK8 and JDK7. I hope it will pass

[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and MiMa plugi...

2016-03-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195652364 Hi, @JoshRosen . After upgrading MiMa plugin, I can finish upgrading SBT . Could you review and merge this? Now, it passes the test. Thank you again

[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...

2016-03-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196083702 Thank you for your review, @JoshRosen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][DOCS] Fix more typos in comments/strin...

2016-03-13 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11689 [MINOR][DOCS] Fix more typos in comments/strings. ## What changes were proposed in this pull request? This PR fixes 136 typos over 108 files: * 122 typos in comments * 11

[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...

2016-03-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196110314 Thank you, @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][DOCS] Fix more typos in comments/strin...

2016-03-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11689#issuecomment-196213887 Thank you, @srowen . :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13870][SQL] Add scalastyle escaping cor...

2016-03-14 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11700 [SPARK-13870][SQL] Add scalastyle escaping correctly in CVSSuite.scala ## What changes were proposed in this pull request? When initial creating `CVSSuite.scala` in SPARK-12833

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-196494864 Oh, thank you so much for your attention/reviewing/merging, @mengxr ! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13660][SQL][Tests] ContinuousQuerySuite...

2016-03-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11703#issuecomment-196557162 Could you try again './dev/mima' with only the first commit locally? I'm sure you can pass at this time. :) By the way, I'm not a Spark committer

[GitHub] spark pull request: [SPARK-13870][SQL] Add scalastyle escaping cor...

2016-03-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11700#issuecomment-196541406 Thank you, @andrewor14 . MiMa failures seem to occur in many PRs sporadically today. It's interesting. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-13870][SQL] Add scalastyle escaping cor...

2016-03-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11700#issuecomment-196552474 Just rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13870][SQL] Add scalastyle escaping cor...

2016-03-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11700#issuecomment-196584381 Finally! @andrewor14 Could you merge this, please? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13702][CORE][SQL][MLLIB] Use diamond op...

2016-03-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11541#issuecomment-194081760 Hi, @mengxr . The latest commit passes the test. Could you review this again please? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-13702][CORE][SQL][MLLIB] Use diamond op...

2016-03-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11541#issuecomment-194092186 The latest one is at commit `2e20843`, and all three builds (including that) passes. --- If your project is set up for it, you can reply to this email and have

<    1   2   3   4   5   6   7   8   9   10   >