[GitHub] spark pull request: [SPARK-13702][CORE][SQL][MLLIB] Use diamond op...

2016-03-05 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11541 [SPARK-13702][CORE][SQL][MLLIB] Use diamond operator for generic instance creation in Java code. ## What changes were proposed in this pull request? Java 7 or higher supports

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11527#discussion_r55092246 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala --- @@ -141,7 +143,7 @@ object LinearRegressionWithSGD

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-04 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11527 [SPARK-13686][MLLIB][STREAMING] Add a constructor parameter `reqParam` to (Streaming)LinearRegressionWithSGD ## What changes were proposed in this pull request

[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...

2016-03-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192470061 Hi, @srowen . According to your advice, I reviewed the other algorithms and I found that all other algorithms use the same default values for `reqParam

[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...

2016-03-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192477152 Here is the JIRA Issue [SPARK-13686](https://issues.apache.org/jira/browse/SPARK-13686) and [PR](https://github.com/apache/spark/pull/11527). --- If your

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192758954 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13702][CORE][SQL][MLLIB] Use diamond op...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11541#issuecomment-192867752 Thank you for review, @srowen . I agree. This has a little limited benefit; only small portion Java and no functional improvement. Actually, I started

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192984080 Hi, @srowen . I update this PR and JIRA to use `close()` instead of `stop()`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-193008392 Hi, @mengxr and @jkbradley . Could you review this PR, please? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12243][BUILD][PYTHON] PySpark tests are...

2016-03-06 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11551 [SPARK-12243][BUILD][PYTHON] PySpark tests are slow in Jenkins. ## What changes were proposed in this pull request? In the Jenkins pull request builder, PySpark tests take around

[GitHub] spark pull request: [SPARK-12243][BUILD][PYTHON] PySpark tests are...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11551#issuecomment-193064926 As I wrote in Jira Issue, the total time of all tests are **3077s**. So, the minimum required time for 4 processes was 769s. According to the real Jenkins result

[GitHub] spark pull request: [SPARK-12243][BUILD][PYTHON] PySpark tests are...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11551#issuecomment-193065038 Hi, @JoshRosen . Could you review this, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192945968 Hi, @srowen . Sorry, but could you ask Jenkins to retest this PR? I tried to ask Jenkins by asking 'retest this please' and by rebasing this PR

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11530#discussion_r55147374 --- Diff: streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java --- @@ -390,6 +390,7 @@ public void testQueueStream

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-192969116 Thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12243][BUILD][PYTHON] PySpark tests are...

2016-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11551#issuecomment-193113588 Now, it's **763** seconds. It looks minimal and seems to use 4 processes fully. ``` Tests passed in 763 seconds ``` --- If your project is set up

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192718192 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-192718421 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][STREAMING] Replace deprecated `apply` ...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11451#issuecomment-191310509 Thank you for merging, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-191319573 Thank you. I see. I rebased to test one more time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-03-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190653024 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-191138263 Hi, @srowen . The unused imports in Scala code are removed, too. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13627][SQL][PYTHON] Fix simple deprecat...

2016-03-02 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11479 [SPARK-13627][SQL][PYTHON] Fix simple deprecation warnings. ## What changes were proposed in this pull request? This PR aims to fix the following deprecation warnings

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11481 [MINOR] Fix typos in comments and testcase name of code ## What changes were proposed in this pull request? This PR fixes typos in comments and testcase name of code. ## How

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191551076 Thank you, @sarutak and @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13583][CORE][STREAMING] Remove unused i...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-191525135 It passes the test finally. I updated the title and description of this PR and JIRA. To sum up, * Remove all detected unused imports in Java (except one

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191525506 Hi, @srowen . Could you review this PR? This PR fixes 6 types of simple deprecations. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191534769 Since it's not about documents and contains testcase name typo, so I couldn't choose `DOCS` as component name. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191585706 Thank you, @srowen . You mean the scope of this was Scala 2.11.7 and there is some more work remaining for Scala 2.10, right? I see. --- If your project

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191586179 Then, will Spark 2.0.0 support both Scala versions like now? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191576684 Oh, thank you, @rxin . I missed your message here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191577290 Hi, @sarutak and @rxin . **WithAggregationKinesisBackedBlockRDDSuite** took about 2 hours and still is running. The following is the last part

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191582841 Oh, thank you for re-triggering. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191588479 Thank you for your advice! Is the magic word of a committer **Jenkins, test this please** and **ok to test** then? --- If your project is set up

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191578985 Thank you for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191590972 Oops, I'll find a quick fix ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191633263 Hi, @sarutak and @rxin . three builds hanged at the same test **WithAggregationKinesisBackedBlockRDDSuite**. The first build fails due to timeout

[GitHub] spark pull request: [HOT-FIX] Recover some deprecations for 2.10 c...

2016-03-02 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11488 [HOT-FIX] Recover some deprecations for 2.10 compatibility. ## What changes were proposed in this pull request? [SPARK-13627](#11479) broke 2.10 compatibility: [2.10-Build](https

[GitHub] spark pull request: [HOT-FIX] Recover some deprecations for 2.10 c...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11488#issuecomment-191621670 @srowen . Unfortunately, I need to rollback most of them. Sorry for this happening. I get some misunderstanding about Spark 2.0.0. Thank you for guiding

[GitHub] spark pull request: [SPARK-13627][SQL][YARN] Fix simple deprecatio...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11479#issuecomment-191624811 @srowen . I made a quick fix. Could you review #11488 , please? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13583][CORE][STREAMING] Remove unused i...

2016-03-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-191892412 Thank you for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191894607 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [HOT-FIX] Recover some deprecations for 2.10 c...

2016-03-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11488#issuecomment-191892684 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191893626 Thank you for confirming. I'll avoid that in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11481#issuecomment-191968452 Finally, it passed. I filed the Kinesis issue as [SPARK-13655](https://issues.apache.org/jira/browse/SPARK-13655), too. --- If your project is set up

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193374104 Just rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193341807 Oh, @srowen . There is no apparent error for me. It stops before `SparkR` tests and marked. ``` Build step 'Execute shell' marked build as failure

[GitHub] spark pull request: [SPARK-12243][BUILD][PYTHON] PySpark tests are...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11551#issuecomment-193344583 Thank you really, @srowen . Yep, it was the last piece of long task I observed. To sum up, we can save about 200 seconds (3 min 20 secs) by starting

[GitHub] spark pull request: [SPARK-13655] [STREAMING] [TESTS] Fix WithAggr...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11558#issuecomment-193372452 Great! Thank you for trying to resolve this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-12243][BUILD][PYTHON] PySpark tests are...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11551#issuecomment-193439198 Thank you, @JoshRosen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193489194 Thanks to #11564 , I can fix `JavaKinesisStreamSuite` too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193492670 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193510043 Thank you, @zsxwing ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [HOT-FIX] Use the new location of `checkstyle-...

2016-03-07 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11567 [HOT-FIX] Use the new location of `checkstyle-suppressions.xml` ## What changes were proposed in this pull request? This PR fixes `dev/lint-java` and `mvn checkstyle:check` failures

[GitHub] spark pull request: [HOT-FIX][BUILD] Use the new location of `chec...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11567#issuecomment-193522667 Currently, Jenkins does not run `lint-java`. So this failure is not caught before. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [HOT-FIX][BUILD] Use the new location of `chec...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11567#issuecomment-193522841 Could you review this please? @srowen and @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13692] Fix trivial Coverity/Checkstyle ...

2016-03-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192527079 Hi, @srowen . This is based on Coverity reports. Could you review this please? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13692] Fix trivial Coverity/Checkstyle ...

2016-03-04 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11530 [SPARK-13692] Fix trivial Coverity/Checkstyle defects ## What changes were proposed in this pull request? This issue fixes the following potential bugs and Java coding style

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192621250 Thank you, @srowen . Since `Coverity` was announced in mailing lists, I made this PR/JIRA quickly to avoid any potential conflicts. I'll try to add more

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11530#discussion_r55119439 --- Diff: examples/src/main/java/org/apache/spark/examples/mllib/JavaGaussianMixtureExample.java --- @@ -44,8 +44,9 @@ public static void main(String

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-192623941 Hi, @srowen . I want to fix MiMa failures, but `./dev/mima` passes locally whenever I run it locally. So far, I didn't touch `project/MimaExcludes.scala

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-192625012 Oh, sorry. I found that. Thanks. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192639022 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-192638898 Hi, @srowen . I did the followings, too. ``` - Remove unused fields in `ChunkFetchIntegrationSuite`. - Add `close()` to prevent resource leak

[GitHub] spark pull request: [SPARK-13686][MLLIB][STREAMING] Add a construc...

2016-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11527#issuecomment-192639012 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...

2016-03-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192347677 I see, @srowen . I will check the others, too. Thank you, @srowen and @mengxr . --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...

2016-03-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192349163 Also, thank you for Coverity, @srowen ! Today, I will check them, too. :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [MINOR][STREAMING] Replace deprecated `apply` ...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11451#issuecomment-191153280 Before this PR, the error message in the Jenkins build looks like the following. (9 times.) ``` /home/jenkins/workspace/SparkPullRequestBuilder/examples

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-191168658 I've compared the Jenkins logs. My PR hangs at the following test. ``` [info] WithAggregationKinesisBackedBlockRDDSuite: Using endpoint URL https

[GitHub] spark pull request: [SPARK-13400] Stop using deprecated Octal esca...

2016-03-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11584#issuecomment-193953311 Yes. We should do double check Jenkins log although I've seen those two lines in my local machine, too. Thank you, @rxin and @holdenk . --- If your project

[GitHub] spark pull request: [SPARK-13400] Stop using deprecated Octal esca...

2016-03-08 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11584 [SPARK-13400] Stop using deprecated Octal escape literals ## What changes were proposed in this pull request? This removes the remaining deprecated Octal escape literals

[GitHub] spark pull request: [SPARK-14338][SQL] Improve `SimplifyConditiona...

2016-04-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12122#issuecomment-204902564 Oh, sorry for breaking Scala 2.10 build and late response, @yhuai and @rxin . Thank you so much for hot fix, @rxin ! --- If your project is set up

[GitHub] spark pull request: [MINOR][DOCS] Use multi-line JavaDoc comments ...

2016-04-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12130#issuecomment-204898177 Thank you, @rxin . I see. I'll create a JIRA for large size patch . And, for creating new ScalaStyle rule to enforce this seems a good idea. I'll take

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58243529 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -237,15 +237,18 @@ case class ExplainCommand

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12094#issuecomment-204489579 I see. Thank you, @davies . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58243106 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala --- @@ -81,29 +100,11 @@ package object debug

[GitHub] spark pull request: [SPARK-14350][SQL] EXPLAIN output should be in...

2016-04-03 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12137 [SPARK-14350][SQL] EXPLAIN output should be in a single cell ## What changes were proposed in this pull request? EXPLAIN output should be in a single cell. **Before

[GitHub] spark pull request: [SPARK-14350][SQL] EXPLAIN output should be in...

2016-04-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12137#issuecomment-204941218 Thank you for fast review, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204567123 One minor thing, why @DeepSparkBot does not visit this PR? Today, @DeepSparkBot came to my other PR. :) --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204565788 Now, `EXPLAIN CODEGEN` is the logically same with `debugCodegen`. I updated the description of this PR, too. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204547543 Hi, @rxin . `debugCodegenString` is removed and `DebuggingSuite` is modified accordingly. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58265346 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -237,15 +237,18 @@ case class ExplainCommand

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58264981 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -237,15 +237,18 @@ case class ExplainCommand

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58264076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -237,15 +237,18 @@ case class ExplainCommand

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58257745 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala --- @@ -81,29 +100,11 @@ package object debug

[GitHub] spark pull request: [SPARK-14350][SQL] EXPLAIN output should be in...

2016-04-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12137#issuecomment-205021348 Oh, thank you! @hvanhovell . :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14355][BUILD] Fix typos in Exception/Te...

2016-04-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12139#issuecomment-205086218 Thank you, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14355][BUILD] Fix typos in Exception/Te...

2016-04-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12139#issuecomment-205095821 Thank you, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14355][BUILD] Fix typos in Exception/Te...

2016-04-03 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12139 [SPARK-14355][BUILD] Fix typos in Exception/Testcase/Comments and static analysis results ## What changes were proposed in this pull request? This issue contains the following 5

[GitHub] spark pull request: [SPARK-14402][CORE] UTF8String.toTitleCase sho...

2016-04-05 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12175 [SPARK-14402][CORE] UTF8String.toTitleCase should return non-first letters in lowercase ## What changes were proposed in this pull request? Current `UTF8String.toTitleCase

[GitHub] spark pull request: [SPARK-14219][GRAPHX] Fix `pickRandomVertex` n...

2016-03-28 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/12021 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-14219][GRAPHX] Fix `pickRandomVertex` n...

2016-03-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12021#issuecomment-202711699 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][SQL] Fix typos by replacing 'much' wit...

2016-03-29 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12042 [MINOR][SQL] Fix typos by replacing 'much' with 'match'. ## What changes were proposed in this pull request? This PR fixes two trivial typos: 'does not **much**' --> 'd

[GitHub] spark pull request: [MINOR][SQL] Fix exception message to print st...

2016-03-29 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12041 [MINOR][SQL] Fix exception message to print string-array correctly. ## What changes were proposed in this pull request? This PR is a simple fix for an exception message to print

[GitHub] spark pull request: [MINOR][SQL] Fix exception message to print st...

2016-03-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12041#issuecomment-203047996 Thank you , @rxin and @sameeragarwal . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204160591 Hi, @hvanhovell . I updated the PR according to your comments. For the real generated code, I think it's safe to maintain the first three lines since

[GitHub] spark pull request: [SPARK-14164][MLLIB] Improve input layer valid...

2016-03-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11964#issuecomment-204013871 Thank you for merging, @mengxr ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

2016-03-31 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12094 [MINOR][SQL] Update usage of `debug` by removing `typeCheck` and adding `debugCodegen` ## What changes were proposed in this pull request? This PR updates the usage comments

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204193533 Hi, @rxin . Could you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14338][SQL] Improve `SimplifyConditiona...

2016-04-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12122#issuecomment-204640788 Rebased and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

<    3   4   5   6   7   8   9   10   11   12   >