Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12122#issuecomment-204649453
It's strange.
`org.apache.spark.sql.execution.streaming.state.StateStoreSuite.maintenance`
test fails here and at my other PR frequently.
---
If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204652575
Thank you, @rxin , @hvanhovell , @andrewor14 , and @DeepSparkBot . :)
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12122
[SPARK-14338][SQL] Improve `SimplifyConditionals` rule to handle `null` in
IF/CASEWHEN
## What changes were proposed in this pull request?
Currently, `SimplifyConditionals` handles
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58288294
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -101,4 +101,19 @@ class HiveExplainSuite extends
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12122#issuecomment-204668443
Thank you, @rxin .
I fixed that to `private def`, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12122#issuecomment-204685192
The last failure is also
`org.apache.spark.sql.execution.streaming.state.StateStoreSuite.maintenance`.
It's irrelevant to this PR.
---
If your project is set
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12130#issuecomment-204688228
Could you review this PR, @rxin ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12130
[MINOR][DOCS] Use multi-line JavaDoc comments in Scala code.
## What changes were proposed in this pull request?
This PR aims to fix all Scala-Style multiline comments into Java
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204591610
Oh, I see. Thank you, @andrewor14 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204603217
I updated the code according to @DeepSparkBot 's comments, and also rebased
to the master since master branch is now Scala 2.11.8.
It took sometime to test
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12122#issuecomment-204615637
deep-review this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12130#issuecomment-204767494
`org.apache.spark.sql.execution.streaming.state.StateStoreSuite.maintenance`
failure again.
It's a timeout error, should we increase the timeout
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12122#issuecomment-204768932
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12130#issuecomment-204769078
Rebased to trigger Jenkins test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12041#issuecomment-203072209
Oh, I see what you mean. I'll try to reduce the review overheads on minor
stuffs. Thanks.
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11920#issuecomment-202518284
Thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/11851#discussion_r56880696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -71,6 +71,15 @@ object Canonicalize extends
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12099
[SPARK-14251][SQL] Add SQL command for printing out generated code for
debugging
## What changes were proposed in this pull request?
This PR implements `EXPLAIN CODEGEN` SQL command
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204154576
Thank you, @hvanhovell .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12353#discussion_r59586139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -620,7 +622,7 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12353#discussion_r59592620
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/CodegenConf.scala
---
@@ -0,0 +1,25
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12649#discussion_r60850733
--- Diff: docs/sql-programming-guide.md ---
@@ -1138,16 +1138,16 @@ for teenName in teenNames.collect():
schemaPeople # The DataFrame from
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12631#discussion_r60850172
--- Diff: build/mvn ---
@@ -116,23 +126,15 @@ install_scala() {
# the environment
ZINC_PORT=${ZINC_PORT:-"3030"}
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12632#issuecomment-214026076
It seems irrelevant errors. I'll rebase this to trigger again.
```
[info] Exception encountered when attempting to run a suite with class
name
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12590#issuecomment-214030458
Hi, @rxin .
Could you review this PR about `RemoveRepetitionFromGroupExpressions`?
---
If your project is set up for it, you can reply to this email and have
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12631#discussion_r60850260
--- Diff: build/mvn ---
@@ -67,17 +67,27 @@ install_app() {
fi
}
-# Install maven under the build/ folder
+# Determine
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12631#discussion_r60850132
--- Diff: build/mvn ---
@@ -67,17 +67,27 @@ install_app() {
fi
}
-# Install maven under the build/ folder
+# Determine
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12562#issuecomment-213595809
Thank you, @rxin and @marmbrus .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12426#discussion_r60977638
--- Diff: R/pkg/NAMESPACE ---
@@ -287,6 +287,7 @@ export("as.DataFrame",
"read.json",
"read.parquet
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12426#discussion_r60977738
--- Diff: R/pkg/R/context.R ---
@@ -226,6 +226,47 @@ setCheckpointDir <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheck
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/12665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r60950643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1051,6 +1053,22 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r60950803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1051,6 +1053,22 @@ class AstBuilder extends
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214448521
Oh, by the way, Github shows no confilicts but it seems to fail to rebase
to the master.
It might cause some delay when merging. I'm not sure, but you had
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214447695
Although I'm not a committer, I left a few comments since I like your PR,
@kevinyu98 .
---
If your project is set up for it, you can reply to this email
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12631
[SPARK-14867][BUILD] Make `build/mvn` to use the downloaded maven if it
exists.
## What changes were proposed in this pull request?
Currently, `build/mvn` provides a convenient
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12590#issuecomment-213660622
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12632
[SPARK-14868] Enable NewLineAtEofChecker in checkstyle and fix lint-java
errors
## What changes were proposed in this pull request?
Spark uses `NewLineAtEofChecker` rule in Scala
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12665
[MINOR][DOCS] Update license header of LZ4BlockInputStream.java and remove
it from RAT exclusion list.
## What changes were proposed in this pull request?
`LZ4BlockInputStream.java
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214479711
Hi, @davies .
I made this PR to ask your opinion.
- Can we remove `LZ4BlockInputStream.java` from RAT exclusion file like
other files?
- Can we remove
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214483662
This PR contains only comment updates and moves, and RAT check is passed
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214559276
Oh, thank you, @srowen . It really does.
```
spark:license_header$ git diff master --name-only
dev/.rat-excludes
spark:license_header$ ./dev/check
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12677
[MINOR][BUILD] Enable RAT checking on `LZ4BlockInputStream.java`.
## What changes were proposed in this pull request?
Since `LZ4BlockInputStream.java` is not licensed to Apache
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214570700
More test cases are added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214559455
Then, is it possible to remove `LZ4BlockInputStream.java` from
`dev/.rat-excludes` in this PR?
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214572245
@davies and @srowen .
I opened a new PR #12677 to monitor `LZ4BlockInputStream.java` file
properly from now.
If we can monitor it, we had better do
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12676
[SPARK-14907][MLLIB] Use repartition in GLMRegressionModel.save
## What changes were proposed in this pull request?
This PR changes `GLMRegressionModel.save` function like
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12590#issuecomment-214449827
Hi, @rxin .
Could you review this PR please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214503106
Oh, I see. I overlooked that.
Thank you, @davies !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12426#discussion_r60977845
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -141,3 +141,8 @@ test_that("sparkJars sparkPackages as comma-separated
st
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12535#issuecomment-212583579
Hi, @JoshRosen .
Is the following merged PR is the one you mentioned by *a merge commit that
is automatically generated by GitHub*?
```bash
$ git
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12535#issuecomment-212583980
Also, the squashed PR stems from the `original` branch the PR created, not
the HEAD of master.
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12535#discussion_r60484615
--- Diff: dev/run-tests.py ---
@@ -82,6 +82,7 @@ def identify_changed_files_from_git_commits(patch_sha,
target_branch=None, targe
run_cmd
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12535#discussion_r60473390
--- Diff: dev/run-tests.py ---
@@ -82,6 +82,7 @@ def identify_changed_files_from_git_commits(patch_sha,
target_branch=None, targe
run_cmd
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/12535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12535#issuecomment-212611910
Oh, @JoshRosen and @srowen .
After a few testing, for the open PR, I found that @JoshRosen 's
explanation is correct.
I'm close this PR. Thank you
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12535#discussion_r60473551
--- Diff: dev/run-tests.py ---
@@ -82,6 +82,7 @@ def identify_changed_files_from_git_commits(patch_sha,
target_branch=None, targe
run_cmd
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12562#issuecomment-213048699
Thank you so much, @rxin and @marmbrus !
I will update soon like the following according to the comments.
- spark.sql.optimizer.minSetSize
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-213513107
Hi, @hvanhovell .
Could you give me some advice about how to handle this issue and this PR?
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214885371
Oh, thank YOU, @jkbradley .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12719
[SPARK-14939][SQL] Eliminate No-op Alias SortOrder in Sort.
## What changes were proposed in this pull request?
This issue aims to delete No-op **Alias** SortOrders in Sort
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61298823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -177,6 +177,8 @@ case class WindowExec(
case e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61295168
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -430,4 +430,13 @@ class DataFrameAggregateSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61304575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1343,17 +1343,32 @@ object DecimalAggregates
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-215182807
Hi, @srowen .
Could you merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215204718
Thank you so much, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215172349
@hvanhovell .
Thank you for squeezing your precious time for reviewing my PR several
times.
---
If your project is set up for it, you can reply
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-215209551
Thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r61216134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -894,11 +894,20 @@ object CombineFilters extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r61188095
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala
---
@@ -69,4 +69,17 @@ class
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214810333
Thank you for review, @MLnick !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12677#issuecomment-214810104
Thank you, @srowen .
I moved the package statement, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214812007
Hi, @hvanhovell .
Could you review this PR when you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12677#issuecomment-215008506
Thank you always, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215012244
Hi, @rxin .
Could you review and merge this PR?
This fixes `RuntimeException` error for Window aggregation queries.
---
If your project is set up
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60824241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60824199
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12632#issuecomment-214116801
Thank you, @rxin .
For the Java Linter, I'll keep in mind and try to fix in another way.
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12649#issuecomment-214132007
Thank you, @felixcheung !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r60854163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1321,7 +1321,9 @@ object DecimalAggregates
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12632#issuecomment-214114869
Hi, @rxin .
I'm not sure when we can turn on Jenkins Linter again.
Could you merge this PR without that?
---
If your project is set up for it, you can
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12649#discussion_r60861763
--- Diff: docs/sql-programming-guide.md ---
@@ -1138,16 +1138,16 @@ for teenName in teenNames.collect():
schemaPeople # The DataFrame from
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12632#issuecomment-214056970
Since the failed tests are disabled at
0c8e5332ff6a353a854a924ee7435708abfe0a52, I rebased again.
---
If your project is set up for it, you can reply
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12649#issuecomment-214135532
Thank you for merging, @shivaram .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214163478
The failures are `MemorySinkSuite`. It seems to be irrelevant to this PR.
I'll rebase to retrigger Jenkins.
```
[info] *** 2 TESTS FAILED ***
[error
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214138319
Oh, my bad. Today, I tried again to implement DecimalAggregate optimizer
for Windows again and handled to implement it. Last week, I think I made some
mistake
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-214057987
The test failure seems to be irrelevant to this PR.
```
[info] Exception encountered when attempting to run a suite with class
name
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-214058198
I updated the commit time of the last commit to retrigger Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-213795843
That sounds good to me. No problem!
I'll update today.
Thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12642#issuecomment-213818944
Hi, @davies .
Could you review this minor PR? It's a fix for code made by you at
[6bba750](https://github.com/apache/spark/commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12642
[MINOR][SQL] Fix error message string in nullSafeEvel of TernaryExpression
## What changes were proposed in this pull request?
TernaryExpressions should thows proper error message
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12631#discussion_r60834026
--- Diff: build/mvn ---
@@ -69,14 +69,23 @@ install_app() {
# Install maven under the build/ folder
install_mvn() {
- local
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12631#discussion_r60834332
--- Diff: build/mvn ---
@@ -69,14 +69,23 @@ install_app() {
# Install maven under the build/ folder
install_mvn() {
- local
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214207072
Hi, @hvanhovell .
Now, it's ready for review again.
Thank you so much. I couldn't fix this without your help.
---
If your project is set up for it, you
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12590#issuecomment-214217838
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-214216304
Hi, @srowen .
Now, it's ready for review again.
I think I've addressed all your comments. The last one was about `awk`
command that you recommended
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12631#issuecomment-214218617
Thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-213151964
Hi, @hvanhovell . According to your comments, I've worked this for a week,
but I'm afraid of being a bottleneck.
I feel there is a gap between *preventing
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12547#issuecomment-213156566
Thank you, @davies !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12547#issuecomment-213152900
Hi, @shivaram and @davies .
Could you review this PR and give some advice please?
---
If your project is set up for it, you can reply to this email and have
801 - 900 of 7331 matches
Mail list logo
