[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69456263 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69455189 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69453652 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69453564 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69453392 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69453309 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69449726 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69449613 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69449625 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69449264 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69447757 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69447298 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69441876 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69340420 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-06-14 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11157 @mgummelt what do you think of the latest update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #11887: [SPARK-13041][Mesos]add driver sandbox uri to the...

2016-06-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r66418456 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -68,6 +75,25 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark issue #11887: [SPARK-13041][Mesos]add driver sandbox uri to the dispat...

2016-06-09 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11887 @tnachen i will fix those. I am also waiting for the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #11887: [SPARK-13041][Mesos]add driver sandbox uri to the...

2016-06-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r66418166 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -68,6 +75,25 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request #11887: [SPARK-13041][Mesos]add driver sandbox uri to the...

2016-06-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r66418140 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -68,6 +75,25 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request #11887: [SPARK-13041][Mesos]add driver sandbox uri to the...

2016-06-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r66418176 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -115,4 +142,58 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request #11887: [SPARK-13041][Mesos]add driver sandbox uri to the...

2016-06-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r66418116 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -68,6 +75,25 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark issue #13568: [SPARK-12712] Fix failure in ./dev/test-dependencies whe...

2016-06-08 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/13568 +1 i will apply the pr and check it too thnx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-06-06 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11157 @squito thnx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-06-06 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11157 https://issues.apache.org/jira/browse/SPARK-15783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #8559: [SPARK-10372] [CORE] basic test framework for entire spar...

2016-06-06 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/8559 @squito not really check here: https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60037/ Its not only my issue and i dont think increasing timeouts is a solution. Tests

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-06-06 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11157 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-06-06 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11157 Failed due to this one: https://github.com/apache/spark/pull/13454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #8559: [SPARK-10372] [CORE] basic test framework for entire spar...

2016-06-03 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/8559 great thnx, it passes locally now. I will test my pr too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #8559: [SPARK-10372] [CORE] basic test framework for entire spar...

2016-06-03 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/8559 A test is failing: `Map(8 -> 42, 7 -> 42) was not empty ScalaTestFailureLocation: org.apache.spark.scheduler.BlacklistIntegrationSuite$$anonfun$1 at (BlacklistIntegrationSuite.sc

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-05-27 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11887#issuecomment-222111027 Not in 0.29 but soon enough. https://issues.apache.org/jira/browse/MESOS-4992 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62743938 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -395,24 +402,29 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r6272 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,229 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62744256 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,229 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62743925 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -395,24 +402,29 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-218277517 Ok but could you be more specific to your comments because its not always clear what is the problem. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62743066 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,229 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62743126 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,229 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62743042 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,229 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-218273995 But that means the admin has no control to restrict ranges on the isolates namespace --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-10 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-218273216 What i was trying to say is that even separate tasks with their own namespaces and having isolated port numbers need to honour what it is offered to them and not pick

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-09 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-217958594 But for admin/security reasons you may want to have fix port ranges offered and thus define specific ports for each task not randomly picked up. Should not we treat

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-07 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-217621412 Ok np. That also means that mesos will offer the same port on the same slave multiple times right? So if we have lets say port 1000 assigned to one executor

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-06 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-217477341 @mgummelt ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-05 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62158563 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -186,6 +190,12 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-05 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62158547 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -376,24 +386,29 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-05-05 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r62158505 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -72,13 +71,13 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-21 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-213119956 Ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-21 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60567877 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1978,57 +1978,134 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-21 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60561827 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-21 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60561580 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -154,7 +161,8 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-21 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60559591 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -75,6 +75,13 @@ private[spark] class

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-04-20 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11887#issuecomment-212461391 This will be fixed in mesos 0.29.0 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-04-20 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11887#issuecomment-212465411 WIP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-20 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-212429985 WIP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-20 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60402294 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-20 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60399111 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1978,57 +1978,134 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301970 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -45,7 +45,8 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301895 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -333,7 +350,8 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301880 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -171,7 +186,8 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301818 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301857 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301778 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301651 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301695 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301627 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-212104928 Thnx guys i will work on the above and add more info in the doc , rebase and come back. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301588 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301605 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301402 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60301188 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1978,57 +1978,134 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60299848 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1978,57 +1978,134 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60296064 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -353,4 +371,247 @@ private[mesos] trait

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60218121 --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala --- @@ -244,6 +244,7 @@ object SparkEnv extends Logging { conf.set("spark.driver

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60218050 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -75,6 +75,13 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-211870773 Thnx @mgummelt. Yes i follow that. here is the document https://docs.google.com/document/d/1UUPQBtDCuo5M10REDRJiBFa0Vws0inemxcOP9LjTACw/edit?usp=sharing --- If your

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-04-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r60215292 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -154,7 +161,8 @@ private[spark] class

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-03-22 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11887#issuecomment-200048764 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-03-22 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r57069417 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -68,6 +75,25 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-03-22 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r57069354 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -68,6 +75,25 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-03-22 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11887#issuecomment-200027126 Hive tests fail... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-03-22 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r56999019 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -115,4 +144,58 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uri to ...

2016-03-22 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11887#discussion_r56999047 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala --- @@ -76,6 +104,7 @@ private[mesos] class MesosClusterPage(parent

[GitHub] spark pull request: [SPARK-13041][Mesos]add driver sandbox uris to...

2016-03-22 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/11887 [SPARK-13041][Mesos]add driver sandbox uris to the dispatcher ui ## What changes were proposed in this pull request? Adds a sandbox link per driver in the dispatcher ui Implementation would

[GitHub] spark pull request: [SPARK-13896][SQL]Dataset.toJSON should return...

2016-03-15 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11732#issuecomment-197005610 i missed the docs ok...my bad --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13896][SQL]Dataset.toJSON should return...

2016-03-15 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/11732 [SPARK-13896][SQL]Dataset.toJSON should return Dataset[String] ## What changes were proposed in this pull request? Change the return type of toJson in Dataset class ## How was this patch

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-03-12 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-195818508 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-03-12 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-195818435 [info] *** 3 TESTS FAILED *** [error] Failed: Total 1707, Failed 3, Errors 0, Passed 1704, Ignored 596 [error] Failed tests: [error

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-03-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-195631531 updated the PR @tnachen @mgummelt, ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-03-07 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-193355137 ok i will... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-03-07 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r55236928 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -376,8 +381,10 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-29 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-190144652 Still working on this had to get aligned with @mgummelt. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13492][MESOS] Configurable Mesos framew...

2016-02-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11369#discussion_r54278192 --- Diff: docs/running-on-mesos.md --- @@ -390,6 +390,22 @@ See the [configuration page](configuration.html) for information on Spark config

[GitHub] spark pull request: [SPARK-13492][MESOS] Configurable Mesos framew...

2016-02-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11369#discussion_r54273607 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala --- @@ -95,6 +100,9 @@ private[mesos] class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182778238 done. Git fetch didnt work for the test build. Could someone re-launch it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182848295 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183061297 There are flaky tests also due to the merge those public classes should not be shown anyway... i only changed 5 files... --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183087696 Need to fix the test. Multiple executors per slave need different handling. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183007371 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-10 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/11157 [SPARK-11714][Mesos] Make Spark on Mesos honor port restrictions on coarse grain mode - Make mesos coarse grained scheduler accept port offers - Propagate them through an env var

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-02 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/10808#discussion_r51582735 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1967,39 +1967,138 @@ private[spark] object Utils extends Logging { conf

<    4   5   6   7   8   9   10   >