[GitHub] spark pull request #21527: [SPARK-24519] Make the threshold for highly compr...

2018-09-18 Thread hthuynh2
Github user hthuynh2 commented on a diff in the pull request: https://github.com/apache/spark/pull/21527#discussion_r218656012 --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala --- @@ -50,7 +50,9 @@ private[spark] sealed trait MapStatus { private[spark

[GitHub] spark issue #21953: [SPARK-24992][Core] spark should randomize yarn local di...

2018-08-02 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21953 @tgravescs I updated it. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #21936: [SPARK-24981][Core] ShutdownHook timeout causes job to f...

2018-08-02 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21936 @tgravescs I updated. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #21953: [SPARK-24992][Core] spark should randomize yarn local di...

2018-08-01 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21953 @tgravescs Can you test this please? Thank you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21953: [SPARK-24992][Core] spark should randomize yarn l...

2018-08-01 Thread hthuynh2
GitHub user hthuynh2 opened a pull request: https://github.com/apache/spark/pull/21953 [SPARK-24992][Core] spark should randomize yarn local dir selection **Description: [SPARK-24992](https://issues.apache.org/jira/browse/SPARK-24992)** Utils.getLocalDir is used to get path

[GitHub] spark pull request #21936: [SPARK-24981][Core] ShutdownHook timeout causes j...

2018-08-01 Thread hthuynh2
Github user hthuynh2 commented on a diff in the pull request: https://github.com/apache/spark/pull/21936#discussion_r206918869 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -571,7 +571,12 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] spark issue #21936: [SPARK-24981][Core] ShutdownHook timeout causes job to f...

2018-07-31 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21936 @tgravescs Can you please have a look at it? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21936: [SPARK-24981][Core] ShutdownHook timeout causes j...

2018-07-31 Thread hthuynh2
GitHub user hthuynh2 opened a pull request: https://github.com/apache/spark/pull/21936 [SPARK-24981][Core] ShutdownHook timeout causes job to fail when succeeded when SparkContext stop() not called by user program **Description** The issue is described in [SPARK-24981](https

[GitHub] spark issue #21653: [SPARK-13343] speculative tasks that didn't commit shoul...

2018-07-22 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21653 @tgravescs Can you please run the test again, thank you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21653: [SPARK-13343] speculative tasks that didn't commit shoul...

2018-07-19 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21653 @tgravescs I updated it. Can you please have a look at it when you have time. Thank you. --- - To unsubscribe, e-mail: reviews

[GitHub] spark pull request #21729: [SPARK-24755][Core] Executor loss can cause task ...

2018-07-10 Thread hthuynh2
Github user hthuynh2 commented on a diff in the pull request: https://github.com/apache/spark/pull/21729#discussion_r201412205 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -87,7 +87,7 @@ private[spark] class TaskSetManager( // Set

[GitHub] spark pull request #21729: [SPARK-24755][Core] Executor loss can cause task ...

2018-07-10 Thread hthuynh2
Github user hthuynh2 commented on a diff in the pull request: https://github.com/apache/spark/pull/21729#discussion_r201411743 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -87,7 +87,7 @@ private[spark] class TaskSetManager( // Set

[GitHub] spark pull request #21729: [SPARK-24755][Core] Executor loss can cause task ...

2018-07-10 Thread hthuynh2
Github user hthuynh2 commented on a diff in the pull request: https://github.com/apache/spark/pull/21729#discussion_r201372921 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -87,7 +87,7 @@ private[spark] class TaskSetManager( // Set

[GitHub] spark pull request #21729: [SPARK-24755][Core] Executor loss can cause task ...

2018-07-10 Thread hthuynh2
Github user hthuynh2 commented on a diff in the pull request: https://github.com/apache/spark/pull/21729#discussion_r201371752 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -87,7 +87,7 @@ private[spark] class TaskSetManager( // Set

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-09 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21729 @xuanyuanking Thanks for the comments. I also thought about modifying the UT of SPARK-22074 instead of adding new UT but I was afraid it might cause confusing since they are 2 different issues

[GitHub] spark issue #21729: SPARK-24755 Executor loss can cause task to not be resub...

2018-07-08 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21729 cc @mridulm @xuanyuanking --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21729: SPARK-24755 Executor loss can cause task to not b...

2018-07-08 Thread hthuynh2
GitHub user hthuynh2 opened a pull request: https://github.com/apache/spark/pull/21729 SPARK-24755 Executor loss can cause task to not be resubmitted **Description** As described in [SPARK-24755](https://issues.apache.org/jira/browse/SPARK-24755), when speculation is enabled

[GitHub] spark issue #21653: [SPARK-13343] speculative tasks that didn't commit shoul...

2018-07-06 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21653 @squito Thanks for the suggestions. I updated it. Could you please have a look at it to see if there is anything else I need to change? Thanks

[GitHub] spark issue #21653: [SPARK-13343] speculative tasks that didn't commit shoul...

2018-07-03 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21653 @jiangxb1987 yes, you are correct that it is actually ignored. I think it doesn't worth to add a new TaskState because we might need to add changes in many places but does not add much benefit

[GitHub] spark issue #21653: [SPARK-13343] speculative tasks that didn't commit shoul...

2018-07-02 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21653 I updated it. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21653: [SPARK-13343] speculative tasks that didn't commit shoul...

2018-06-27 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21653 cc @tgravescs --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21653: [SPARK-13343] speculative tasks that didn't commi...

2018-06-27 Thread hthuynh2
GitHub user hthuynh2 opened a pull request: https://github.com/apache/spark/pull/21653 [SPARK-13343] speculative tasks that didn't commit shouldn't be marked as success **Description** Currently Speculative tasks that didn't commit can show up as success of failures (depending

[GitHub] spark issue #21527: [SPARK-24519] Make the threshold for highly compressed m...

2018-06-20 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21527 @vanzin @squito Thank for the comments. I updated the PR, please have a look and let me know if anything need to be changed. Thank you

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-20 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21527 @tgravescs I updated it. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-19 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21527 I updated it. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-11 Thread hthuynh2
Github user hthuynh2 commented on the issue: https://github.com/apache/spark/pull/21527 @tgravescs --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21527: Spark branch 1

2018-06-11 Thread hthuynh2
GitHub user hthuynh2 opened a pull request: https://github.com/apache/spark/pull/21527 Spark branch 1 **Problem** MapStatus uses hardcoded value of 2000 partitions to determine if it should use highly compressed map status. We should make it configurable. **What