[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-16 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 Hi @dongjoon-hyun anything I can do to help move this along? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-07 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 @felixcheung SPARK_HOME has been getting filtered out since #10329 --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-06 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 Re-arranging the comments and kicking off another build.. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-06 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 > This patch fails PySpark unit tests. Is this related to my change? I wouldn't expect the PySpark unit tests to be using the RestSubmissionClient, but I don't really k

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-06 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 Added test cases, and also refactored RestSubmissionClient to put the blacklisted spark vars in a Set so its easier to read

[GitHub] spark pull request #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_...

2018-11-06 Thread mpmolek
Github user mpmolek commented on a diff in the pull request: https://github.com/apache/spark/pull/22937#discussion_r231226354 --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala --- @@ -418,8 +418,8 @@ private[spark] object RestSubmissionClient

[GitHub] spark pull request #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_...

2018-11-03 Thread mpmolek
GitHub user mpmolek opened a pull request: https://github.com/apache/spark/pull/22937 [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR from spark submit ## What changes were proposed in this pull request? Don't propagate SPARK_CONF_DIR to the driver in mesos cluster