[GitHub] spark issue #23209: [SPARK-26256][K8s] Fix labels for pod deletion

2018-12-03 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/23209 @srowen I resolved the conflicts feel free to merge. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #23209: [SPARK-26256][K8s] Fix labels for pod deletion

2018-12-03 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/23209 [SPARK-26256][K8s] Fix labels for pod deletion ## What changes were proposed in this pull request? Adds proper labels when deleting executor pods. ## How was this patch tested

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

2018-12-03 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/23136 @liyinan926 updated the PR,here is the [jira](https://issues.apache.org/jira/browse/SPARK-26256) for the bug wil create a PR for it shortly

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-29 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r237643173 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-29 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r237642388 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala --- @@ -30,7 +30,7

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

2018-11-28 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/23136 tests failed but not due to this PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

2018-11-28 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/23136 @mccheah gentle ping. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

2018-11-27 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/23136 Fixed that failing test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236488306 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236485835 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236457049 --- Diff: docs/running-on-kubernetes.md --- @@ -926,6 +926,13 @@ specific to Spark on Kubernetes. spark.kubernetes.executor.podTemplateFile=/path

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236456591 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236432458 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManagerSuite.scala --- @@ -100,6

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

2018-11-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/23136 @erikerlandson @mccheah pls review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236089683 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala --- @@ -82,11

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

2018-11-25 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/23136 [SPARK-25515][K8s] Adds a config option to keep executor pods for debuging ## What changes were proposed in this pull request? Keeps K8s executor resources present if case of failure or normal

[GitHub] spark issue #18784: [SPARK-21559][Mesos] remove mesos fine-grained mode

2018-11-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/18784 @imaxxs @rxin I think its a good time to remove this, I will update the PR if you are all ok. --- - To unsubscribe, e-mail

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233216872 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233166698 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233002403 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232980913 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232852693 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232847703 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232847435 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232846926 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,60 @@ unaligned = _unaligned

[GitHub] spark pull request #22915: [SPARK-25825][K8S][WIP] Enable token renewal for ...

2018-11-08 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22915#discussion_r232113698 --- Diff: docs/security.md --- @@ -798,6 +782,50 @@ achieved by setting `spark.kubernetes.hadoop.configMapName` to a pre-existing Co local:///opt

[GitHub] spark issue #22931: [SPARK-25930][K8s] Fix scala string detection in k8s tes...

2018-11-05 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22931 @srowen any update on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22931: [SPARK-25930][K8s] Fix scala string detection in k8s tes...

2018-11-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22931 @srowen I guess yes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22931: [SPARK-25930][K8s] Fix scala string detection in k8s tes...

2018-11-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22931 @vanzin modified it. Much better. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22931: [SPARK-25930][K8s] Fix scala string detection in k8s tes...

2018-11-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22931 @vanzin ok let me try that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22931: [SPARK-25930][K8s] Fix scala string detection in k8s tes...

2018-11-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22931 @srowen pls review. We missed that, kind of tricky. Making mvn silent is not that easy from what I checked, now I think this is robust enough

[GitHub] spark pull request #22931: [SPARK-25930][K8s] Fix scala string detection in ...

2018-11-02 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/22931 [SPARK-25930][K8s] Fix scala string detection in k8s tests ## What changes were proposed in this pull request? - Issue is described in SPARK-25930. Since we rely on the output pick always

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228494668 --- Diff: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh --- @@ -103,4 +104,4 @@ then properties=( ${properties

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22838 Tests failing are unrelated, some flaky hive test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22838 @srowen I think now we are aligned. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22829 ok seems this to be closed. I will copy it to the other PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228318094 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228317925 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228316721 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core

[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228314627 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22838 @srowen pls review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/22838 [SPARK-25835][K8s] fix issues with k8s tests ## What changes were proposed in this pull request? - Fixes the scala version propagation issue. - Disables the tests under the k8s profile

[GitHub] spark pull request #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Clie...

2018-10-24 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22820#discussion_r228005475 --- Diff: resource-managers/kubernetes/core/pom.xml --- @@ -29,7 +29,7 @@ Spark Project Kubernetes kubernetes -3.0.0

[GitHub] spark pull request #22820: [SPARK-25828][K8S] Bumping Kubernetes-Client vers...

2018-10-24 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22820#discussion_r228003809 --- Diff: resource-managers/kubernetes/core/pom.xml --- @@ -29,7 +29,7 @@ Spark Project Kubernetes kubernetes -3.0.0

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-23 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22805 @rvesse I use no vm: `sudo -E ./minikube start --vm-driver=none` --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-23 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22805 @rvesse also the following memory limit works for me: `minikube config set memory 4096` so maybe g its too much

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-23 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22805 @rvesse this capability was in the old integration tests repo [here](https://github.com/apache-spark-on-k8s/spark-integration/blob/master/src/test/scala/org/apache/spark/deploy/k8s/integrationtest

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-10-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r226643416 --- Diff: docs/running-on-kubernetes.md --- @@ -799,4 +815,168 @@ specific to Spark on Kubernetes. This sets the major Python version of the docker

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-10-19 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r226642833 --- Diff: docs/running-on-kubernetes.md --- @@ -799,4 +815,168 @@ specific to Spark on Kubernetes. This sets the major Python version of the docker

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-10-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 Thanx @vanzin! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-10-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @vanzin didn't mean to press or anything :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-10-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @vanzin ready to merge. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-10-15 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @vanzin thanx for the review I think It looks ok now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-10-15 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r225339134 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +391,38 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-10-15 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r225339052 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +391,38 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-10-15 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r225339164 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusSource.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-10-15 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @vanzin could I get a merge pls? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22639: [SPARK-25647][k8s] Add spark streaming compatibil...

2018-10-11 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22639#discussion_r224451681 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/StreamingCompatibilitySuite.scala

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-10-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r224071384 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusSource.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-10-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r224071170 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -280,6 +284,11 @@ private[spark] class AppStatusListener

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-10-10 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 Thanx a lot @aditanase ! I will update the PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-10-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r224070656 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusSource.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-24 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @vanzin AFAIK the operations just update metrics in the underlying dropwizard metrics library. I dont htink anything is shipped anywhere. How should I proceed? Is there anyone who is familiar

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-18 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @srowen integration tests seem so flaky! Seen this before? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-17 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22392 @liyinan926 @ssaavedra one thing I just noticed is that if you restart the driver and initially you didnt set spark.executorEnv. then if you set it when you restart the job, it has no effect

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-17 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 jenkins, test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-17 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 test failure is irrelevant. jenkins, test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-17 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22392 @ssaavedra just check this with streaming it works fine. I used the following code jus tin case you want to repeat the test: https://gist.github.com/skonto/12217e93e7e9272365eb978025d42a4c

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-17 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @erikerlandson I added an option to disable them, by default they are now disabled. Is it possible to move forward with this? @srowen ? Btw I removed any code triggered by this unless explicitly

[GitHub] spark pull request #22392: [SPARK-23200] Reset Kubernetes-specific config on...

2018-09-17 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22392#discussion_r218056207 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -54,6 +54,10 @@ class Checkpoint(ssc: StreamingContext, val

[GitHub] spark pull request #22392: [SPARK-23200] Reset Kubernetes-specific config on...

2018-09-17 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22392#discussion_r218002553 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -54,6 +54,10 @@ class Checkpoint(ssc: StreamingContext, val

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-14 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r217672239 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala --- @@ -503,9 +503,12 @@ private[spark] object AppStatusStore

[GitHub] spark issue #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22405 Thanks @liyinan926! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @erikerlandson I dont any tests for sources AFAIK, they exist for the metric system itself. From the commit history this look like an old feature. Regarding enabling or disabling them

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217215209 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala --- @@ -167,13 +167,23

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217214888 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,18

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217214065 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,18

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217213999 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,18

[GitHub] spark issue #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22405 jenkins, test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22405 tests fixed... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22405 @liyinan926 the prefix is defined as: ``` val kubernetesResourceNamePrefix = { s"$appName-$launchTime".toLowerCase.replaceAll("\\.", "-") }```

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217189938 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217189066 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 ok will do. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @srowen I was checking git history and I see that you merged this one: https://github.com/apache/spark/pull/22218 again related to metrics. Could you call someone who can do the merge

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217170079 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17

[GitHub] spark issue #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22405 @liyinan926 @mccheah pls review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/22405 [SPARK-25295][K8S]Fix executor names collision ## What changes were proposed in this pull request? Fixes the collision issue with spak executor names in client mode. Also fixes the issue

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-09-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22146 @onursatici I tried the PR and it works so far. We can keep the convention let's hope users will be careful.Would it possible to add some tests like sidecar tests to examine containers setup etc

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-11 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @srowen thanks is there someone I could call? @vanzin ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-11 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22381 @srowen @xuanyuanking ready for another round. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216496620 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +392,37 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216476831 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +392,37 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216472252 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +392,37 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216470277 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusSource.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216469838 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +392,37 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216465915 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -382,11 +392,37 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216431046 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -560,6 +561,7 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216430860 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -280,6 +284,12 @@ private[spark] class AppStatusListener

[GitHub] spark pull request #22381: [SPARK-25394][CORE] Add an application status met...

2018-09-10 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22381#discussion_r216430819 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusSource.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

  1   2   3   4   5   6   7   8   9   10   >