[GitHub] spark issue #23254: [SPARK-26304][SS] Add default value to spark.kafka.sasl....

2018-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23254 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23252: [SPARK-26239] File-based secret key loading for SASL.

2018-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23252 (Also, another nit, Spark authentication is not necessarily SASL-based.) --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #23221: [SPARK-24243][CORE] Expose exceptions from InProcessAppH...

2018-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23221 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r239903144 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239898432 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -380,6 +400,12 @@ private[spark] class SecurityManager

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239899856 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -112,12 +112,14

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r23991 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239900712 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -24,7 +24,7 @@ import

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239897958 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -367,11 +372,26 @@ private[spark] class SecurityManager( case

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239900460 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala --- @@ -158,6 +161,25

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239900826 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -18,8 +18,11 @@ package org.apache.spark import

[GitHub] spark pull request #23174: [SPARK-26194][k8s] Auto generate auth secret for ...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23174#discussion_r239895212 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -87,44 +88,61

[GitHub] spark pull request #23174: [SPARK-26194][k8s] Auto generate auth secret for ...

2018-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23174#discussion_r239892984 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -87,44 +88,61

[GitHub] spark issue #23221: [SPARK-24243][CORE] Expose exceptions from InProcessAppH...

2018-12-06 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23221 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #23241: [SPARK-26283][CORE] Enable reading from open fram...

2018-12-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23241#discussion_r239609592 --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala --- @@ -197,4 +201,8 @@ class ZStdCompressionCodec(conf: SparkConf) extends

[GitHub] spark issue #23195: [SPARK-26236][SS] Add kafka delegation token support doc...

2018-12-06 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23195 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r239272037 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark issue #23241: [SPARK-26283][CORE]When zstd compression enabled, Inprog...

2018-12-05 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23241 Please use the PR title and summary to describe the solution, not the problem. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22904: [SPARK-25887][K8S] Configurable K8S context support

2018-12-05 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22904 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22904: [SPARK-25887][K8S] Configurable K8S context support

2018-12-05 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22904 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r239177994 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,199 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark issue #23221: [SPARK-24243][CORE] Expose exceptions from InProcessAppH...

2018-12-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23221 I applied my own feedback to the original PR and will merge pending tests (since it was already reviewed), unless someone comments first

[GitHub] spark pull request #23221: [SPARK-24243][CORE] Expose exceptions from InProc...

2018-12-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/23221 [SPARK-24243][CORE] Expose exceptions from InProcessAppHandle ## What changes were proposed in this pull request? Adds a new method to SparkAppHandle called getError which returns

[GitHub] spark pull request #23220: [SPARK-25877][k8s] Move all feature logic to feat...

2018-12-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/23220 [SPARK-25877][k8s] Move all feature logic to feature classes. This change makes the driver and executor builders a lot simpler by encapsulating almost all feature logic into the respective

[GitHub] spark issue #23092: [SPARK-26094][CORE][STREAMING] createNonEcFile creates p...

2018-12-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23092 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238798656 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,57 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238798169 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,57 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238799671 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,57 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark issue #23088: [SPARK-26119][CORE][WEBUI]Task summary table should cont...

2018-12-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23088 Merging to master / 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r238780494 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -20,20 +20,22 @@ import

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r238780744 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238776692 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,56 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r238502012 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r238484698 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark issue #23037: [SPARK-26083][k8s] Add Copy pyspark into corresponding d...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23037 I thought there was already one for that Hive suite failing... SPARK-23622? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 I looked at the test failure, but the logs weren't super useful. This passed locally, but let me retrigger here

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > It matters because we're discussing direction I'm not, you guys are. I'm adding a missing feature with one particular implementation. If you want to add other implementations that ena

[GitHub] spark issue #23037: [SPARK-26083][k8s] Add Copy pyspark into corresponding d...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23037 ok, I give up on flaky tests. Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > with the caveat that we merge the subsequent optionality soon Again, and sorry for pounding on that key, but why does that matter? It has zero effect on the feature being added h

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 I don't understand what you want. Without this change, auth does not work, period. With this, users at least have one choice. If you want to add another choice, you're free

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 As I suggested before, any alternative method can be added later. I don't see why does it need to block this PR

[GitHub] spark issue #23191: [SPARK-26219][CORE][branch-2.4] Executor summary should ...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23191 Merging to 2.4. Please close the PR manually. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23209: [SPARK-26256][K8s] Fix labels for pod deletion

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23209 Actually I forgot 2.4... there's also a conflict. Seems trivial, so I'll do it manually and fix the conflict (and run some local tests

[GitHub] spark issue #23209: [SPARK-26256][K8s] Fix labels for pod deletion

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23209 Merging to master / 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 So, can we move forward with this and let any future new feature be handled in SPARK-26239? --- - To unsubscribe, e-mail

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22911 on a non-testing not, any further feedback here? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22911 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22911 there was a seemingly corrupt xml file in the jenkins worker, I removed it and will retest. --- - To unsubscribe, e-mail

[GitHub] spark pull request #23172: [SPARK-25957][followup] Build python docker image...

2018-12-03 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/spark/pull/23172 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23172: [SPARK-25957][followup] Build python docker image in sbt...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23172 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r238440694 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r238439850 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -67,8 +66,16 @@ private

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Skips Python resource limit on Win...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23055 (Belated +1.) Doc update looks fine. The previous one was misleading for reasons that Ryan explains above, it has nothing to do with whether it's Windows

[GitHub] spark issue #23037: [SPARK-26083][k8s] Add Copy pyspark into corresponding d...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23037 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23088: [SPARK-26119][CORE][WEBUI]Task summary table should cont...

2018-12-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23088 Also it would be good to open a separate bug to address the fix for SHS / disk store. --- - To unsubscribe, e-mail: reviews

[GitHub] spark pull request #23088: [SPARK-26119][CORE][WEBUI]Task summary table shou...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23088#discussion_r238406928 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala --- @@ -148,11 +148,20 @@ private[spark] class AppStatusStore

[GitHub] spark pull request #23088: [SPARK-26119][CORE][WEBUI]Task summary table shou...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23088#discussion_r238407621 --- Diff: core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala --- @@ -77,6 +77,34 @@ class AppStatusStoreSuite extends SparkFunSuite

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238398453 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,56 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238399535 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,56 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238399808 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,56 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark pull request #23195: [SPARK-26236][SS] Add kafka delegation token supp...

2018-12-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23195#discussion_r238399719 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -624,3 +624,56 @@ For experimenting on `spark-shell`, you can also use `--packages` to add

[GitHub] spark issue #23037: [SPARK-26083][k8s] Add Copy pyspark into corresponding d...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23037 Actually I lied. Could you update the `create_dev_build_context` function in `docker-image-tool.sh` to copy this new directory? You can run the script from your build directory to test

[GitHub] spark issue #23037: [SPARK-26083][k8s] Add Copy pyspark into corresponding d...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23037 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23181: [SPARK-26219][CORE] Executor summary should get updated ...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23181 This didn't merge cleanly to 2.4, please open a PR against that branch if you want it there. --- - To unsubscribe, e-mail

[GitHub] spark issue #23181: [SPARK-26219][CORE] Executor summary should get updated ...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23181 Merging to master / 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 I filed SPARK-26239. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > A proposed scheme is to have spark.authenticate.k8s.secret.provider=autok8ssecret If you're going to add a different way to get the auth secret later, then you can introduce that opt

[GitHub] spark issue #23189: [SPARK-26235][Core] Change log level for ClassNotFoundEx...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23189 Sounds ok. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > The way it's written now Code can change after it's written... > If this change is merged into 3.x without any other changes, users will be forced to use the K8s secret

[GitHub] spark issue #23189: [SPARK-26235][Core] Change log level for ClassNotFoundEx...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23189 > The logWarning call as the other handler below is also not overridden: It is. I even copied & pasted the code. I made the change locally and this is what happens: ```

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > while leaving it an exercise for the reader to understand how to properly run spark such that the secrets are actually secured. I don't think that's an exercise for the u

[GitHub] spark pull request #23181: [SPARK-26219][CORE] Executor summary should get u...

2018-11-30 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23181#discussion_r237952522 --- Diff: core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala --- @@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends

[GitHub] spark pull request #23181: [SPARK-26219][CORE] Executor summary should get u...

2018-11-30 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23181#discussion_r237952479 --- Diff: core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala --- @@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends

[GitHub] spark issue #23189: [SPARK-26235][Core] Change log level for ClassNotFoundEx...

2018-11-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23189 Actually the problem is here: ``` case e: ClassNotFoundException => logWarning(s"Failed to load $childMainClass.", e) ``` That particula

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Skips Python resource limit...

2018-11-30 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r237941472 --- Diff: docs/configuration.md --- @@ -190,6 +190,8 @@ of the most common options to set are: and it is up to the application to avoid exceeding

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22598 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r237723350 --- Diff: python/pyspark/worker.py --- @@ -22,7 +22,12 @@ import os import sys import time -import resource +# 'resource' is a Unix

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r237716326 --- Diff: python/pyspark/worker.py --- @@ -22,7 +22,12 @@ import os import sys import time -import resource +# 'resource' is a Unix

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r237714454 --- Diff: python/pyspark/worker.py --- @@ -22,7 +22,12 @@ import os import sys import time -import resource +# 'resource' is a Unix

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r237715129 --- Diff: python/pyspark/worker.py --- @@ -22,7 +22,12 @@ import os import sys import time -import resource +# 'resource' is a Unix

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r237715021 --- Diff: python/pyspark/worker.py --- @@ -22,7 +22,12 @@ import os import sys import time -import resource +# 'resource' is a Unix

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r237659299 --- Diff: core/src/main/scala/org/apache/spark/internal/config/Kafka.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #23037: [SPARK-26083][k8s] Add Copy pyspark into corresponding d...

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23037 When I tried to write automated tests for pyspark in the past it was kind of a pain. It doesn't work the way you expect unless you have a pseudo-terminal, apparently. Maybe try to write

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r237620523 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r237620333 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -688,4 +688,65 @@ package object config { .stringConf

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r237622443 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSecurityHelperSuite.scala --- @@ -0,0 +1,100

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r237617706 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -494,13 +494,12 @@ class SparkSubmitSuite } test

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 (In fact, env variables don't even show up in the UI or event logs, as far as I can see. Other configs - Spark config, system properties, e.g. - do show up, and are redacted to mask secrets

[GitHub] spark issue #23017: [SPARK-26015][K8S] Set a default UID for Spark on K8S Im...

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23017 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23158: [SPARK-26186][SPARK-26184][CORE] Last updated time is no...

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23158 Merging to master / 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > if the secret would be listed under the environment variables in the Spark UI Secrets are redacted in the UI and event logs. We already use env variables in other contexts (

[GitHub] spark pull request #22959: [SPARK-25876][k8s] Simplify kubernetes configurat...

2018-11-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22959#discussion_r237587099 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala --- @@ -112,125 +72,139 @@ private[spark] case

[GitHub] spark issue #23174: [SPARK-26194][k8s] Auto generate auth secret for k8s app...

2018-11-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23174 > via a mounted file > Also the user should be able to specify their own mounted file The point is that the user shouldn't need to set this at all. You enable auth, Spark take

[GitHub] spark pull request #23158: [SPARK-26186][SPARK-26184] Last updated time is n...

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23158#discussion_r237293492 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -334,6 +334,42 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request #23058: [SPARK-25905][CORE] When getting a remote block, ...

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23058#discussion_r237284719 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -718,13 +718,9 @@ private[spark] class BlockManager

[GitHub] spark pull request #23158: [SPARK-26186][SPARK-26184] Last updated time is n...

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23158#discussion_r237280881 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -334,6 +334,42 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request #23158: [SPARK-26186][SPARK-26184] Last updated time is n...

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23158#discussion_r237280935 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -334,6 +334,42 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request #23172: [SPARK-25957][followup] Build python docker image...

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23172#discussion_r237276972 --- Diff: project/SparkBuild.scala --- @@ -494,7 +494,12 @@ object KubernetesIntegrationTests { dockerBuild := { if (shouldBuildImage

[GitHub] spark pull request #23174: [SPARK-26194][k8s] Auto generate auth secret for ...

2018-11-28 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/23174 [SPARK-26194][k8s] Auto generate auth secret for k8s apps. This change modifies the logic in the SecurityManager to do two things: - generate unique app secrets also when k8s is being

  1   2   3   4   5   6   7   8   9   10   >