LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-897430503
> @LuciferYang Caffeine is definitely an amazing and popular project. But
when we decide whether we should add a library , especially a popular library,
to Spark, we also
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-896607723
> The benchmark, etc. here look promising. My only concern is that hidden
behaviour changes by switching the library. Do they claim compatibility vs
Guava at least?
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-896504990
Thank you for your review @gatorsmile ~
On the one hand, I think the main purpose of using Guava cache in the code
is to solve the problem of hot path access, so I
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-893113204
@holdenk thanks all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-893113204
@holdenk thanks all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-888779189
@holdenk 6c74fc6 merge with master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-887333011
waiting https://github.com/apache/spark/pull/33533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-883942834
@holdenk c6b9dc6 merge with master and waiting for Jenkins build,
It seems that GA is unstable, and many pr have similar failures
--
This is an automated
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-871936677
> Yes, Apache Spark 3.2 will be the first release having Scala 2.13
additionally.
> After branch cut, I'll try to switch the default to Scala 2.13 in master
branch.
>
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-871936226
> Take your time, @LuciferYang . This should target Apache Spark 3.3 because
Apache Spark 3.2 branch cut is July 1st.
>
> There are some busy cases today, we'll try
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-871935280
@dongjoon-hyun A question unrelated to this pr, do we have plans to make
Scala 2.13 as default？
--
This is an automated message from the Apache Git Service.
To respond to
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-871932774
ok ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-871334995
There are some busy cases today, we'll try to fix the ignored case tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please
LuciferYang commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-869374332
@holdenk I've updated this pr to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
14 matches
Mail list logo
