[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654781966 no, since there are subtle but important differences and the respective APIs are easy to find right alongside one another on the Spark docs website. I can

[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654710558 Note that this PR only changes the docstrings in the SQL API, AFAIK SQL doesn't support named arguments

[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654702101 `fmt` could very clearly not mean any of those things in this context  Further, spelled-out `format` is written in the plain-English usage section of every one

[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-06 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654292711 > That's all of them? In fact I found one more (in `from_unixtime`). Fixed now. Pattern searched: > `usage[^)]*format`