[GitHub] [spark] peter-toth commented on pull request #41677: [WIP][SPARK-35564][SQL] Improve subexpression elimination

2023-06-23 Thread via GitHub
peter-toth commented on PR #41677: URL: https://github.com/apache/spark/pull/41677#issuecomment-1603934838 The failure in `[Run / Linters, licenses, dependencies and documentation generation]` seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] peter-toth commented on pull request #41677: [WIP][SPARK-35564][SQL] Improve subexpression elimination

2023-06-21 Thread via GitHub
peter-toth commented on PR #41677: URL: https://github.com/apache/spark/pull/41677#issuecomment-1601377122 > Removing the "branch groups" definitely simplifies things though if we're just willing to make those be conditional uses instead No, I mean although I removed `branchGroups`

[GitHub] [spark] peter-toth commented on pull request #41677: [WIP][SPARK-35564][SQL] Improve subexpression elimination

2023-06-21 Thread via GitHub
peter-toth commented on PR #41677: URL: https://github.com/apache/spark/pull/41677#issuecomment-1601278842 > This hurts my brain thinking about probabilistic conditional evaluations, and I feel like the subexpression elimination logic is already overly complicated. If I wanted to just

[GitHub] [spark] peter-toth commented on pull request #41677: [WIP][SPARK-35564][SQL] Improve subexpression elimination

2023-06-21 Thread via GitHub
peter-toth commented on PR #41677: URL: https://github.com/apache/spark/pull/41677#issuecomment-1600838718 This PR is still WIP because I want to add more tests, but @Kimahriman, @cloud-fan, @rednaxelafx, @ulysses-you, @viirya, @wankunde you might be interrested... -- This is an