srielau commented on code in PR #38569:
URL: https://github.com/apache/spark/pull/38569#discussion_r1017369097
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -469,6 +469,11 @@
"Grouping sets size cannot be greater than <maxSize>"
]
},
+ "GROUP_BY_AGGREGATE" : {
Review Comment:
I like it that they are distinct. GROUP_BY_POS_... might be fat fingering,
GROUP_BY_AGGREGATE is: You don't know how GROUP BY works...
Have reviewed? GROUP_BY_POS_REFERS_AGG_EXPR... that's not very pretty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
