[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 Thanks @sethah @yanboliang for the reviews!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 @yanboliang Would appreciate it if you could look at https://github.com/apache/spark/pull/13650 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/13981 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61765/ Test PASSed. ---

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61765/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61764/ Test PASSed. ---

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61764/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61762/ Test PASSed. ---

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61762/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61765/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 OK, that should be it. I removed all the unused variables and imports. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61764/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61762/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 @yanboliang Thanks! Addressed your comments. Let me know if there is anything else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/13981 @MechCoder I left some inline comments. Thanks for adding this test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61641/ Test PASSed. ---

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61641/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 I'm slightly in favour of keeping the original test because the impurity is set to "variance" explicitly by the `setImpurity` method, so it's a safe assumption that the `calculate` method returns

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61641/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user sethah commented on the issue: https://github.com/apache/spark/pull/13981 @MechCoder I'm not sure how I feel about leaving the original test, which will fail if another impurity is added and IMO isn't really correct. Thoughts? --- If your project is set up for it, you

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61628/ Test PASSed. ---

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61628/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61628/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 @sethah Thank you for your comments. I have addressed them. Do you have anything else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user sethah commented on the issue: https://github.com/apache/spark/pull/13981 @MechCoder Thanks for adding this! I think it's a good test to protect against silent failures in the future. I just left a few small comments. --- If your project is set up for it, you can reply

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61507/ Test PASSed. ---

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61507/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61507/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 @yanboliang Could you have a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature