Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14004
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Oops. You already did. Thank you, @cloud-fan .
And, thank you, @rxin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Hi, @cloud-fan .
Could you merge this `sentences` PR, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61969/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61969/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Thank you for review again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61969 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61969/consoleFull)**
for PR 14004 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14004
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14004
This looks alright. I left some minor comments. Please move this out of the
regex file. Seems like it should go into stringExpressions file.
---
If your project is set up for it, you can reply to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Hi, @rxin .
Could you review and merge this `sentences` PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61920/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61920/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61920/consoleFull)**
for PR 14004 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14004
and one comment for the old thread:
https://github.com/apache/spark/pull/14004#discussion_r69893328
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Hi, @cloud-fan .
Finally, it passed again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61899/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61899/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61895/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61895 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61895/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61899/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61895 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61895/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Thank you, @cloud-fan .
I updated the PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14004
LGTM except some style comment, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
If you think `UTF8String.sentences` is needed, please let me know. I'll
recover again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61832/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61832 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61832/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61829/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61829 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61829/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61827/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61827 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61827/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Hi, @cloud-fan . I've updated the PR. The following is a summary of changes.
- To support `sentence('', null, null)`, `Sentences` extends `Expression`
instead of `TerneryExpression`.
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61832 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61832/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61829 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61829/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61827 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61827/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61818/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61818 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61818/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61816/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61816 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61816/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
By the way, I found that `TernaryExpression.eval` seems not compatible for
`sentences('', null, null)`.
I'll let you know after finishing the update.
---
If your project is set up for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61807/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61807/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
If then, I will reposition that.
Do you mean `making a new java file containing not-really-UTF8String`
function?
---
If your project is set up for it, you can reply to this email and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Oh, @cloud-fan .
Is there some misunderstanding?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Now, the PR became more concise. Thank you for decision, @cloud-fan .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61818 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61818/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61816 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61816/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61807/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61710/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61710/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61710/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61694/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61694/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61694/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Rebased to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61680/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61680/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61680/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61664/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61664 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61664/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61664 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61664/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Just rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
cc @rxin and @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61590/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61590/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61590/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61575/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61575/consoleFull)**
for PR 14004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61575/consoleFull)**
for PR 14004 at commit
84 matches
Mail list logo
