Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
I created the JIRA issue. I'll make a PR soon.
https://issues.apache.org/jira/browse/SPARK-19910
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Ah, I see the case. Hive allows NULL. I'll try to support the NULL case.
Thanks, @cloud-fan .
```sql
hive> select stack(3, 1, 'a', 2, 'b', 3, 'c');
OK
1 a
2 b
3 c
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14033
let's follow hive, e.g. `select stack(2, 1, null, 3, 2)` can process
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Do you mean the column-wise type coercion to support the following?
```
hive> select stack(2,1,'a',3,2);
FAILED: UDFArgumentException Argument 2's type (string) should be equal to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Oh, I'll look at that, @cloud-fan .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14033
just found out that we didn't implement a type coercion rule for `stack`...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Thank you for merging, @cloud-fan !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14033
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61796/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61796/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61796/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61777/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61777/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61769/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61769 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61769/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61777 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61777/consoleFull)**
for PR 14033 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Master branch is broken now. I'll retry to test later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61772/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61772/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Now, the testcase became much stronger.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61772/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61759/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61759/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61769 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61769/consoleFull)**
for PR 14033 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Hi, @cloud-fan .
I added `toArray` and couldn't add type-checking tests on expression-level
suite.
I hope that is okay for you. If not, please let me know.
---
If your project is set
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
It's my pleasure. I'm still learning Spark. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14033
LGTM except some minor comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Thank you so much always, @cloud-fan !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61759/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61741/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61742/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61742/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61741/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61742/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61741/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61729/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61729 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61729/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61729/consoleFull)**
for PR 14033 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Thank you for fast review always, @cloud-fan !
I fixed one of three comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61721/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61721/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61721/consoleFull)**
for PR 14033 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Hi, @cloud-fan .
I rewrote the testcases and logics.
I squashed the commits into a single one because the diff became messy.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61709/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61709 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61709/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61707/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61707 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61707/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61705/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61705/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61709/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61707/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61705/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61696/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61696/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61696/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61693/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61693/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61693/consoleFull)**
for PR 14033 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
cc @rxin and @cloud-fan .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Rebased to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61675/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61675 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61675/consoleFull)**
for PR 14033 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61675 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61675/consoleFull)**
for PR 14033 at commit
79 matches
Mail list logo
