Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
@HyukjinKwon didn't have bandwidth will try to finish this weekend
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14036
@techaddict How is the perf test going?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14036
Having a query just to test this expression is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
@yhuai sure, doing performance testing using sql query or expression ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14036
@techaddict Can you test the performance with and without your change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14036
last 2 comments. @liancheng @clockfly can you also take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62224/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62224/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62224/consoleFull)**
for PR 14036 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
@cloud-fan Done ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14036
LGTM except 2 naming comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62213/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62213/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62212/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62212/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62213/consoleFull)**
for PR 14036 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
@cloud-fan Updated the PR, all tests should pass now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62212/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62179/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62179/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62177/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62177 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62177/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62176/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62176/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62179/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62177 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62177/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62176/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62093/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62093/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #62093 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62093/consoleFull)**
for PR 14036 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
@rxin @cloud-fan done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61857/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61857 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61857/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61857 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61857/consoleFull)**
for PR 14036 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14036
OK I think it's fine to add it in SQL for compatibility but I wouldn't add
functions in the DataFrame API for that.
---
If your project is set up for it, you can reply to this email and have your
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14036
@rxin , the `/` in hive/mysql means fraction division, e.g. `3 / 2` will
get `1.5`. And the `div` is a special operator for integral division, `3 div 2`
will get `1`.
In spark sql we
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61766/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61766/consoleFull)**
for PR 14036 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14036
@techaddict why do we need to introduce a new user facing function for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61766/consoleFull)**
for PR 14036 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
@cloud-fan addressed all your comments ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61706/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61706 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61706/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61706/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61695/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61695/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61695/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61692/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61692/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61692/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61689/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61689/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61689/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61686/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61686/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61686/consoleFull)**
for PR 14036 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61682 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61682/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61682/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61682 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61682/consoleFull)**
for PR 14036 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
cc: @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
75 matches
Mail list logo
