[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16252 merged to master/2.1/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-17 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/16252 @srowen I have restored it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70308/ Test PASSed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70308/testReport)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70308/testReport)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16252 Thanks, so @wangyum I think you can restore that `!unrolled.hasNext` check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-15 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16252 @srowen I am fine for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16252 OK, do we have consensus to put the hasNext check back? before we ask @wangyum to change again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70137/ Test PASSed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70137/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70137/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16252 cc @zsxwing also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16252 Thanks for submitting this. We need a much better description for both the JIRA ticket and the pull request. If I understand it correctly, you are fixing an issue to support broadcasting blocks that

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16252 @wangyum Thanks! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/16252 @srowen @viirya I have added it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70080/ Test PASSed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70080/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16252 +1 > @wangyum how about adding @viirya 's suggested change to TorrentBroadcast? it would be even more robust. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70080/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16252 @wangyum how about adding @viirya 's suggested change to TorrentBroadcast? it would be even more robust. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70055/ Test PASSed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70055 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70055/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70055 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70055/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/16252 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/16252 `org.apache.spark.sql.kafka010.KafkaSourceStressForDontFailOnDataLossSuite.stress test for failOnDataLoss=false` has succeeded on my local test. --- If your project is set up for it, you can

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70022/ Test FAILed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70022/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70022/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70019/ Test FAILed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70019/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70019/consoleFull)** for PR 16252 at commit

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16252 cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16252 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70004/ Test FAILed. ---

[GitHub] spark issue #16252: [SPARK-18827][Core] Fix cannot read broadcast on disk

2016-12-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16252 **[Test build #70004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70004/consoleFull)** for PR 16252 at commit