Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
I have created a PR at [https://github.com/apache/spark/pull/16868](url),
please review it, Thanks! @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
OK. I'll try it immediately. Thank U very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
You might be able to make it by forcefully pushing the new changes by `git
push -f origin NEW_BRANCH:REMOTE_BRANCH `
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
No worry, open/submit a new PR. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
Oh, I See, I miss a step âgit remote add upstream ...â.
But now, I have delete my repository in my profile. So this PR canât know
which repository should be associated. So, do u
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
You do not need to do the step 1 every time. You might miss the following
two steps when you want to resolve your conflicts.
> git fetch upstream
> git merge upstream/master
---
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
Here's how I create a PR:
1.fork the master of Apache;
2.create a new branch in my master branch
3.select my new branch menu and create a new PR.
4.edit my new branch code.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
You might not be familiar with the Github/Git. How about submitting a new
PR? : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
My master branch with the master of Apache is not synchronized, and then I
did the pull operation, my master branch still not synchronized, and finally I
removed my remote repository.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
Your master is clean (i.e., exactly identical to the upstream/master),
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
Should I delete my local master repository firstlyï¼and fork a new one
again? @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72576/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #72576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72576/testReport)**
for PR 16638 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16638
you can start with a new branch and apply the changes manually, e.g. copy
code from this PR to the new branch.
---
If your project is set up for it, you can reply to this email and have your
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
I met some troubles when I resolving the conflict, So can u give me some
guidances? Thanks a lot! @cloud-fan
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #72576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72576/testReport)**
for PR 16638 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72550/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #72550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72550/testReport)**
for PR 16638 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16638
please resolve the conflict too, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #72550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72550/testReport)**
for PR 16638 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16638
please address
https://github.com/apache/spark/pull/16638#discussion_r97471913
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
ping @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
Happy Chinese New Year ! @gatorsmile
The Spring Festival holiday just ended, and I return to work today, what
work do I need to do?
---
If your project is set up for it, you can reply
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
ping @ouyangxiaochen : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71904/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #71904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71904/testReport)**
for PR 16638 at commit
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
I have fixed the error of test cases and they run successfully. So,please
run the test cases again.Thanks a lot! @SparkQA
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #71904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71904/testReport)**
for PR 16638 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71887/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #71887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71887/testReport)**
for PR 16638 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16638
**[Test build #71887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71887/testReport)**
for PR 16638 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
@ouyangxiaochen Please do not duplicate the test cases. Try to combine
them.
@cloud-fan @yhuai Could you please check whether such a DDL support is
desirable?
---
If your project
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
I am sorry that I did't grasp the key points of your question. In Hive, if
there are data files under the specified path while creating an external table,
then Hive will identify the files
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
Please keep updating your PR description. For example, this PR is not
relying on `manual tests`. In addition, you also need to summarize what this PR
did. List more details to help reviewers
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
Let me rephrase it. If the directory specified in the `LOCATION` spec
contains the other files, what does Hive behave?
---
If your project is set up for it, you can reply to this email and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
First, please change the PR title to `[SPARK-19115] [SQL] Supporting Create
External Table Like Location`
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
Here is the differences between Hive and Spark2.x as follow:
1.Hive
create table test(id int); --> MANAGED_TABLE
create table test(id int) location '/warehouse/test'; -->
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
In the PR, you might need to consider more scenarios. For example, let me
ask a question. How does Hive behave when the specified location is not empty?
---
If your project is set up for it,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
We have a few test cases you can follow. Please create test cases. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
Could you follow the title requirement in
http://spark.apache.org/contributing.html?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16638
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
46 matches
Mail list logo
