[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-11-10 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/17631 @gatorsmile @maropu I took over. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-07-20 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17631 cc @maropu How about taking this over? You can follow the solution we used for partitioning columns? --- - To unsubscribe,

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-07-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-05-21 Thread umesh9794
Github user umesh9794 commented on the issue: https://github.com/apache/spark/pull/17631 @marmbrus, requesting again for your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-04-20 Thread umesh9794
Github user umesh9794 commented on the issue: https://github.com/apache/spark/pull/17631 Thanks @squito for the review. I believe having single quotes in name can cause issues on peer systems e.g. databases (JDBC), SERDE types etc. So stripping them all would be the preferred way to

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-04-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17631 this doesn't seem safe in general. spark treats quotes as a valid part of the name, eg: ```scala scala> val df = sc.parallelize(1 to 10).map { x => (x, (x + 1).toLong, (x -

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-04-19 Thread umesh9794
Github user umesh9794 commented on the issue: https://github.com/apache/spark/pull/17631 @marmbrus @squito @vanzin , may I ask you to review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-04-19 Thread umesh9794
Github user umesh9794 commented on the issue: https://github.com/apache/spark/pull/17631 @marmbrus @squito @vanzin , may I ask you to review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17631: [SPARK-20319][SQL] Already quoted identifiers are gettin...

2017-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17631 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this