[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18836 @BoleynSu Sure, I can do it. Will give all the credits to you. Please continue to help us report new issues or fixes. Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread BoleynSu
Github user BoleynSu commented on the issue: https://github.com/apache/spark/pull/18836 @gatorsmile I am not familiar with the PR process, it is great that you can take it over. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18836 @BoleynSu Do you want to continue the PR? or you want us to take it over? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread BoleynSu
Github user BoleynSu commented on the issue: https://github.com/apache/spark/pull/18836 A test case to make the existing code fail. @srowen I am sorry that this pull request is not well formatted but I just want to help. ```scala import org.apache.spark.sql.SparkSession

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18836 Thanks for fixing this. Please follow the contribution guideline. Also, you need to add a test case. You can follow what we did in this PR: https://github.com/apache/spark/pull/17339

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18836 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18836 You didn't read the link above, I take it? http://spark.apache.org/contributing.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as