Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Thanks for explanation. I guess there would be a big doc change soon? Will
check those changes too.
---
-
To unsubscribe,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19485
The reference manual and API docs are different. Below is a link of DB2 LUW:
http://www-01.ibm.com/support/docview.wss?uid=swg27038855
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
@gatorsmile, sure, detailed doc is great and defintely I support it.
Just one thing I am worried of is duplication. If we add or change option,
we have to update those together and ..
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19485
Sure, I'll be working on this for this weekend. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19485
This is the API link you refer
`https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.DataFrameReader@csv(paths:String*):org.apache.spark.sql.DataFrame`
I just
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
I meant adding a new chapter describing options, removing duplication, for
example here
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19485
@HyukjinKwon I did not understand what is your suggestion.
@jomach Any reason you closed this PR or you plan to open a new one?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Could it be an option to leave a link back to the new page in the API doc
to refer the options and remove the option list in API doc @gatorsmile and
@liancheng?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
My only worry is duplication and we would have another place to update the
doc for options. Others sound okay to me too.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19485
Appreciate it. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
@gatorsmile will do
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19485
Just checked it with @liancheng Both think creating a separate page sounds
good.
Also cc @rxin
---
-
To
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
@gatorsmile: we will have a lot of duplication.
Ist that Fine ? I will create a complete new Page like sql programming
guide and name it Data sources guide and add all the data sources with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19485
@jomach and @HyukjinKwon
I did not generate the doc. I think we should follow what we did for JDBC.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
@gatorsmile WDYT?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
Yes I'm viewing the docs with Jekyll. I addressed that on my previous
comment. I really don't think we should make a huge example as the json does.
It's a csv ...
What do you think ?
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Less duplication is good but could we similar contents with
http://spark.apache.org/docs/latest/sql-programming-guide.html#json-datasets?
It looks the examples are quite different.
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
So I removed the duplicated stuff and added the links. I do it on purpose
not to add more example as the document is getting huge and hard to find stuff.
What do you think ?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Yup, I think that's what I initially intended in the JIRA. Not sure for the
iframe idea, for now. I'd just make it simple like with links.
---
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
Ok so I will do:
- Create a new Section for csv-datasets
- add more example options on the code fromJavaSQLDataSourceExample.java
(.scala .py and .r)
- Make reference to the links
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Thanks for taking a look for this one. Actually, I thought we should add a
chapter like
http://spark.apache.org/docs/latest/sql-programming-guide.html#json-datasets
And, add a link to,
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
@HyukjinKwon I came up with this. What do you think ? What I don't like on
it is that I did not find anyway to read Javadocs into the markdown so that we
don't have duplicates. Any ideia or should
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Sure, please take your time.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
Yes I will do it. give me some days please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19485
Oh, @jomach, I had to be clear. I actually left it so that followup
addressing https://github.com/apache/spark/pull/19429#issuecomment-335732059
could fix this newline issue together. Would you
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19485
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jomach commented on the issue:
https://github.com/apache/spark/pull/19485
@HyukjinKwon Here is the enter as the other is closed / merged
---
-
To unsubscribe, e-mail:
27 matches
Mail list logo
