[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/19567 Thanks @wangyum and @viirya, I'll add the corresponding tests in `PostgresIntegrationSuite`. To @viirya , I'm not sure if the other data types will work, will consider them into tests, thanks!

[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19567 Besides uuid, other PostgreSQL types such as "cidr", "inet", they are treated as StringType too, will they work? --- - To

[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19567 Seems that we don't even have test against uuid column, when you create test for uuid[], can you also create test for uuid? Thanks. ---

[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19567 @jmchung You can add unit test into `PostgresIntegrationSuite`. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/19567 Please add tests to https://github.com/apache/spark/blob/master/external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala ---

[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19567 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19567: [SPARK-22291] Postgresql UUID[] to Cassandra: Conversion...

2017-10-24 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/19567 cc @viirya Can you help review this? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional