Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
Merged to master and branch-2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87914/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87914/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87914/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87883/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87883/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87883/testReport)**
for PR 20618 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87860/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87860/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87860/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87803/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87803/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87803/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87798/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87798/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87798/testReport)**
for PR 20618 at commit
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
I included java.lang.Math references in functions.R
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87796/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87796/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87796/testReport)**
for PR 20618 at commit
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
As discussed in email R documentation is reorganized and math functions are
grouped as part of SPARK-20889. Because of this grouping I dont think this
change is really applicable on R. @srowen,
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
@felixcheung, I have started a mail thread on d...@spark.apache.org with
title _Help needed in R documentation generation_ because I did not feel it is
directly related to this PR. Thanks for your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20618
@misutoth what exactly is the problem you are running into?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
cc @felixcheung (I saw you and Felix in dev mailing list). So,
https://github.com/apache/spark/tree/master/R#generating-documentation does not
work?
---
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
Sorry, I missed these comments. As I understood we fix all of them here. I
am just struggling with the R documentation: it seems the generated doc is
incorrect even if I just take the latest
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20618
Also cc @srinathshankar
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20618
Was the result to add more changes to this PR or add them in another PR?
---
-
To unsubscribe, e-mail:
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
Sure, lets do that, no problem.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
I just thought about this again and yup I am fine. @misutoth shall we just
fix R and Python ones too here? I think we could just target to fix the current
functions in other language's API.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20618
@HyukjinKwon I think it's fine to refer to `java.lang.Math` even from
Python, R documents. It's just expressing the API's behavior, and that contract
is the same regardless of the language. (Or is
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
Looking back I guess we can expect a couple of comments on R and Python
side too, though I will target a lower number of them. :) So I am a little bit
favoring moving functions.* update into a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87554/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87554/testReport)**
for PR 20618 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
Maybe I am too much caring about this and It guess it wouldn't be a big
change; however, I was thinking there might be subtle nits, like, referring
`java.lang.Math*` in Python side and R side
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20618
Consistency is good. You're suggesting updating Python, R separately? If
it's a big change, I could see breaking it up, but could also imagine adjusting
that here. I am OK with getting this in first
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87551/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87551/testReport)**
for PR 20618 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
@misutoth, I am sorry. I missed
https://github.com/apache/spark/pull/20618#discussion_r169291756 and discussion
in the JIRA.
@srowen, I was thinking about having the same description
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87554/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87551/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87547/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87547/testReport)**
for PR 20618 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87546/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87546 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87546/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87547/testReport)**
for PR 20618 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20618
**[Test build #87546 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87546/testReport)**
for PR 20618 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20618
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20618
Thanks @srowen and @HyukjinKwon for your comments so far ...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20618
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
61 matches
Mail list logo
