Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
Sure. Although I'm not sure why other committers who review PRs don't just
merge them too...
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20893
I see. Could you merge that PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
The test is fixed by #20950. Just push that one instead.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20893
Let me revert this PR from the master. Please resubmit the PR after
addressing the flaky tests. Thanks!
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20893
cc @vanzin @sahilTakiar @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20893
Could we revert the PR from the master brach too?
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20893
Thank you so much for swift action, @vanzin !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
Let me revert the change from 2.3 and open a bug for the flaky test.
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20893
Hi, @vanzin and @sahilTakiar .
Could you take a look at `branch-2.3` hadoop-2.6 parts? It dosen't happen
for all branches, but it seems to become unstable a little bit.
-
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88679/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20893
**[Test build #88679 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88679/testReport)**
for PR 20893 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20893
**[Test build #88679 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88679/testReport)**
for PR 20893 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
SGTM. Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/20893
Wrote a test in `SparkLauncherSuite` and was able to replicate the error
from HIVE-18533, and then realized the exception is only logged and then
swallowed. From `SparkContext`
```
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88604/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20893
**[Test build #88604 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88604/testReport)**
for PR 20893 at commit
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/20893
Ok, I'll work on writing a test for `SparkLauncherSuite`.
The test added here was meant to cover the race condition mentioned
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
The change looks ok but the test being added is totally unrelated to it.
If you want to write a test, it should be not too hard to add something to
`SparkLauncherSuite` in `core/`. Start an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20893
**[Test build #88604 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88604/testReport)**
for PR 20893 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20893
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20893
**[Test build #88577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88577/testReport)**
for PR 20893 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88577/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20893
**[Test build #88577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88577/testReport)**
for PR 20893 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20893
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20893
The change looks good, cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20893
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
32 matches
Mail list logo
